[V2,2/7] soc: imx: gpcv2: Update imx8m-power.h to include iMX8M Mini
diff mbox series

Message ID 20191213160542.15757-3-aford173@gmail.com
State New
Headers show
Series
  • soc: imx: Enable additional functionality of i.MX8M Mini
Related show

Commit Message

Adam Ford Dec. 13, 2019, 4:05 p.m. UTC
In preparation for i.MX8M Mini support in the GPC driver, the
include file used by both the device tree and the source needs to
have the appropriate references for it.

Signed-off-by: Adam Ford <aford173@gmail.com>
---
V2:  No Change

 include/dt-bindings/power/imx8m-power.h | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

Rob Herring Dec. 19, 2019, 11:41 p.m. UTC | #1
On Fri, Dec 13, 2019 at 10:05:37AM -0600, Adam Ford wrote:
> In preparation for i.MX8M Mini support in the GPC driver, the
> include file used by both the device tree and the source needs to
> have the appropriate references for it.
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> ---
> V2:  No Change
> 
>  include/dt-bindings/power/imx8m-power.h | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/include/dt-bindings/power/imx8m-power.h b/include/dt-bindings/power/imx8m-power.h
> index 8a513bd9166e..0054bba744b8 100644
> --- a/include/dt-bindings/power/imx8m-power.h
> +++ b/include/dt-bindings/power/imx8m-power.h
> @@ -18,4 +18,18 @@
>  #define IMX8M_POWER_DOMAIN_MIPI_CSI2	9
>  #define IMX8M_POWER_DOMAIN_PCIE2	10
>  
> +#define IMX8MM_POWER_DOMAIN_MIPI	0
> +#define IMX8MM_POWER_DOMAIN_PCIE	1
> +#define IMX8MM_POWER_DOMAIN_USB_OTG1	2
> +#define IMX8MM_POWER_DOMAIN_USB_OTG2	3
> +#define IMX8MM_POWER_DOMAIN_DDR1	4
> +#define IMX8MM_POWER_DOMAIN_GPU2D	5
> +#define IMX8MM_POWER_DOMAIN_GPU	6
> +#define IMX8MM_POWER_DOMAIN_VPU	7
> +#define IMX8MM_POWER_DOMAIN_GPU3D	8
> +#define IMX8MM_POWER_DOMAIN_DISP	9
> +#define IMX8MM_POWER_VPU_G1		10
> +#define IMX8MM_POWER_VPU_G2		11
> +#define IMX8MM_POWER_VPU_H1		12

Why is _DOMAIN missing from the last 3?

> +
>  #endif
> -- 
> 2.20.1
>
Adam Ford Dec. 20, 2019, 1:16 p.m. UTC | #2
On Thu, Dec 19, 2019 at 5:41 PM Rob Herring <robh@kernel.org> wrote:
>
> On Fri, Dec 13, 2019 at 10:05:37AM -0600, Adam Ford wrote:
> > In preparation for i.MX8M Mini support in the GPC driver, the
> > include file used by both the device tree and the source needs to
> > have the appropriate references for it.
> >
> > Signed-off-by: Adam Ford <aford173@gmail.com>
> > ---
> > V2:  No Change
> >
> >  include/dt-bindings/power/imx8m-power.h | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >
> > diff --git a/include/dt-bindings/power/imx8m-power.h b/include/dt-bindings/power/imx8m-power.h
> > index 8a513bd9166e..0054bba744b8 100644
> > --- a/include/dt-bindings/power/imx8m-power.h
> > +++ b/include/dt-bindings/power/imx8m-power.h
> > @@ -18,4 +18,18 @@
> >  #define IMX8M_POWER_DOMAIN_MIPI_CSI2 9
> >  #define IMX8M_POWER_DOMAIN_PCIE2     10
> >
> > +#define IMX8MM_POWER_DOMAIN_MIPI     0
> > +#define IMX8MM_POWER_DOMAIN_PCIE     1
> > +#define IMX8MM_POWER_DOMAIN_USB_OTG1 2
> > +#define IMX8MM_POWER_DOMAIN_USB_OTG2 3
> > +#define IMX8MM_POWER_DOMAIN_DDR1     4
> > +#define IMX8MM_POWER_DOMAIN_GPU2D    5
> > +#define IMX8MM_POWER_DOMAIN_GPU      6
> > +#define IMX8MM_POWER_DOMAIN_VPU      7
> > +#define IMX8MM_POWER_DOMAIN_GPU3D    8
> > +#define IMX8MM_POWER_DOMAIN_DISP     9
> > +#define IMX8MM_POWER_VPU_G1          10
> > +#define IMX8MM_POWER_VPU_G2          11
> > +#define IMX8MM_POWER_VPU_H1          12
>
> Why is _DOMAIN missing from the last 3?

I will go back and review it.

adam
>
> > +
> >  #endif
> > --
> > 2.20.1
> >

Patch
diff mbox series

diff --git a/include/dt-bindings/power/imx8m-power.h b/include/dt-bindings/power/imx8m-power.h
index 8a513bd9166e..0054bba744b8 100644
--- a/include/dt-bindings/power/imx8m-power.h
+++ b/include/dt-bindings/power/imx8m-power.h
@@ -18,4 +18,18 @@ 
 #define IMX8M_POWER_DOMAIN_MIPI_CSI2	9
 #define IMX8M_POWER_DOMAIN_PCIE2	10
 
+#define IMX8MM_POWER_DOMAIN_MIPI	0
+#define IMX8MM_POWER_DOMAIN_PCIE	1
+#define IMX8MM_POWER_DOMAIN_USB_OTG1	2
+#define IMX8MM_POWER_DOMAIN_USB_OTG2	3
+#define IMX8MM_POWER_DOMAIN_DDR1	4
+#define IMX8MM_POWER_DOMAIN_GPU2D	5
+#define IMX8MM_POWER_DOMAIN_GPU	6
+#define IMX8MM_POWER_DOMAIN_VPU	7
+#define IMX8MM_POWER_DOMAIN_GPU3D	8
+#define IMX8MM_POWER_DOMAIN_DISP	9
+#define IMX8MM_POWER_VPU_G1		10
+#define IMX8MM_POWER_VPU_G2		11
+#define IMX8MM_POWER_VPU_H1		12
+
 #endif