| Message ID | 20191215164757.53130-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [CI] drm/i915: opregion: set opregion chpd value to indicate the driver handles hotplug | expand |
Hi, On 15-12-2019 21:08, Patchwork wrote: > == Series Details == > > Series: drm/i915: opregion: set opregion chpd value to indicate the driver handles hotplug (rev4) > URL : https://patchwork.freedesktop.org/series/69902/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_7569_full -> Patchwork_15774_full > ==================================================== > > Summary > ------- > > **FAILURE** > > Serious unknown changes coming with Patchwork_15774_full absolutely need to be > verified manually. > > If you think the reported changes have nothing to do with the changes > introduced in Patchwork_15774_full, please notify your bug team to allow them > to document this new failure mode, which will reduce false positives in CI. > > > > Possible new issues > ------------------- > > Here are the unknown changes that may have been introduced in Patchwork_15774_full: > > ### IGT changes ### > > #### Possible regressions #### > > * igt@runner@aborted: > - shard-apl: NOTRUN -> ([FAIL][1], [FAIL][2]) > [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-apl6/igt@runner@aborted.html > [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-apl4/igt@runner@aborted.html Yeah, so this is quite likely an unrelated failure, the chpd change really only impacts ACPI behavior on LID open/close where as this crash is a NULL-ptr deref from __intel_fb_flush so it seems unlikely that this is a regression caused by the change which is being tested. <7>[ 64.933610] [drm:drm_mode_addfb2] [FB:127] <7>[ 64.934536] [drm:drm_mode_addfb2] [FB:127] <7>[ 64.936430] [drm:drm_mode_addfb2] [FB:127] <7>[ 64.937482] [drm:drm_mode_addfb2] [FB:127] <7>[ 64.939048] [drm:drm_mode_addfb2] [FB:127] <7>[ 64.939847] [drm:drm_mode_addfb2] [FB:127] <4>[ 64.940360] general protection fault: 0000 [#1] PREEMPT SMP NOPTI <4>[ 64.940369] CPU: 2 PID: 40 Comm: kworker/u8:1 Tainted: G U 5.5.0-rc1-CI-Patchwork_15774+ #1 <4>[ 64.940372] Hardware name: /NUC6CAYB, BIOS AYAPLCEL.86A.0049.2018.0508.1356 05/08/2018 <4>[ 64.940471] Workqueue: events_unbound fence_work [i915] <7>[ 64.940477] [drm:drm_mode_addfb2] [FB:127] <4>[ 64.940570] RIP: 0010:__intel_fb_flush+0x14/0x70 [i915] <4>[ 64.940574] Code: e8 d1 82 7f e1 eb 9a 0f 1f 44 00 00 66 2e 0f 1f 84 00 00 00 00 00 41 54 55 53 89 d3 48 83 ec 08 48 8b 87 58 01 00 00 83 fe 02 <48> 8b 68 08 74 21 85 db 75 09 48 83 c4 08 5b 5d 41 5c c3 48 83 c4 <4>[ 64.940576] RSP: 0018:ffffc90000183e00 EFLAGS: 00010297 <4>[ 64.940580] RAX: 6b6b6b6b6b6b6b6b RBX: 000000006b6b6b6b RCX: 0000000000000000 <4>[ 64.940582] RDX: 000000006b6b6b6b RSI: 0000000000000001 RDI: ffff88826e18e800 <4>[ 64.940584] RBP: ffffc90000183e40 R08: ffff8882766d08f8 R09: 00000000fffffffe <4>[ 64.940586] R10: 0000000000000000 R11: 00000000dcf23fdc R12: ffff888276c89000 <4>[ 64.940587] R13: ffff888276ca8200 R14: ffff88825a8c4730 R15: ffff88826e18eef8 <4>[ 64.940590] FS: 0000000000000000(0000) GS:ffff888277d00000(0000) knlGS:0000000000000000 <4>[ 64.940592] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 <4>[ 64.940594] CR2: 00007f8c9b0f5900 CR3: 0000000271c22000 CR4: 00000000003406e0 <4>[ 64.940595] Call Trace: <4>[ 64.940681] clflush_work+0x7f/0x1e0 [i915] <4>[ 64.940758] fence_work+0x1c/0x90 [i915] <4>[ 64.940767] process_one_work+0x26a/0x620 <4>[ 64.940775] worker_thread+0x37/0x380 <4>[ 64.940781] ? process_one_work+0x620/0x620 <4>[ 64.940784] kthread+0x119/0x130 <4>[ 64.940788] ? kthread_park+0x80/0x80 <4>[ 64.940794] ret_from_fork+0x3a/0x50 Since BAT did pass and this seems a false positive I plan to push this patch soonish. Regards, Hans > > > #### Suppressed #### > > The following results come from untrusted machines, tests, or statuses. > They do not affect the overall result. > > * {igt@gen9_exec_parse@allowed-single}: > - shard-apl: [PASS][3] -> [DMESG-WARN][4] > [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-apl2/igt@gen9_exec_parse@allowed-single.html > [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-apl4/igt@gen9_exec_parse@allowed-single.html > - shard-skl: [PASS][5] -> [DMESG-WARN][6] > [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-skl3/igt@gen9_exec_parse@allowed-single.html > [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-skl10/igt@gen9_exec_parse@allowed-single.html > > > > ### Piglit changes ### > > #### Possible regressions #### > > * spec@arb_gpu_shader5@texturegatheroffsets@vs-rgba-1-int-2drect (NEW): > - pig-hsw-4770r: NOTRUN -> [FAIL][7] +94 similar issues > [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/pig-hsw-4770r/spec@arb_gpu_shader5@texturegatheroffsets@vs-rgba-1-int-2drect.html > > > New tests > --------- > > New tests have been introduced between CI_DRM_7569_full and Patchwork_15774_full: > > ### New Piglit tests (95) ### > > * spec@arb_gpu_shader5@texturegather@vs-r-0-uint-2d: > - Statuses : 1 fail(s) > - Exec time: [1.72] s > > * spec@arb_gpu_shader5@texturegather@vs-r-0-uint-2darray: > - Statuses : 1 fail(s) > - Exec time: [1.76] s > > * spec@arb_gpu_shader5@texturegather@vs-r-0-uint-2drect: > - Statuses : 1 fail(s) > - Exec time: [1.56] s > > * spec@arb_gpu_shader5@texturegather@vs-rg-0-uint-2d: > - Statuses : 1 fail(s) > - Exec time: [1.77] s > > * spec@arb_gpu_shader5@texturegather@vs-rg-0-uint-2darray: > - Statuses : 1 fail(s) > - Exec time: [1.79] s > > * spec@arb_gpu_shader5@texturegather@vs-rg-0-uint-2drect: > - Statuses : 1 fail(s) > - Exec time: [1.77] s > > * spec@arb_gpu_shader5@texturegather@vs-rg-0-uint-cube: > - Statuses : 1 fail(s) > - Exec time: [1.72] s > > * spec@arb_gpu_shader5@texturegather@vs-rg-1-uint-2d: > - Statuses : 1 fail(s) > - Exec time: [1.75] s > > * spec@arb_gpu_shader5@texturegather@vs-rg-1-uint-2darray: > - Statuses : 1 fail(s) > - Exec time: [1.74] s > > * spec@arb_gpu_shader5@texturegather@vs-rg-1-uint-2drect: > - Statuses : 1 fail(s) > - Exec time: [1.75] s > > * spec@arb_gpu_shader5@texturegather@vs-rg-1-uint-cube: > - Statuses : 1 fail(s) > - Exec time: [1.65] s > > * spec@arb_gpu_shader5@texturegather@vs-rg-1-uint-cubearray: > - Statuses : 1 fail(s) > - Exec time: [1.62] s > > * spec@arb_gpu_shader5@texturegather@vs-rgb-2-int-2d: > - Statuses : 1 fail(s) > - Exec time: [1.79] s > > * spec@arb_gpu_shader5@texturegather@vs-rgba-0-int-2d: > - Statuses : 1 fail(s) > - Exec time: [1.67] s > > * spec@arb_gpu_shader5@texturegather@vs-rgba-0-int-2darray: > - Statuses : 1 fail(s) > - Exec time: [1.70] s > > * spec@arb_gpu_shader5@texturegather@vs-rgba-0-int-2drect: > - Statuses : 1 fail(s) > - Exec time: [1.69] s > > * spec@arb_gpu_shader5@texturegather@vs-rgba-0-int-cube: > - Statuses : 1 fail(s) > - Exec time: [1.61] s > > * spec@arb_gpu_shader5@texturegather@vs-rgba-0-int-cubearray: > - Statuses : 1 fail(s) > - Exec time: [1.80] s > > * spec@arb_gpu_shader5@texturegather@vs-rgba-0-unorm-2d: > - Statuses : 1 fail(s) > - Exec time: [1.64] s > > * spec@arb_gpu_shader5@texturegather@vs-rgba-1-int-2d: > - Statuses : 1 fail(s) > - Exec time: [1.80] s > > * spec@arb_gpu_shader5@texturegather@vs-rgba-1-int-2darray: > - Statuses : 1 fail(s) > - Exec time: [1.64] s > > * spec@arb_gpu_shader5@texturegather@vs-rgba-1-int-2drect: > - Statuses : 1 fail(s) > - Exec time: [1.55] s > > * spec@arb_gpu_shader5@texturegather@vs-rgba-1-int-cube: > - Statuses : 1 fail(s) > - Exec time: [1.73] s > > * spec@arb_gpu_shader5@texturegather@vs-rgba-1-int-cubearray: > - Statuses : 1 fail(s) > - Exec time: [1.54] s > > * spec@arb_gpu_shader5@texturegather@vs-rgba-2-int-2d: > - Statuses : 1 fail(s) > - Exec time: [1.67] s > > * spec@arb_gpu_shader5@texturegather@vs-rgba-2-int-2darray: > - Statuses : 1 fail(s) > - Exec time: [1.68] s > > * spec@arb_gpu_shader5@texturegather@vs-rgba-2-int-2drect: > - Statuses : 1 fail(s) > - Exec time: [1.73] s > > * spec@arb_gpu_shader5@texturegather@vs-rgba-2-int-cube: > - Statuses : 1 fail(s) > - Exec time: [1.72] s > > * spec@arb_gpu_shader5@texturegather@vs-rgba-2-int-cubearray: > - Statuses : 1 fail(s) > - Exec time: [1.75] s > > * spec@arb_gpu_shader5@texturegather@vs-rgba-3-int-2d: > - Statuses : 1 fail(s) > - Exec time: [1.64] s > > * spec@arb_gpu_shader5@texturegather@vs-rgba-3-int-2darray: > - Statuses : 1 fail(s) > - Exec time: [1.77] s > > * spec@arb_gpu_shader5@texturegather@vs-rgba-3-int-2drect: > - Statuses : 1 fail(s) > - Exec time: [1.64] s > > * spec@arb_gpu_shader5@texturegather@vs-rgba-3-int-cube: > - Statuses : 1 fail(s) > - Exec time: [1.73] s > > * spec@arb_gpu_shader5@texturegather@vs-rgba-3-int-cubearray: > - Statuses : 1 fail(s) > - Exec time: [1.73] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-r-0-uint-2d: > - Statuses : 1 fail(s) > - Exec time: [7.22] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-r-0-uint-2drect: > - Statuses : 1 fail(s) > - Exec time: [6.86] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-r-0-uint-2drect-const: > - Statuses : 1 fail(s) > - Exec time: [7.03] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-rg-0-uint-2d: > - Statuses : 1 fail(s) > - Exec time: [6.98] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-rg-0-uint-2d-const: > - Statuses : 1 fail(s) > - Exec time: [6.78] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-rg-1-uint-2d: > - Statuses : 1 fail(s) > - Exec time: [7.36] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-rg-1-uint-2d-const: > - Statuses : 1 fail(s) > - Exec time: [7.00] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-rgb-0-int-2drect: > - Statuses : 1 fail(s) > - Exec time: [11.10] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-rgb-0-int-2drect-const: > - Statuses : 1 fail(s) > - Exec time: [11.29] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-rgb-1-int-2drect: > - Statuses : 1 fail(s) > - Exec time: [11.14] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-rgb-1-int-2drect-const: > - Statuses : 1 fail(s) > - Exec time: [11.10] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-rgb-2-int-2drect: > - Statuses : 1 fail(s) > - Exec time: [10.99] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-rgb-2-int-2drect-const: > - Statuses : 1 fail(s) > - Exec time: [10.82] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-rgba-0-int-2d: > - Statuses : 1 fail(s) > - Exec time: [7.01] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-rgba-0-int-2d-const: > - Statuses : 1 fail(s) > - Exec time: [6.80] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-rgba-0-int-2darray: > - Statuses : 1 fail(s) > - Exec time: [6.85] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-rgba-0-int-2darray-const: > - Statuses : 1 fail(s) > - Exec time: [7.20] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-rgba-0-int-2drect: > - Statuses : 1 fail(s) > - Exec time: [7.00] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-rgba-0-int-2drect-const: > - Statuses : 1 fail(s) > - Exec time: [6.86] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-rgba-1-int-2d: > - Statuses : 1 fail(s) > - Exec time: [7.10] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-rgba-1-int-2d-const: > - Statuses : 1 fail(s) > - Exec time: [6.88] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-rgba-1-int-2darray: > - Statuses : 1 fail(s) > - Exec time: [6.93] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-rgba-1-int-2darray-const: > - Statuses : 1 fail(s) > - Exec time: [7.01] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-rgba-1-int-2drect: > - Statuses : 1 fail(s) > - Exec time: [7.09] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-rgba-1-int-2drect-const: > - Statuses : 1 fail(s) > - Exec time: [7.24] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-rgba-2-int-2d: > - Statuses : 1 fail(s) > - Exec time: [7.17] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-rgba-2-int-2d-const: > - Statuses : 1 fail(s) > - Exec time: [7.27] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-rgba-2-int-2darray: > - Statuses : 1 fail(s) > - Exec time: [7.33] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-rgba-2-int-2darray-const: > - Statuses : 1 fail(s) > - Exec time: [6.77] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-rgba-2-int-2drect: > - Statuses : 1 fail(s) > - Exec time: [6.69] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-rgba-2-int-2drect-const: > - Statuses : 1 fail(s) > - Exec time: [7.05] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-rgba-2-unorm-2darray: > - Statuses : 1 fail(s) > - Exec time: [7.13] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-rgba-3-int-2d: > - Statuses : 1 fail(s) > - Exec time: [7.01] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-rgba-3-int-2d-const: > - Statuses : 1 fail(s) > - Exec time: [7.15] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-rgba-3-int-2darray: > - Statuses : 1 fail(s) > - Exec time: [6.97] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-rgba-3-int-2darray-const: > - Statuses : 1 fail(s) > - Exec time: [7.02] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-rgba-3-int-2drect: > - Statuses : 1 fail(s) > - Exec time: [7.12] s > > * spec@arb_gpu_shader5@texturegatheroffset@vs-rgba-3-int-2drect-const: > - Statuses : 1 fail(s) > - Exec time: [7.42] s > > * spec@arb_gpu_shader5@texturegatheroffsets@vs-r-0-uint-2drect: > - Statuses : 1 fail(s) > - Exec time: [6.81] s > > * spec@arb_gpu_shader5@texturegatheroffsets@vs-rg-0-uint-2d: > - Statuses : 1 fail(s) > - Exec time: [7.17] s > > * spec@arb_gpu_shader5@texturegatheroffsets@vs-rg-1-uint-2d: > - Statuses : 1 fail(s) > - Exec time: [6.90] s > > * spec@arb_gpu_shader5@texturegatheroffsets@vs-rgb-0-int-2drect: > - Statuses : 1 fail(s) > - Exec time: [7.26] s > > * spec@arb_gpu_shader5@texturegatheroffsets@vs-rgb-1-int-2drect: > - Statuses : 1 fail(s) > - Exec time: [7.28] s > > * spec@arb_gpu_shader5@texturegatheroffsets@vs-rgb-2-int-2drect: > - Statuses : 1 fail(s) > - Exec time: [7.05] s > > * spec@arb_gpu_shader5@texturegatheroffsets@vs-rgba-0-int-2d: > - Statuses : 1 fail(s) > - Exec time: [6.77] s > > * spec@arb_gpu_shader5@texturegatheroffsets@vs-rgba-0-int-2darray: > - Statuses : 1 fail(s) > - Exec time: [7.46] s > > * spec@arb_gpu_shader5@texturegatheroffsets@vs-rgba-0-int-2drect: > - Statuses : 1 fail(s) > - Exec time: [6.84] s > > * spec@arb_gpu_shader5@texturegatheroffsets@vs-rgba-1-int-2d: > - Statuses : 1 fail(s) > - Exec time: [7.04] s > > * spec@arb_gpu_shader5@texturegatheroffsets@vs-rgba-1-int-2darray: > - Statuses : 1 fail(s) > - Exec time: [7.05] s > > * spec@arb_gpu_shader5@texturegatheroffsets@vs-rgba-1-int-2drect: > - Statuses : 1 fail(s) > - Exec time: [7.29] s > > * spec@arb_gpu_shader5@texturegatheroffsets@vs-rgba-2-int-2d: > - Statuses : 1 fail(s) > - Exec time: [6.94] s > > * spec@arb_gpu_shader5@texturegatheroffsets@vs-rgba-2-int-2darray: > - Statuses : 1 fail(s) > - Exec time: [6.93] s > > * spec@arb_gpu_shader5@texturegatheroffsets@vs-rgba-2-int-2drect: > - Statuses : 1 fail(s) > - Exec time: [6.87] s > > * spec@arb_gpu_shader5@texturegatheroffsets@vs-rgba-3-int-2d: > - Statuses : 1 fail(s) > - Exec time: [7.36] s > > * spec@arb_gpu_shader5@texturegatheroffsets@vs-rgba-3-int-2darray: > - Statuses : 1 fail(s) > - Exec time: [7.01] s > > * spec@arb_gpu_shader5@texturegatheroffsets@vs-rgba-3-int-2drect: > - Statuses : 1 fail(s) > - Exec time: [7.21] s > > * spec@arb_gpu_shader_fp64@execution@arb_gpu_shader_fp64-vs-non-uniform-control-flow-ssbo: > - Statuses : 1 fail(s) > - Exec time: [0.10] s > > * spec@arb_pixel_buffer_object@pbo-drawpixels: > - Statuses : 1 fail(s) > - Exec time: [0.07] s > > * spec@arb_vertex_attrib_64bit@execution@vs_in@vs-input-position-double_dvec2_array5-float_mat3x2: > - Statuses : 1 fail(s) > - Exec time: [0.19] s > > * spec@ext_polygon_offset_clamp@ext_polygon_offset_clamp-dlist: > - Statuses : 1 fail(s) > - Exec time: [0.19] s > > * spec@glsl-4.20@execution@vs_in@vs-input-float_mat4x2-double_dvec2-position: > - Statuses : 1 fail(s) > - Exec time: [0.20] s > > > > Known issues > ------------ > > Here are the changes found in Patchwork_15774_full that come from known issues: > > ### IGT changes ### > > #### Issues hit #### > > * igt@gem_ctx_isolation@vcs1-none: > - shard-iclb: [PASS][8] -> [SKIP][9] ([fdo#109276] / [fdo#112080]) > [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-iclb1/igt@gem_ctx_isolation@vcs1-none.html > [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-iclb6/igt@gem_ctx_isolation@vcs1-none.html > > * igt@gem_exec_async@concurrent-writes-bsd2: > - shard-iclb: [PASS][10] -> [SKIP][11] ([fdo#109276]) +4 similar issues > [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-iclb1/igt@gem_exec_async@concurrent-writes-bsd2.html > [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-iclb6/igt@gem_exec_async@concurrent-writes-bsd2.html > > * igt@gem_exec_schedule@preempt-other-chain-bsd: > - shard-iclb: [PASS][12] -> [SKIP][13] ([fdo#112146]) > [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-iclb6/igt@gem_exec_schedule@preempt-other-chain-bsd.html > [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-iclb1/igt@gem_exec_schedule@preempt-other-chain-bsd.html > > * igt@gem_ppgtt@flink-and-close-vma-leak: > - shard-apl: [PASS][14] -> [FAIL][15] ([i915#644]) > [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-apl2/igt@gem_ppgtt@flink-and-close-vma-leak.html > [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-apl2/igt@gem_ppgtt@flink-and-close-vma-leak.html > > * igt@gem_userptr_blits@sync-unmap: > - shard-snb: [PASS][16] -> [DMESG-WARN][17] ([fdo#111870]) > [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-snb1/igt@gem_userptr_blits@sync-unmap.html > [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-snb5/igt@gem_userptr_blits@sync-unmap.html > > * igt@gem_workarounds@suspend-resume-context: > - shard-apl: [PASS][18] -> [DMESG-WARN][19] ([i915#180]) +1 similar issue > [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-apl6/igt@gem_workarounds@suspend-resume-context.html > [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-apl1/igt@gem_workarounds@suspend-resume-context.html > > * igt@i915_hangman@error-state-capture-vcs1: > - shard-iclb: [PASS][20] -> [SKIP][21] ([fdo#112080]) +2 similar issues > [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-iclb1/igt@i915_hangman@error-state-capture-vcs1.html > [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-iclb6/igt@i915_hangman@error-state-capture-vcs1.html > > * igt@i915_selftest@mock_sanitycheck: > - shard-skl: [PASS][22] -> [DMESG-WARN][23] ([i915#747]) > [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-skl4/igt@i915_selftest@mock_sanitycheck.html > [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-skl7/igt@i915_selftest@mock_sanitycheck.html > > * igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding: > - shard-skl: [PASS][24] -> [FAIL][25] ([i915#54]) +4 similar issues > [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-skl6/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html > [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-skl1/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html > > * igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite: > - shard-tglb: [PASS][26] -> [FAIL][27] ([i915#49]) > [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html > [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-tglb3/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html > > * igt@kms_frontbuffer_tracking@fbc-suspend: > - shard-tglb: [PASS][28] -> [INCOMPLETE][29] ([i915#456] / [i915#460] / [i915#474]) > [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-suspend.html > [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-suspend.html > > * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a: > - shard-kbl: [PASS][30] -> [DMESG-WARN][31] ([i915#180]) +3 similar issues > [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-kbl4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html > [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-kbl4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html > > * igt@kms_plane@pixel-format-pipe-a-planes-source-clamping: > - shard-kbl: [PASS][32] -> [INCOMPLETE][33] ([fdo#103665] / [i915#648] / [i915#667]) > [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-kbl4/igt@kms_plane@pixel-format-pipe-a-planes-source-clamping.html > [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-kbl1/igt@kms_plane@pixel-format-pipe-a-planes-source-clamping.html > > * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min: > - shard-skl: [PASS][34] -> [FAIL][35] ([fdo#108145]) > [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-skl8/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html > [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-skl6/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html > > * igt@kms_setmode@basic: > - shard-hsw: [PASS][36] -> [FAIL][37] ([i915#31]) > [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-hsw5/igt@kms_setmode@basic.html > [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-hsw8/igt@kms_setmode@basic.html > - shard-kbl: [PASS][38] -> [FAIL][39] ([i915#31]) > [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-kbl1/igt@kms_setmode@basic.html > [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-kbl7/igt@kms_setmode@basic.html > > > #### Possible fixes #### > > * igt@gem_ctx_isolation@vcs0-s3: > - shard-apl: [DMESG-WARN][40] ([i915#180]) -> [PASS][41] > [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-apl6/igt@gem_ctx_isolation@vcs0-s3.html > [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-apl7/igt@gem_ctx_isolation@vcs0-s3.html > > * igt@gem_ctx_isolation@vcs1-reset: > - shard-iclb: [SKIP][42] ([fdo#109276] / [fdo#112080]) -> [PASS][43] > [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-iclb6/igt@gem_ctx_isolation@vcs1-reset.html > [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-iclb1/igt@gem_ctx_isolation@vcs1-reset.html > > * igt@gem_ctx_shared@q-smoketest-vebox: > - shard-tglb: [INCOMPLETE][44] ([fdo#111735]) -> [PASS][45] > [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-tglb6/igt@gem_ctx_shared@q-smoketest-vebox.html > [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-tglb1/igt@gem_ctx_shared@q-smoketest-vebox.html > > * igt@gem_eio@reset-stress: > - shard-snb: [FAIL][46] ([i915#232]) -> [PASS][47] > [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-snb2/igt@gem_eio@reset-stress.html > [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-snb7/igt@gem_eio@reset-stress.html > > * igt@gem_exec_balancer@smoke: > - shard-iclb: [SKIP][48] ([fdo#110854]) -> [PASS][49] > [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-iclb6/igt@gem_exec_balancer@smoke.html > [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-iclb1/igt@gem_exec_balancer@smoke.html > > * igt@gem_exec_create@madvise: > - shard-tglb: [INCOMPLETE][50] ([i915#435]) -> [PASS][51] > [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-tglb6/igt@gem_exec_create@madvise.html > [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-tglb7/igt@gem_exec_create@madvise.html > > * igt@gem_exec_gttfill@basic: > - shard-tglb: [INCOMPLETE][52] ([fdo#111593]) -> [PASS][53] > [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-tglb6/igt@gem_exec_gttfill@basic.html > [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-tglb9/igt@gem_exec_gttfill@basic.html > > * igt@gem_exec_params@invalid-bsd-ring: > - shard-iclb: [SKIP][54] ([fdo#109276]) -> [PASS][55] +1 similar issue > [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-iclb6/igt@gem_exec_params@invalid-bsd-ring.html > [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-iclb1/igt@gem_exec_params@invalid-bsd-ring.html > > * igt@gem_exec_schedule@preemptive-hang-bsd: > - shard-iclb: [SKIP][56] ([fdo#112146]) -> [PASS][57] +3 similar issues > [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-iclb1/igt@gem_exec_schedule@preemptive-hang-bsd.html > [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-iclb6/igt@gem_exec_schedule@preemptive-hang-bsd.html > > * igt@gem_userptr_blits@map-fixed-invalidate-busy-gup: > - shard-snb: [DMESG-WARN][58] ([fdo#111870]) -> [PASS][59] > [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-snb5/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html > [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-snb2/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html > > * igt@gem_workarounds@suspend-resume-fd: > - shard-iclb: [INCOMPLETE][60] ([i915#140]) -> [PASS][61] > [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-iclb3/igt@gem_workarounds@suspend-resume-fd.html > [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-iclb3/igt@gem_workarounds@suspend-resume-fd.html > > * igt@kms_cursor_crc@pipe-a-cursor-256x256-sliding: > - shard-skl: [FAIL][62] ([i915#54]) -> [PASS][63] > [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-skl5/igt@kms_cursor_crc@pipe-a-cursor-256x256-sliding.html > [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-skl6/igt@kms_cursor_crc@pipe-a-cursor-256x256-sliding.html > > * igt@kms_cursor_crc@pipe-c-cursor-suspend: > - shard-kbl: [DMESG-WARN][64] ([i915#180]) -> [PASS][65] +5 similar issues > [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-kbl7/igt@kms_cursor_crc@pipe-c-cursor-suspend.html > [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-kbl2/igt@kms_cursor_crc@pipe-c-cursor-suspend.html > > * igt@kms_draw_crc@draw-method-rgb565-blt-ytiled: > - shard-skl: [INCOMPLETE][66] ([i915#435] / [i915#667]) -> [PASS][67] > [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-skl2/igt@kms_draw_crc@draw-method-rgb565-blt-ytiled.html > [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-skl2/igt@kms_draw_crc@draw-method-rgb565-blt-ytiled.html > > * igt@kms_flip@flip-vs-suspend: > - shard-hsw: [INCOMPLETE][68] ([i915#61]) -> [PASS][69] > [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-hsw5/igt@kms_flip@flip-vs-suspend.html > [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-hsw5/igt@kms_flip@flip-vs-suspend.html > > * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min: > - shard-skl: [FAIL][70] ([fdo#108145]) -> [PASS][71] > [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-skl5/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html > [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-skl6/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html > > * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: > - shard-skl: [FAIL][72] ([fdo#108145] / [i915#265]) -> [PASS][73] > [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html > [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html > > * igt@perf_pmu@busy-accuracy-98-vcs1: > - shard-iclb: [SKIP][74] ([fdo#112080]) -> [PASS][75] +2 similar issues > [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-iclb6/igt@perf_pmu@busy-accuracy-98-vcs1.html > [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-iclb1/igt@perf_pmu@busy-accuracy-98-vcs1.html > > > #### Warnings #### > > * igt@gem_ctx_isolation@vcs2-nonpriv: > - shard-tglb: [SKIP][76] ([fdo#112080]) -> [SKIP][77] ([fdo#111912] / [fdo#112080]) > [76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-tglb9/igt@gem_ctx_isolation@vcs2-nonpriv.html > [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-tglb4/igt@gem_ctx_isolation@vcs2-nonpriv.html > > * igt@gem_eio@kms: > - shard-snb: [DMESG-WARN][78] ([i915#444]) -> [INCOMPLETE][79] ([i915#82]) > [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-snb4/igt@gem_eio@kms.html > [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-snb6/igt@gem_eio@kms.html > > * igt@kms_plane@pixel-format-pipe-b-planes: > - shard-skl: [INCOMPLETE][80] ([fdo#112347] / [fdo#112391] / [i915#648] / [i915#667]) -> [INCOMPLETE][81] ([fdo#112347] / [i915#648] / [i915#667]) +1 similar issue > [80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7569/shard-skl1/igt@kms_plane@pixel-format-pipe-b-planes.html > [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/shard-skl10/igt@kms_plane@pixel-format-pipe-b-planes.html > > > {name}: This element is suppressed. This means it is ignored when computing > the status of the difference (SUCCESS, WARNING, or FAILURE). > > [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665 > [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 > [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 > [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854 > [fdo#111593]: https://bugs.freedesktop.org/show_bug.cgi?id=111593 > [fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735 > [fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870 > [fdo#111912]: https://bugs.freedesktop.org/show_bug.cgi?id=111912 > [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080 > [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146 > [fdo#112347]: https://bugs.freedesktop.org/show_bug.cgi?id=112347 > [fdo#112391]: https://bugs.freedesktop.org/show_bug.cgi?id=112391 > [i915#140]: https://gitlab.freedesktop.org/drm/intel/issues/140 > [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 > [i915#232]: https://gitlab.freedesktop.org/drm/intel/issues/232 > [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 > [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31 > [i915#435]: https://gitlab.freedesktop.org/drm/intel/issues/435 > [i915#444]: https://gitlab.freedesktop.org/drm/intel/issues/444 > [i915#456]: https://gitlab.freedesktop.org/drm/intel/issues/456 > [i915#460]: https://gitlab.freedesktop.org/drm/intel/issues/460 > [i915#474]: https://gitlab.freedesktop.org/drm/intel/issues/474 > [i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49 > [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54 > [i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61 > [i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644 > [i915#648]: https://gitlab.freedesktop.org/drm/intel/issues/648 > [i915#667]: https://gitlab.freedesktop.org/drm/intel/issues/667 > [i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677 > [i915#747]: https://gitlab.freedesktop.org/drm/intel/issues/747 > [i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82 > > > Participating hosts (10 -> 11) > ------------------------------ > > Additional (1): pig-hsw-4770r > > > Build changes > ------------- > > * CI: CI-20190529 -> None > * Linux: CI_DRM_7569 -> Patchwork_15774 > > CI-20190529: 20190529 > CI_DRM_7569: 62c2abc0df8983aba79ba093413683c44e9c4748 @ git://anongit.freedesktop.org/gfx-ci/linux > IGT_5349: 048f58513d8b8ec6bb307a939f0ac959bc0f0e10 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools > Patchwork_15774: 354a1397dbe2f093cfe9638742b5d07e2e27e8f1 @ git://anongit.freedesktop.org/gfx-ci/linux > piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit > > == Logs == > > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15774/index.html >
diff --git a/drivers/gpu/drm/i915/display/intel_opregion.c b/drivers/gpu/drm/i915/display/intel_opregion.c index 969ade623691..e59b4992ba1b 100644 --- a/drivers/gpu/drm/i915/display/intel_opregion.c +++ b/drivers/gpu/drm/i915/display/intel_opregion.c @@ -941,6 +941,13 @@ int intel_opregion_setup(struct drm_i915_private *dev_priv) if (mboxes & MBOX_ACPI) { DRM_DEBUG_DRIVER("Public ACPI methods supported\n"); opregion->acpi = base + OPREGION_ACPI_OFFSET; + /* + * Indicate we handle monitor hotplug events ourselves so we do + * not need ACPI notifications for them. Disabling these avoids + * triggering the AML code doing the notifation, which may be + * broken as Windows also seems to disable these. + */ + opregion->acpi->chpd = 1; } if (mboxes & MBOX_SWSCI) {
According to both the old acpi_igd_opregion_spec_0.pdf and the newer skl_opregion_rev0p5.pdf opregion specification documents, if a driver handles hotplug events itself, it should set the opregion CHPD field to 1 to indicate this and the firmware should respond to this by no longer sending ACPI 0x00 notification events on e.g. lid-state changes. Specifically skl_opregion_rev0p5.pdf states thid in the documentation of the CHPD word: "Re-enumeration trigger logic in System BIOS MUST be disabled for all the Operating Systems supporting Hot-Plug (e.g., Windows* Longhorn and above)." Note the MUST in there. We ignore these notifications, so this should not be a problem but many recent DSTDs seem to all have the same copy-pasted bug in the GNOT() AML function which is used to send these notifications. Windows likely does not hit this bug as it presumably correcty sets CHPD to 1. Here is an example of the broken GNOT() method: Method (GNOT, 2, NotSerialized) { ... CEVT = Arg0 CSTS = 0x03 If (((CHPD == Zero) && (Arg1 == Zero))) { If (((OSYS > 0x07D0) || (OSYS < 0x07D6))) { Notify (PCI0, Arg1) } Else { Notify (GFX0, Arg1) } } ... Notice that the condition for the If is always true I believe that the || like needs to be an &&, but there is nothing we can do about this and in my own DSDT archive 55 of the 93 DSDTs have this issue. When the if is true the notification gets send to the PCI root instead of only to the GFX0 device. This causes Linux to re-enumerate PCI devices whenever the LID opens / closes, leading to unexpected messages in dmesg: Suspend through lid close: [ 313.598199] intel_atomisp2_pm 0000:00:03.0: Refused to change power state, currently in D3 [ 313.664453] intel_atomisp2_pm 0000:00:03.0: Refused to change power state, currently in D3 [ 313.737982] pci_bus 0000:01: Allocating resources [ 313.738036] pcieport 0000:00:1c.0: bridge window [io 0x1000-0x0fff] to [bus 01] add_size 1000 [ 313.738051] pcieport 0000:00:1c.0: bridge window [mem 0x00100000-0x000fffff 64bit pref] to [bus 01] add_size 200000 add_align 100000 [ 313.738111] pcieport 0000:00:1c.0: BAR 15: assigned [mem 0x91000000-0x911fffff 64bit pref] [ 313.738128] pcieport 0000:00:1c.0: BAR 13: assigned [io 0x1000-0x1fff] Resume: [ 813.623894] pci 0000:00:03.0: [8086:22b8] type 00 class 0x048000 [ 813.623955] pci 0000:00:03.0: reg 0x10: [mem 0x00000000-0x003fffff] [ 813.630477] pci 0000:00:03.0: BAR 0: assigned [mem 0x91c00000-0x91ffffff] [ 854.579101] intel_atomisp2_pm 0000:00:03.0: Refused to change power state, currently in D3 And more importantly this re-enumeration races with suspend/resume causing enumeration to not be complete when assert_isp_power_gated() from drivers/gpu/drm/i915/display/intel_display_power.c runs. This causes the !pci_dev_present(isp_ids) check in assert_isp_power_gated() to fail making the condition for the WARN true, leading to: [ 813.327886] ------------[ cut here ]------------ [ 813.327898] ISP not power gated [ 813.328028] WARNING: CPU: 2 PID: 2317 at drivers/gpu/drm/i915/display/intel_display_power.c:4870 intel_display_print_error_state+0x2b98/0x3a80 [i915] ... [ 813.328599] ---[ end trace f01e81b599596774 ]--- This commit fixes the unwanted ACPI notification on the PCI root device by setting CHPD to 1, so that the broken if condition in the AML never gets checked as notifications of type 0x00 are disabled altogether. Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/gpu/drm/i915/display/intel_opregion.c | 7 +++++++ 1 file changed, 7 insertions(+)