| Message ID | 20191216115158.862404-3-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/connector: Add support for specifying panel_orientation on the kernel cmdline | expand |
On Mon, Dec 16, 2019 at 12:51:58PM +0100, Hans de Goede wrote: > If the new video=... panel_orientation option is set for a connector, honor > it and setup a matching "panel orientation" property on the connector. > > BugLink: https://gitlab.freedesktop.org/plymouth/plymouth/merge_requests/83 > Acked-by: Maxime Ripard <mripard@kernel.org> > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > drivers/gpu/drm/drm_connector.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c > index f4fa5c59717d..d9d7fef26275 100644 > --- a/drivers/gpu/drm/drm_connector.c > +++ b/drivers/gpu/drm/drm_connector.c > @@ -140,6 +140,13 @@ static void drm_connector_get_cmdline_mode(struct drm_connector *connector) > connector->force = mode->force; > } > > + if (mode->panel_orientation != DRM_MODE_PANEL_ORIENTATION_UNKNOWN) { > + DRM_INFO("setting connector %s panel_orientation to %d\n", > + connector->name, mode->panel_orientation); Since this overrides the standard behavior should this deserve a debug that is a bit more clear that we are forcing the mode with the cmdline? > + drm_connector_set_panel_orientation(connector, > + mode->panel_orientation); > + } > + > DRM_DEBUG_KMS("cmdline mode for connector %s %s %dx%d@%dHz%s%s%s\n", > connector->name, mode->name, > mode->xres, mode->yres, > -- > 2.23.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Hi, On 03-01-2020 20:38, Rodrigo Vivi wrote: > On Mon, Dec 16, 2019 at 12:51:58PM +0100, Hans de Goede wrote: >> If the new video=... panel_orientation option is set for a connector, honor >> it and setup a matching "panel orientation" property on the connector. >> >> BugLink: https://gitlab.freedesktop.org/plymouth/plymouth/merge_requests/83 >> Acked-by: Maxime Ripard <mripard@kernel.org> >> Signed-off-by: Hans de Goede <hdegoede@redhat.com> >> --- >> drivers/gpu/drm/drm_connector.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c >> index f4fa5c59717d..d9d7fef26275 100644 >> --- a/drivers/gpu/drm/drm_connector.c >> +++ b/drivers/gpu/drm/drm_connector.c >> @@ -140,6 +140,13 @@ static void drm_connector_get_cmdline_mode(struct drm_connector *connector) >> connector->force = mode->force; >> } >> >> + if (mode->panel_orientation != DRM_MODE_PANEL_ORIENTATION_UNKNOWN) { >> + DRM_INFO("setting connector %s panel_orientation to %d\n", >> + connector->name, mode->panel_orientation); > > Since this overrides the standard behavior should this deserve a debug that > is a bit more clear that we are forcing the mode with the cmdline? Sure, I will send a v2 of this series with this fixed up right away. Regards, Hans > >> + drm_connector_set_panel_orientation(connector, >> + mode->panel_orientation); >> + } >> + >> DRM_DEBUG_KMS("cmdline mode for connector %s %s %dx%d@%dHz%s%s%s\n", >> connector->name, mode->name, >> mode->xres, mode->yres, >> -- >> 2.23.0 >> >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx >
diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c index f4fa5c59717d..d9d7fef26275 100644 --- a/drivers/gpu/drm/drm_connector.c +++ b/drivers/gpu/drm/drm_connector.c @@ -140,6 +140,13 @@ static void drm_connector_get_cmdline_mode(struct drm_connector *connector) connector->force = mode->force; } + if (mode->panel_orientation != DRM_MODE_PANEL_ORIENTATION_UNKNOWN) { + DRM_INFO("setting connector %s panel_orientation to %d\n", + connector->name, mode->panel_orientation); + drm_connector_set_panel_orientation(connector, + mode->panel_orientation); + } + DRM_DEBUG_KMS("cmdline mode for connector %s %s %dx%d@%dHz%s%s%s\n", connector->name, mode->name, mode->xres, mode->yres,