[RESEND,1/2] dt-bindings: phy: drop #clock-cells from rockchip, px30-dsi-dphy
diff mbox series

Message ID 20191216122448.27867-1-heiko@sntech.de
State New
Headers show
Series
  • [RESEND,1/2] dt-bindings: phy: drop #clock-cells from rockchip, px30-dsi-dphy
Related show

Commit Message

Heiko Stuebner Dec. 16, 2019, 12:24 p.m. UTC
From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>

Further review of the dsi components for the px30 revealed that the
phy shouldn't expose the pll as clock but instead handle settings
via phy parameters.

As the phy binding is new and not used anywhere yet, just drop them
so they don't get used.

Fixes: 3817c7961179 ("dt-bindings: phy: add yaml binding for rockchip,px30-dsi-dphy")
Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
---
Hi Kishon,

maybe suitable as a fix for 5.5-rc?

Thanks
Heiko

 .../devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml      | 5 -----
 1 file changed, 5 deletions(-)

Comments

Rob Herring Dec. 16, 2019, 5:56 p.m. UTC | #1
On Mon, 16 Dec 2019 13:24:47 +0100, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> 
> Further review of the dsi components for the px30 revealed that the
> phy shouldn't expose the pll as clock but instead handle settings
> via phy parameters.
> 
> As the phy binding is new and not used anywhere yet, just drop them
> so they don't get used.
> 
> Fixes: 3817c7961179 ("dt-bindings: phy: add yaml binding for rockchip,px30-dsi-dphy")
> Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> ---
> Hi Kishon,
> 
> maybe suitable as a fix for 5.5-rc?
> 
> Thanks
> Heiko
> 
>  .../devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml      | 5 -----
>  1 file changed, 5 deletions(-)
> 

Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.

If a tag was not added on purpose, please state why and what changed.
Heiko Stuebner Dec. 16, 2019, 6:01 p.m. UTC | #2
Hi Rob,

Am Montag, 16. Dezember 2019, 18:56:15 CET schrieb Rob Herring:
> On Mon, 16 Dec 2019 13:24:47 +0100, Heiko Stuebner wrote:
> > From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> > 
> > Further review of the dsi components for the px30 revealed that the
> > phy shouldn't expose the pll as clock but instead handle settings
> > via phy parameters.
> > 
> > As the phy binding is new and not used anywhere yet, just drop them
> > so they don't get used.
> > 
> > Fixes: 3817c7961179 ("dt-bindings: phy: add yaml binding for rockchip,px30-dsi-dphy")
> > Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> > ---
> > Hi Kishon,
> > 
> > maybe suitable as a fix for 5.5-rc?
> > 
> > Thanks
> > Heiko
> > 
> >  .../devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml      | 5 -----
> >  1 file changed, 5 deletions(-)
> > 
> 
> Please add Acked-by/Reviewed-by tags when posting new versions. However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.
> 
> If a tag was not added on purpose, please state why and what changed.

sorry about that. The original response somehow did not thread correctly
in my mail client, probably some fault on my side, so I've only found your
mail just now by digging hard.

@Kishon, the original mail already got an

Acked-by: Rob Herring <robh@kernel.org>
Kishon Vijay Abraham I Dec. 20, 2019, 11:21 a.m. UTC | #3
On 16/12/19 11:31 pm, Heiko Stübner wrote:
> Hi Rob,
> 
> Am Montag, 16. Dezember 2019, 18:56:15 CET schrieb Rob Herring:
>> On Mon, 16 Dec 2019 13:24:47 +0100, Heiko Stuebner wrote:
>>> From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
>>>
>>> Further review of the dsi components for the px30 revealed that the
>>> phy shouldn't expose the pll as clock but instead handle settings
>>> via phy parameters.
>>>
>>> As the phy binding is new and not used anywhere yet, just drop them
>>> so they don't get used.
>>>
>>> Fixes: 3817c7961179 ("dt-bindings: phy: add yaml binding for rockchip,px30-dsi-dphy")
>>> Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
>>> ---
>>> Hi Kishon,
>>>
>>> maybe suitable as a fix for 5.5-rc?
>>>
>>> Thanks
>>> Heiko
>>>
>>>  .../devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml      | 5 -----
>>>  1 file changed, 5 deletions(-)
>>>
>>
>> Please add Acked-by/Reviewed-by tags when posting new versions. However,
>> there's no need to repost patches *only* to add the tags. The upstream
>> maintainer will do that for acks received on the version they apply.
>>
>> If a tag was not added on purpose, please state why and what changed.
> 
> sorry about that. The original response somehow did not thread correctly
> in my mail client, probably some fault on my side, so I've only found your
> mail just now by digging hard.
> 
> @Kishon, the original mail already got an
> 
> Acked-by: Rob Herring <robh@kernel.org>

merged now, Thanks!

-Kishon
Heiko Stuebner Dec. 20, 2019, 11:37 a.m. UTC | #4
Hi Kishon,

Am Freitag, 20. Dezember 2019, 12:21:28 CET schrieb Kishon Vijay Abraham I:
> 
> On 16/12/19 11:31 pm, Heiko Stübner wrote:
> > Hi Rob,
> > 
> > Am Montag, 16. Dezember 2019, 18:56:15 CET schrieb Rob Herring:
> >> On Mon, 16 Dec 2019 13:24:47 +0100, Heiko Stuebner wrote:
> >>> From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> >>>
> >>> Further review of the dsi components for the px30 revealed that the
> >>> phy shouldn't expose the pll as clock but instead handle settings
> >>> via phy parameters.
> >>>
> >>> As the phy binding is new and not used anywhere yet, just drop them
> >>> so they don't get used.
> >>>
> >>> Fixes: 3817c7961179 ("dt-bindings: phy: add yaml binding for rockchip,px30-dsi-dphy")
> >>> Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> >>> ---
> >>> Hi Kishon,
> >>>
> >>> maybe suitable as a fix for 5.5-rc?
> >>>
> >>> Thanks
> >>> Heiko
> >>>
> >>>  .../devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml      | 5 -----
> >>>  1 file changed, 5 deletions(-)
> >>>
> >>
> >> Please add Acked-by/Reviewed-by tags when posting new versions. However,
> >> there's no need to repost patches *only* to add the tags. The upstream
> >> maintainer will do that for acks received on the version they apply.
> >>
> >> If a tag was not added on purpose, please state why and what changed.
> > 
> > sorry about that. The original response somehow did not thread correctly
> > in my mail client, probably some fault on my side, so I've only found your
> > mail just now by digging hard.
> > 
> > @Kishon, the original mail already got an
> > 
> > Acked-by: Rob Herring <robh@kernel.org>
> 
> merged now, Thanks!

thanks ... just to make sure, did you also see the driver changes in patch2?
As I don't see them in either of your branches :-)

Thanks
Heiko
Kishon Vijay Abraham I Dec. 20, 2019, 11:52 a.m. UTC | #5
Hi,

On 20/12/19 5:07 pm, Heiko Stübner wrote:
> Hi Kishon,
> 
> Am Freitag, 20. Dezember 2019, 12:21:28 CET schrieb Kishon Vijay Abraham I:
>>
>> On 16/12/19 11:31 pm, Heiko Stübner wrote:
>>> Hi Rob,
>>>
>>> Am Montag, 16. Dezember 2019, 18:56:15 CET schrieb Rob Herring:
>>>> On Mon, 16 Dec 2019 13:24:47 +0100, Heiko Stuebner wrote:
>>>>> From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
>>>>>
>>>>> Further review of the dsi components for the px30 revealed that the
>>>>> phy shouldn't expose the pll as clock but instead handle settings
>>>>> via phy parameters.
>>>>>
>>>>> As the phy binding is new and not used anywhere yet, just drop them
>>>>> so they don't get used.
>>>>>
>>>>> Fixes: 3817c7961179 ("dt-bindings: phy: add yaml binding for rockchip,px30-dsi-dphy")
>>>>> Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
>>>>> ---
>>>>> Hi Kishon,
>>>>>
>>>>> maybe suitable as a fix for 5.5-rc?
>>>>>
>>>>> Thanks
>>>>> Heiko
>>>>>
>>>>>  .../devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml      | 5 -----
>>>>>  1 file changed, 5 deletions(-)
>>>>>
>>>>
>>>> Please add Acked-by/Reviewed-by tags when posting new versions. However,
>>>> there's no need to repost patches *only* to add the tags. The upstream
>>>> maintainer will do that for acks received on the version they apply.
>>>>
>>>> If a tag was not added on purpose, please state why and what changed.
>>>
>>> sorry about that. The original response somehow did not thread correctly
>>> in my mail client, probably some fault on my side, so I've only found your
>>> mail just now by digging hard.
>>>
>>> @Kishon, the original mail already got an
>>>
>>> Acked-by: Rob Herring <robh@kernel.org>
>>
>> merged now, Thanks!
> 
> thanks ... just to make sure, did you also see the driver changes in patch2?
> As I don't see them in either of your branches :-)

For some reason, patch 2 of the "RESEND" series is not in my inbox.
However looking at your original series, looks like this is a candidate
for 5.6. I'll take patch 2 from your original series.

Thanks
Kishon

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml b/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml
index bb0da87bcd84..476c56a1dc8c 100644
--- a/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml
+++ b/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml
@@ -13,9 +13,6 @@  properties:
   "#phy-cells":
     const: 0
 
-  "#clock-cells":
-    const: 0
-
   compatible:
     enum:
       - rockchip,px30-dsi-dphy
@@ -49,7 +46,6 @@  properties:
 
 required:
   - "#phy-cells"
-  - "#clock-cells"
   - compatible
   - reg
   - clocks
@@ -66,7 +62,6 @@  examples:
         reg = <0x0 0xff2e0000 0x0 0x10000>;
         clocks = <&pmucru 13>, <&cru 12>;
         clock-names = "ref", "pclk";
-        #clock-cells = <0>;
         resets = <&cru 12>;
         reset-names = "apb";
         #phy-cells = <0>;