[btrfs-progs,2/4] tests: mkfs: 017: Use check_dm_target_support helper
diff mbox series

Message ID 20191217203155.24206-3-marcos.souza.org@gmail.com
State New
Headers show
Series
  • tests: do not fail if dm-thin is missing
Related show

Commit Message

Marcos Paulo de Souza Dec. 17, 2019, 8:31 p.m. UTC
From: Marcos Paulo de Souza <mpdesouza@suse.com>

If dm-thin or dm-linear are not supported, let's skip the test altogether
instead of throwing an error.

Issue: #192

Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>
---
 .../017-small-backing-size-thin-provision-device/test.sh         | 1 +
 1 file changed, 1 insertion(+)

Comments

Qu Wenruo Dec. 18, 2019, 12:26 a.m. UTC | #1
On 2019/12/18 上午4:31, Marcos Paulo de Souza wrote:
> From: Marcos Paulo de Souza <mpdesouza@suse.com>
> 
> If dm-thin or dm-linear are not supported, let's skip the test altogether
> instead of throwing an error.
> 
> Issue: #192
> 
> Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>

Reviewed-by: Qu Wenruo <wqu@suse.com>

Thanks,
Qu

> ---
>  .../017-small-backing-size-thin-provision-device/test.sh         | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/mkfs-tests/017-small-backing-size-thin-provision-device/test.sh b/tests/mkfs-tests/017-small-backing-size-thin-provision-device/test.sh
> index 32640ce5..91851945 100755
> --- a/tests/mkfs-tests/017-small-backing-size-thin-provision-device/test.sh
> +++ b/tests/mkfs-tests/017-small-backing-size-thin-provision-device/test.sh
> @@ -7,6 +7,7 @@ source "$TEST_TOP/common"
>  check_prereq mkfs.btrfs
>  check_global_prereq udevadm
>  check_global_prereq dmsetup
> +check_dm_target_support linear thin
>  
>  setup_root_helper
>  prepare_test_dev
>

Patch
diff mbox series

diff --git a/tests/mkfs-tests/017-small-backing-size-thin-provision-device/test.sh b/tests/mkfs-tests/017-small-backing-size-thin-provision-device/test.sh
index 32640ce5..91851945 100755
--- a/tests/mkfs-tests/017-small-backing-size-thin-provision-device/test.sh
+++ b/tests/mkfs-tests/017-small-backing-size-thin-provision-device/test.sh
@@ -7,6 +7,7 @@  source "$TEST_TOP/common"
 check_prereq mkfs.btrfs
 check_global_prereq udevadm
 check_global_prereq dmsetup
+check_dm_target_support linear thin
 
 setup_root_helper
 prepare_test_dev