| Message ID | 20191218074427.96184-2-svens@linux.ibm.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | [1/3] selftests/ftrace: fix glob selftest | expand |
On Wed, 18 Dec 2019 08:44:25 +0100 Sven Schnelle <svens@linux.ibm.com> wrote: > test.d/ftrace/func-filter-glob.tc is failing on s390 because it has > ARCH_INLINE_SPIN_LOCK and friends set to 'y'. So the usual > __raw_spin_lock symbol isn't in the ftrace function list. Change > '*aw*lock' to '*time*ns' which would hopefully match some of the > ktime_() functions on all platforms. This requires an ack from Masami, and this patch can go through Shuah's tree. Also, any patches for the Linux kernel should be Cc'd to lkml. The linux-trace-devel is mostly for tracing tools, not kernel patches. -- Steve > > Signed-off-by: Sven Schnelle <svens@linux.ibm.com> > --- > .../testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc > index 27a54a17da65..a5d61667cd56 100644 > --- a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc > +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc > @@ -30,7 +30,7 @@ ftrace_filter_check '*schedule*' '^.*schedule.*$' > ftrace_filter_check 'schedule*' '^schedule.*$' > > # filter by *mid*end > -ftrace_filter_check '*aw*lock' '.*aw.*lock$' > +ftrace_filter_check '*time*ns' '.*time.*ns$' > > # filter by start*mid* > ftrace_filter_check 'mutex*try*' '^mutex.*try.*'
On Thu, 19 Dec 2019 18:31:51 -0500 Steven Rostedt <rostedt@goodmis.org> wrote: > On Wed, 18 Dec 2019 08:44:25 +0100 > Sven Schnelle <svens@linux.ibm.com> wrote: > > > test.d/ftrace/func-filter-glob.tc is failing on s390 because it has > > ARCH_INLINE_SPIN_LOCK and friends set to 'y'. So the usual > > __raw_spin_lock symbol isn't in the ftrace function list. Change > > '*aw*lock' to '*time*ns' which would hopefully match some of the > > ktime_() functions on all platforms. > > This requires an ack from Masami, and this patch can go through Shuah's > tree. > > Also, any patches for the Linux kernel should be Cc'd to lkml. The > linux-trace-devel is mostly for tracing tools, not kernel patches. Thanks Steve to CC to me. BTW, are there any reason why we use different symbols for different glob patterns? I mean we can use 'schedul*', '*chedule' and '*sch*ule' as test glob patterns. Thank you, > > -- Steve > > > > > Signed-off-by: Sven Schnelle <svens@linux.ibm.com> > > --- > > .../testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc > > index 27a54a17da65..a5d61667cd56 100644 > > --- a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc > > +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc > > @@ -30,7 +30,7 @@ ftrace_filter_check '*schedule*' '^.*schedule.*$' > > ftrace_filter_check 'schedule*' '^schedule.*$' > > > > # filter by *mid*end > > -ftrace_filter_check '*aw*lock' '.*aw.*lock$' > > +ftrace_filter_check '*time*ns' '.*time.*ns$' > > > > # filter by start*mid* > > ftrace_filter_check 'mutex*try*' '^mutex.*try.*' >
Hi, On Fri, Dec 20, 2019 at 04:27:46PM +0900, Masami Hiramatsu wrote: > On Thu, 19 Dec 2019 18:31:51 -0500 > Steven Rostedt <rostedt@goodmis.org> wrote: > > > On Wed, 18 Dec 2019 08:44:25 +0100 > > Sven Schnelle <svens@linux.ibm.com> wrote: > > > > > test.d/ftrace/func-filter-glob.tc is failing on s390 because it has > > > ARCH_INLINE_SPIN_LOCK and friends set to 'y'. So the usual > > > __raw_spin_lock symbol isn't in the ftrace function list. Change > > > '*aw*lock' to '*time*ns' which would hopefully match some of the > > > ktime_() functions on all platforms. > > > > This requires an ack from Masami, and this patch can go through Shuah's > > tree. > > > > Also, any patches for the Linux kernel should be Cc'd to lkml. The > > linux-trace-devel is mostly for tracing tools, not kernel patches. > > Thanks Steve to CC to me. > BTW, are there any reason why we use different symbols for different > glob patterns? > I mean we can use 'schedul*', '*chedule' and '*sch*ule' as test > glob patterns. Don't know, but i don't see a reason why we should have different patterns. If there's an agreement that we prefer a common pattern i can update the patch and resend. Regards Sven
On Fri, 20 Dec 2019 08:32:40 +0100 Sven Schnelle <svens@linux.ibm.com> wrote: > > Thanks Steve to CC to me. > > BTW, are there any reason why we use different symbols for different > > glob patterns? > > I mean we can use 'schedul*', '*chedule' and '*sch*ule' as test > > glob patterns. > > Don't know, but i don't see a reason why we should have different patterns. If > there's an agreement that we prefer a common pattern i can update the patch and > resend. I think I liked trying other functions just to make sure that it was working to add a bit of churn to the mix (for the unlikely case that schedule has some fluke case). We could just switch it all to use schedule, or we can change "aw" to "spin". -- Steve
diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc index 27a54a17da65..a5d61667cd56 100644 --- a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc @@ -30,7 +30,7 @@ ftrace_filter_check '*schedule*' '^.*schedule.*$' ftrace_filter_check 'schedule*' '^schedule.*$' # filter by *mid*end -ftrace_filter_check '*aw*lock' '.*aw.*lock$' +ftrace_filter_check '*time*ns' '.*time.*ns$' # filter by start*mid* ftrace_filter_check 'mutex*try*' '^mutex.*try.*'
test.d/ftrace/func-filter-glob.tc is failing on s390 because it has ARCH_INLINE_SPIN_LOCK and friends set to 'y'. So the usual __raw_spin_lock symbol isn't in the ftrace function list. Change '*aw*lock' to '*time*ns' which would hopefully match some of the ktime_() functions on all platforms. Signed-off-by: Sven Schnelle <svens@linux.ibm.com> --- .../testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)