[v2] git-gui: allow closing console window with Escape
diff mbox series

Message ID 20191218195809.7658-1-me@yadavpratyush.com
State New
Headers show
Series
  • [v2] git-gui: allow closing console window with Escape
Related show

Commit Message

Pratyush Yadav Dec. 18, 2019, 7:58 p.m. UTC
This gives users a quick shortcut to close the window. But since the
window can also show commands in progress, closing the window on Escape
can give the perception that the command has been cancelled even though
it hasn't been. So, only enable this binding when the command is done.

Signed-off-by: Pratyush Yadav <me@yadavpratyush.com>
---
Changes in v2:
- Only allow closing the window on Escape when the command is done.

 lib/console.tcl | 2 ++
 1 file changed, 2 insertions(+)

--
2.24.1

Comments

Pratyush Yadav Dec. 22, 2019, 9:59 a.m. UTC | #1
On 19/12/19 01:28AM, Pratyush Yadav wrote:
> This gives users a quick shortcut to close the window. But since the
> window can also show commands in progress, closing the window on Escape
> can give the perception that the command has been cancelled even though
> it hasn't been. So, only enable this binding when the command is done.
> 
> Signed-off-by: Pratyush Yadav <me@yadavpratyush.com>

Merged to 'master'.

Patch
diff mbox series

diff --git a/lib/console.tcl b/lib/console.tcl
index 1f3248f..bb6b9c8 100644
--- a/lib/console.tcl
+++ b/lib/console.tcl
@@ -203,6 +203,8 @@  method done {ok} {
 			focus $w.ok
 		}
 	}
+
+	bind $w <Key-Escape> "destroy $w;break"
 }

 method _sb_set {sb orient first last} {