[v4l-utils] keymap.h needs sys/types.h and argp.h
diff mbox series

Message ID 20191218211016.18796-1-ps.report@gmx.net
State New
Headers show
Series
  • [v4l-utils] keymap.h needs sys/types.h and argp.h
Related show

Commit Message

Peter Seiderer Dec. 18, 2019, 9:10 p.m. UTC
Fixes:

  keymap.h:23:2: error: unknown type name ‘u_int32_t’
  keymap.h:36:1: error: unknown type name ‘error_t’

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 utils/common/keymap.c      | 2 ++
 utils/ir-ctl/bpf_encoder.c | 1 +
 2 files changed, 3 insertions(+)

Comments

Sean Young Dec. 31, 2019, 9:08 a.m. UTC | #1
Hi Peter,

On Wed, Dec 18, 2019 at 10:10:16PM +0100, Peter Seiderer wrote:
> Fixes:
> 
>   keymap.h:23:2: error: unknown type name ‘u_int32_t’
>   keymap.h:36:1: error: unknown type name ‘error_t’

It would be nice to know where/how you are encountering these errors. ir-ctl
with these changes are building fine on Fedora and Debian (unstable).

Thanks,
Sean

> 
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
>  utils/common/keymap.c      | 2 ++
>  utils/ir-ctl/bpf_encoder.c | 1 +
>  2 files changed, 3 insertions(+)
> 
> diff --git a/utils/common/keymap.c b/utils/common/keymap.c
> index f574f24f..d06deb59 100644
> --- a/utils/common/keymap.c
> +++ b/utils/common/keymap.c
> @@ -9,6 +9,8 @@
>  #include <string.h>
>  #include <limits.h>
>  #include <stdbool.h>
> +#include <sys/types.h>
> +#include <argp.h>
>  
>  #include "keymap.h"
>  #include "toml.h"
> diff --git a/utils/ir-ctl/bpf_encoder.c b/utils/ir-ctl/bpf_encoder.c
> index 82d12cc0..e3e705e7 100644
> --- a/utils/ir-ctl/bpf_encoder.c
> +++ b/utils/ir-ctl/bpf_encoder.c
> @@ -5,6 +5,7 @@
>  #include <errno.h>
>  #include <string.h>
>  #include <sys/types.h>
> +#include <argp.h>
>  
>  #include "keymap.h"
>  
> -- 
> 2.24.0
>
Peter Seiderer Jan. 6, 2020, 9:29 a.m. UTC | #2
Hello Sean,

On Tue, 31 Dec 2019 09:08:48 +0000, Sean Young <sean@mess.org> wrote:

> Hi Peter,
> 
> On Wed, Dec 18, 2019 at 10:10:16PM +0100, Peter Seiderer wrote:
> > Fixes:
> > 
> >   keymap.h:23:2: error: unknown type name ‘u_int32_t’
> >   keymap.h:36:1: error: unknown type name ‘error_t’  
> 
> It would be nice to know where/how you are encountering these errors. ir-ctl
> with these changes are building fine on Fedora and Debian (unstable).

Sorry for the (very) brief commit log, the problem occurs with buildroot/musl-toolchain
e.g. from the buildroot autobuild system [1], [2]...

Regards,
Peter

[1] http://autobuild.buildroot.net/results/f6d14fa0827d5eba9e020f238399396a121a45d6
[2] http://autobuild.buildroot.net/results/f6d14fa0827d5eba9e020f238399396a121a45d6/build-end.log

> 
> Thanks,
> Sean
> 
> > 
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> > ---
> >  utils/common/keymap.c      | 2 ++
> >  utils/ir-ctl/bpf_encoder.c | 1 +
> >  2 files changed, 3 insertions(+)
> > 
> > diff --git a/utils/common/keymap.c b/utils/common/keymap.c
> > index f574f24f..d06deb59 100644
> > --- a/utils/common/keymap.c
> > +++ b/utils/common/keymap.c
> > @@ -9,6 +9,8 @@
> >  #include <string.h>
> >  #include <limits.h>
> >  #include <stdbool.h>
> > +#include <sys/types.h>
> > +#include <argp.h>
> >  
> >  #include "keymap.h"
> >  #include "toml.h"
> > diff --git a/utils/ir-ctl/bpf_encoder.c b/utils/ir-ctl/bpf_encoder.c
> > index 82d12cc0..e3e705e7 100644
> > --- a/utils/ir-ctl/bpf_encoder.c
> > +++ b/utils/ir-ctl/bpf_encoder.c
> > @@ -5,6 +5,7 @@
> >  #include <errno.h>
> >  #include <string.h>
> >  #include <sys/types.h>
> > +#include <argp.h>
> >  
> >  #include "keymap.h"
> >  
> > -- 
> > 2.24.0
> >

Patch
diff mbox series

diff --git a/utils/common/keymap.c b/utils/common/keymap.c
index f574f24f..d06deb59 100644
--- a/utils/common/keymap.c
+++ b/utils/common/keymap.c
@@ -9,6 +9,8 @@ 
 #include <string.h>
 #include <limits.h>
 #include <stdbool.h>
+#include <sys/types.h>
+#include <argp.h>
 
 #include "keymap.h"
 #include "toml.h"
diff --git a/utils/ir-ctl/bpf_encoder.c b/utils/ir-ctl/bpf_encoder.c
index 82d12cc0..e3e705e7 100644
--- a/utils/ir-ctl/bpf_encoder.c
+++ b/utils/ir-ctl/bpf_encoder.c
@@ -5,6 +5,7 @@ 
 #include <errno.h>
 #include <string.h>
 #include <sys/types.h>
+#include <argp.h>
 
 #include "keymap.h"