diff mbox series

[3/3] fsr: remove shadow variable in fsr_setup_attr_fork

Message ID fd893f4d-f436-b568-8dbf-5522c291952a@sandeen.net (mailing list archive)
State New, archived
Headers show
Series xfsprogs: trivial sparse tidyups | expand

Commit Message

Eric Sandeen Dec. 18, 2019, 10:56 p.m. UTC 
From: Eric Sandeen <sandeen@redhat.com>

There's no need for the extra inner-scope ret variable in this
function, so remove it.  The shadow was harmless though.

Fixes: f31b5e12 ("libfrog: refactor open-coded bulkstat calls")
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

Comments

Darrick J. Wong Dec. 18, 2019, 11:08 p.m. UTC | #1 
On Wed, Dec 18, 2019 at 04:56:20PM -0600, Eric Sandeen wrote:
> From: Eric Sandeen <sandeen@redhat.com>
> 
> There's no need for the extra inner-scope ret variable in this
> function, so remove it.  The shadow was harmless though.
> 
> Fixes: f31b5e12 ("libfrog: refactor open-coded bulkstat calls")
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
> 
> diff --git a/fsr/xfs_fsr.c b/fsr/xfs_fsr.c
> index 77a10a1d..32282126 100644
> --- a/fsr/xfs_fsr.c
> +++ b/fsr/xfs_fsr.c
> @@ -988,7 +988,6 @@ fsr_setup_attr_fork(
>  	do {
>  		struct xfs_bulkstat	tbstat;
>  		char		name[64];
> -		int		ret;
>  
>  		/*
>  		 * bulkstat the temp inode to see what the forkoff is.  Use
>
diff mbox series

Patch

diff --git a/fsr/xfs_fsr.c b/fsr/xfs_fsr.c
index 77a10a1d..32282126 100644
--- a/fsr/xfs_fsr.c
+++ b/fsr/xfs_fsr.c
@@ -988,7 +988,6 @@  fsr_setup_attr_fork(
 	do {
 		struct xfs_bulkstat	tbstat;
 		char		name[64];
-		int		ret;
 
 		/*
 		 * bulkstat the temp inode to see what the forkoff is.  Use