[CI,v4] drm/i915/dp: Disable Port sync mode correctly on teardown
diff mbox series

Message ID 20191220010403.29111-1-manasi.d.navare@intel.com
State New
Headers show
Series
  • [CI,v4] drm/i915/dp: Disable Port sync mode correctly on teardown
Related show

Commit Message

Manasi Navare Dec. 20, 2019, 1:04 a.m. UTC
While clearing the Ports ync mode enable and master select bits
we need to clear the register completely instead of using disable masks

v3:
* Remove reg variable (Matt)
v2:
* Just write 0 to the reg (Ville)
* Rebase

Bugzilla: https://gitlab.freedesktop.org/drm/intel/issues/5
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Fixes: 51528afe7c5e ("drm/i915/display/icl: Disable transcoder port sync as part of crtc_disable() sequence")
Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
---
 drivers/gpu/drm/i915/display/intel_ddi.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Comments

Manasi Navare Dec. 20, 2019, 5:16 a.m. UTC | #1
This is a gem test failing on BYT for which Port Sync feature in this feature is not even enabled.
Looks like a false positive.

Manasi

-----Original Message-----
From: Patchwork [mailto:patchwork@emeril.freedesktop.org] 
Sent: Thursday, December 19, 2019 7:13 PM
To: Navare, Manasi D <manasi.d.navare@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.BAT: failure for drm/i915/dp: Disable Port sync mode correctly on teardown

== Series Details ==

Series: drm/i915/dp: Disable Port sync mode correctly on teardown
URL   : https://patchwork.freedesktop.org/series/71196/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7612 -> Patchwork_15853 ====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_15853 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_15853, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15853/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_15853:

### IGT changes ###

#### Possible regressions ####

  * igt@gem_tiled_blits@basic:
    - fi-byt-j1900:       [PASS][1] -> [FAIL][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7612/fi-byt-j1900/igt@gem_tiled_blits@basic.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15853/fi-byt-j1900/igt@gem_tiled_blits@basic.html

  
Known issues
------------

  Here are the changes found in Patchwork_15853 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [PASS][3] -> [FAIL][4] ([fdo#111096] / [i915#323])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7612/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15853/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  
#### Warnings ####

  * igt@i915_module_load@reload:
    - fi-icl-u2:          [DMESG-WARN][5] ([i915#109] / [i915#289]) -> [DMESG-WARN][6] ([i915#289])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7612/fi-icl-u2/igt@i915_module_load@reload.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15853/fi-icl-u2/igt@i915_module_load@reload.html

  * igt@i915_selftest@live_blt:
    - fi-hsw-4770:        [DMESG-FAIL][7] ([i915#725]) -> [DMESG-FAIL][8] ([i915#770])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7612/fi-hsw-4770/igt@i915_selftest@live_blt.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15853/fi-hsw-4770/igt@i915_selftest@live_blt.html

  * igt@i915_selftest@live_gem_contexts:
    - fi-hsw-peppy:       [INCOMPLETE][9] ([i915#694]) -> [DMESG-FAIL][10] ([i915#722])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7612/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15853/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
    - fi-byt-n2820:       [INCOMPLETE][11] ([i915#45]) -> [DMESG-FAIL][12] ([i915#722])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7612/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15853/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html

  * igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
    - fi-kbl-x1275:       [DMESG-WARN][13] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][14] ([i915#62] / [i915#92]) +5 similar issues
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7612/fi-kbl-x1275/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15853/fi-kbl-x1275/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html

  * igt@kms_flip@basic-flip-vs-modeset:
    - fi-kbl-x1275:       [DMESG-WARN][15] ([i915#62] / [i915#92]) -> [DMESG-WARN][16] ([i915#62] / [i915#92] / [i915#95]) +6 similar issues
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7612/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15853/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
  [fdo#111593]: https://bugs.freedesktop.org/show_bug.cgi?id=111593
  [i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109
  [i915#289]: https://gitlab.freedesktop.org/drm/intel/issues/289
  [i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
  [i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45
  [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
  [i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
  [i915#722]: https://gitlab.freedesktop.org/drm/intel/issues/722
  [i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
  [i915#770]: https://gitlab.freedesktop.org/drm/intel/issues/770
  [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
  [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95


Participating hosts (49 -> 35)
------------------------------

  Additional (1): fi-bwr-2160 
  Missing    (15): fi-ilk-m540 fi-bdw-samus fi-kbl-7560u fi-bsw-n3050 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-snb-2520m fi-ctg-p8600 fi-skl-lmem fi-blb-e6850 fi-tgl-y fi-byt-clapper fi-skl-6600u fi-snb-2600 


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_7612 -> Patchwork_15853

  CI-20190529: 20190529
  CI_DRM_7612: d8427504d16e1aa87eab972f812c02478522bd70 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5351: e7fdcef72d1d6b3bb9f3003bbc37571959e6e8bb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_15853: 12cd5bf14b8b4b80988e3d4ccc36d5d3dfafccef @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

12cd5bf14b8b drm/i915/dp: Disable Port sync mode correctly on teardown

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15853/index.html
Jani Nikula Dec. 20, 2019, 6:23 a.m. UTC | #2
On Fri, 20 Dec 2019, "Navare, Manasi D" <manasi.d.navare@intel.com> wrote:
> This is a gem test failing on BYT for which Port Sync feature in this feature is not even enabled.
> Looks like a false positive.

Maybe, but not passing BAT means full IGT does not get run. Not having
full IGT results means no pushing. It's non-negotiable. (The BAT result
mails might emphasize that a bit better.)

My gut feeling is we've been getting excessive amounts of BAT failures
lately, especially on the GEM side of things.

I hit retest.


BR,
Jani.



>
> Manasi
>
> -----Original Message-----
> From: Patchwork [mailto:patchwork@emeril.freedesktop.org] 
> Sent: Thursday, December 19, 2019 7:13 PM
> To: Navare, Manasi D <manasi.d.navare@intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Subject: ✗ Fi.CI.BAT: failure for drm/i915/dp: Disable Port sync mode correctly on teardown
>
> == Series Details ==
>
> Series: drm/i915/dp: Disable Port sync mode correctly on teardown
> URL   : https://patchwork.freedesktop.org/series/71196/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_7612 -> Patchwork_15853 ====================================================
>
> Summary
> -------
>
>   **FAILURE**
>
>   Serious unknown changes coming with Patchwork_15853 absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_15853, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
>
>   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15853/index.html
>
> Possible new issues
> -------------------
>
>   Here are the unknown changes that may have been introduced in Patchwork_15853:
>
> ### IGT changes ###
>
> #### Possible regressions ####
>
>   * igt@gem_tiled_blits@basic:
>     - fi-byt-j1900:       [PASS][1] -> [FAIL][2]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7612/fi-byt-j1900/igt@gem_tiled_blits@basic.html
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15853/fi-byt-j1900/igt@gem_tiled_blits@basic.html
>
>   
> Known issues
> ------------
>
>   Here are the changes found in Patchwork_15853 that come from known issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
>   * igt@kms_chamelium@hdmi-hpd-fast:
>     - fi-kbl-7500u:       [PASS][3] -> [FAIL][4] ([fdo#111096] / [i915#323])
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7612/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15853/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
>
>   
> #### Warnings ####
>
>   * igt@i915_module_load@reload:
>     - fi-icl-u2:          [DMESG-WARN][5] ([i915#109] / [i915#289]) -> [DMESG-WARN][6] ([i915#289])
>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7612/fi-icl-u2/igt@i915_module_load@reload.html
>    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15853/fi-icl-u2/igt@i915_module_load@reload.html
>
>   * igt@i915_selftest@live_blt:
>     - fi-hsw-4770:        [DMESG-FAIL][7] ([i915#725]) -> [DMESG-FAIL][8] ([i915#770])
>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7612/fi-hsw-4770/igt@i915_selftest@live_blt.html
>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15853/fi-hsw-4770/igt@i915_selftest@live_blt.html
>
>   * igt@i915_selftest@live_gem_contexts:
>     - fi-hsw-peppy:       [INCOMPLETE][9] ([i915#694]) -> [DMESG-FAIL][10] ([i915#722])
>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7612/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
>    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15853/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
>     - fi-byt-n2820:       [INCOMPLETE][11] ([i915#45]) -> [DMESG-FAIL][12] ([i915#722])
>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7612/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
>    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15853/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
>
>   * igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
>     - fi-kbl-x1275:       [DMESG-WARN][13] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][14] ([i915#62] / [i915#92]) +5 similar issues
>    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7612/fi-kbl-x1275/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html
>    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15853/fi-kbl-x1275/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html
>
>   * igt@kms_flip@basic-flip-vs-modeset:
>     - fi-kbl-x1275:       [DMESG-WARN][15] ([i915#62] / [i915#92]) -> [DMESG-WARN][16] ([i915#62] / [i915#92] / [i915#95]) +6 similar issues
>    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7612/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html
>    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15853/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html
>
>   
>   {name}: This element is suppressed. This means it is ignored when computing
>           the status of the difference (SUCCESS, WARNING, or FAILURE).
>
>   [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
>   [fdo#111593]: https://bugs.freedesktop.org/show_bug.cgi?id=111593
>   [i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109
>   [i915#289]: https://gitlab.freedesktop.org/drm/intel/issues/289
>   [i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
>   [i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45
>   [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
>   [i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
>   [i915#722]: https://gitlab.freedesktop.org/drm/intel/issues/722
>   [i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
>   [i915#770]: https://gitlab.freedesktop.org/drm/intel/issues/770
>   [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
>   [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
>
>
> Participating hosts (49 -> 35)
> ------------------------------
>
>   Additional (1): fi-bwr-2160 
>   Missing    (15): fi-ilk-m540 fi-bdw-samus fi-kbl-7560u fi-bsw-n3050 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-snb-2520m fi-ctg-p8600 fi-skl-lmem fi-blb-e6850 fi-tgl-y fi-byt-clapper fi-skl-6600u fi-snb-2600 
>
>
> Build changes
> -------------
>
>   * CI: CI-20190529 -> None
>   * Linux: CI_DRM_7612 -> Patchwork_15853
>
>   CI-20190529: 20190529
>   CI_DRM_7612: d8427504d16e1aa87eab972f812c02478522bd70 @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_5351: e7fdcef72d1d6b3bb9f3003bbc37571959e6e8bb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>   Patchwork_15853: 12cd5bf14b8b4b80988e3d4ccc36d5d3dfafccef @ git://anongit.freedesktop.org/gfx-ci/linux
>
>
> == Linux commits ==
>
> 12cd5bf14b8b drm/i915/dp: Disable Port sync mode correctly on teardown
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15853/index.html
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Manasi Navare Dec. 20, 2019, 6:46 a.m. UTC | #3
Thanks a lot Jani for restest of this patch.
I am also waiting on full IGT results on this other series:
https://patchwork.freedesktop.org/series/71193/
which has this patch included as well, I just sent it separately because this one has a r-b and if I get CI success then I can merge this by itself.

Manasi

-----Original Message-----
From: Jani Nikula [mailto:jani.nikula@linux.intel.com] 
Sent: Thursday, December 19, 2019 10:23 PM
To: Navare, Manasi D <manasi.d.navare@intel.com>; intel-gfx@lists.freedesktop.org
Cc: Sarvela, Tomi P <tomi.p.sarvela@intel.com>; Saarinen, Jani <jani.saarinen@intel.com>; Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dp: Disable Port sync mode correctly on teardown

On Fri, 20 Dec 2019, "Navare, Manasi D" <manasi.d.navare@intel.com> wrote:
> This is a gem test failing on BYT for which Port Sync feature in this feature is not even enabled.
> Looks like a false positive.

Maybe, but not passing BAT means full IGT does not get run. Not having full IGT results means no pushing. It's non-negotiable. (The BAT result mails might emphasize that a bit better.)

My gut feeling is we've been getting excessive amounts of BAT failures lately, especially on the GEM side of things.

I hit retest.


BR,
Jani.



>
> Manasi
>
> -----Original Message-----
> From: Patchwork [mailto:patchwork@emeril.freedesktop.org]
> Sent: Thursday, December 19, 2019 7:13 PM
> To: Navare, Manasi D <manasi.d.navare@intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Subject: ✗ Fi.CI.BAT: failure for drm/i915/dp: Disable Port sync mode 
> correctly on teardown
>
> == Series Details ==
>
> Series: drm/i915/dp: Disable Port sync mode correctly on teardown
> URL   : https://patchwork.freedesktop.org/series/71196/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_7612 -> Patchwork_15853 
> ====================================================
>
> Summary
> -------
>
>   **FAILURE**
>
>   Serious unknown changes coming with Patchwork_15853 absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_15853, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
>
>   External URL: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15853/index.html
>
> Possible new issues
> -------------------
>
>   Here are the unknown changes that may have been introduced in Patchwork_15853:
>
> ### IGT changes ###
>
> #### Possible regressions ####
>
>   * igt@gem_tiled_blits@basic:
>     - fi-byt-j1900:       [PASS][1] -> [FAIL][2]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7612/fi-byt-j1900/igt@gem_tiled_blits@basic.html
>    [2]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15853/fi-byt-j1900/
> igt@gem_tiled_blits@basic.html
>
>   
> Known issues
> ------------
>
>   Here are the changes found in Patchwork_15853 that come from known issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
>   * igt@kms_chamelium@hdmi-hpd-fast:
>     - fi-kbl-7500u:       [PASS][3] -> [FAIL][4] ([fdo#111096] / [i915#323])
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7612/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
>    [4]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15853/fi-kbl-7500u/
> igt@kms_chamelium@hdmi-hpd-fast.html
>
>   
> #### Warnings ####
>
>   * igt@i915_module_load@reload:
>     - fi-icl-u2:          [DMESG-WARN][5] ([i915#109] / [i915#289]) -> [DMESG-WARN][6] ([i915#289])
>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7612/fi-icl-u2/igt@i915_module_load@reload.html
>    [6]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15853/fi-icl-u2/igt
> @i915_module_load@reload.html
>
>   * igt@i915_selftest@live_blt:
>     - fi-hsw-4770:        [DMESG-FAIL][7] ([i915#725]) -> [DMESG-FAIL][8] ([i915#770])
>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7612/fi-hsw-4770/igt@i915_selftest@live_blt.html
>    [8]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15853/fi-hsw-4770/i
> gt@i915_selftest@live_blt.html
>
>   * igt@i915_selftest@live_gem_contexts:
>     - fi-hsw-peppy:       [INCOMPLETE][9] ([i915#694]) -> [DMESG-FAIL][10] ([i915#722])
>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7612/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
>    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15853/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
>     - fi-byt-n2820:       [INCOMPLETE][11] ([i915#45]) -> [DMESG-FAIL][12] ([i915#722])
>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7612/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
>    [12]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15853/fi-byt-n2820/
> igt@i915_selftest@live_gem_contexts.html
>
>   * igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
>     - fi-kbl-x1275:       [DMESG-WARN][13] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][14] ([i915#62] / [i915#92]) +5 similar issues
>    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7612/fi-kbl-x1275/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html
>    [14]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15853/fi-kbl-x1275/
> igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html
>
>   * igt@kms_flip@basic-flip-vs-modeset:
>     - fi-kbl-x1275:       [DMESG-WARN][15] ([i915#62] / [i915#92]) -> [DMESG-WARN][16] ([i915#62] / [i915#92] / [i915#95]) +6 similar issues
>    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7612/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html
>    [16]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15853/fi-kbl-x1275/
> igt@kms_flip@basic-flip-vs-modeset.html
>
>   
>   {name}: This element is suppressed. This means it is ignored when computing
>           the status of the difference (SUCCESS, WARNING, or FAILURE).
>
>   [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
>   [fdo#111593]: https://bugs.freedesktop.org/show_bug.cgi?id=111593
>   [i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109
>   [i915#289]: https://gitlab.freedesktop.org/drm/intel/issues/289
>   [i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
>   [i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45
>   [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
>   [i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
>   [i915#722]: https://gitlab.freedesktop.org/drm/intel/issues/722
>   [i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
>   [i915#770]: https://gitlab.freedesktop.org/drm/intel/issues/770
>   [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
>   [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
>
>
> Participating hosts (49 -> 35)
> ------------------------------
>
>   Additional (1): fi-bwr-2160 
>   Missing    (15): fi-ilk-m540 fi-bdw-samus fi-kbl-7560u fi-bsw-n3050 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-snb-2520m fi-ctg-p8600 fi-skl-lmem fi-blb-e6850 fi-tgl-y fi-byt-clapper fi-skl-6600u fi-snb-2600 
>
>
> Build changes
> -------------
>
>   * CI: CI-20190529 -> None
>   * Linux: CI_DRM_7612 -> Patchwork_15853
>
>   CI-20190529: 20190529
>   CI_DRM_7612: d8427504d16e1aa87eab972f812c02478522bd70 @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_5351: e7fdcef72d1d6b3bb9f3003bbc37571959e6e8bb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>   Patchwork_15853: 12cd5bf14b8b4b80988e3d4ccc36d5d3dfafccef @ 
> git://anongit.freedesktop.org/gfx-ci/linux
>
>
> == Linux commits ==
>
> 12cd5bf14b8b drm/i915/dp: Disable Port sync mode correctly on teardown
>
> == Logs ==
>
> For more details see: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15853/index.html
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Jani Nikula, Intel Open Source Graphics Center

Patch
diff mbox series

diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index c9ba7d7f3787..e535a3b85575 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -3860,8 +3860,6 @@  static void icl_disable_transcoder_port_sync(const struct intel_crtc_state *old_
 {
 	struct intel_crtc *crtc = to_intel_crtc(old_crtc_state->uapi.crtc);
 	struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
-	i915_reg_t reg;
-	u32 trans_ddi_func_ctl2_val;
 
 	if (old_crtc_state->master_transcoder == INVALID_TRANSCODER)
 		return;
@@ -3869,10 +3867,7 @@  static void icl_disable_transcoder_port_sync(const struct intel_crtc_state *old_
 	DRM_DEBUG_KMS("Disabling Transcoder Port Sync on Slave Transcoder %s\n",
 		      transcoder_name(old_crtc_state->cpu_transcoder));
 
-	reg = TRANS_DDI_FUNC_CTL2(old_crtc_state->cpu_transcoder);
-	trans_ddi_func_ctl2_val = ~(PORT_SYNC_MODE_ENABLE |
-				    PORT_SYNC_MODE_MASTER_SELECT_MASK);
-	I915_WRITE(reg, trans_ddi_func_ctl2_val);
+	I915_WRITE(TRANS_DDI_FUNC_CTL2(old_crtc_state->cpu_transcoder), 0);
 }
 
 static void intel_ddi_post_disable(struct intel_encoder *encoder,