drn/i915: Break up long i915_buddy_free_list() with a cond_resched()
diff mbox series

Message ID 20191221144917.1040662-1-chris@chris-wilson.co.uk
State New
Headers show
Series
  • drn/i915: Break up long i915_buddy_free_list() with a cond_resched()
Related show

Commit Message

Chris Wilson Dec. 21, 2019, 2:49 p.m. UTC
In the selftests, we may feed very long lists of blocks to be freed on
culmination of the tests. This coupled with kasan and other
malloc-tracing can make the kmem_cache_free() operation time consuming,
and doing many of time trigger soft lockup warnings. Break the list up
with a cond_resched().

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Auld <matthew.auld@intel.com>
---
 drivers/gpu/drm/i915/i915_buddy.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Matthew Auld Dec. 30, 2019, 12:01 p.m. UTC | #1
On Sat, 21 Dec 2019 at 14:49, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> In the selftests, we may feed very long lists of blocks to be freed on
> culmination of the tests. This coupled with kasan and other
> malloc-tracing can make the kmem_cache_free() operation time consuming,
> and doing many of time trigger soft lockup warnings. Break the list up
> with a cond_resched().
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>

Patch
diff mbox series

diff --git a/drivers/gpu/drm/i915/i915_buddy.c b/drivers/gpu/drm/i915/i915_buddy.c
index e9d4200ce3bc..66883af64ca1 100644
--- a/drivers/gpu/drm/i915/i915_buddy.c
+++ b/drivers/gpu/drm/i915/i915_buddy.c
@@ -262,8 +262,10 @@  void i915_buddy_free_list(struct i915_buddy_mm *mm, struct list_head *objects)
 {
 	struct i915_buddy_block *block, *on;
 
-	list_for_each_entry_safe(block, on, objects, link)
+	list_for_each_entry_safe(block, on, objects, link) {
 		i915_buddy_free(mm, block);
+		cond_resched();
+	}
 	INIT_LIST_HEAD(objects);
 }