[PATCHv2] phy: cpcap-usb: Fix flakey host idling and enumerating of devices
diff mbox series

Message ID 20191222180019.55417-1-tony@atomide.com
State New
Headers show
Series
  • [PATCHv2] phy: cpcap-usb: Fix flakey host idling and enumerating of devices
Related show

Commit Message

Tony Lindgren Dec. 22, 2019, 6 p.m. UTC
We must let the USB host idle things properly before we switch to debug
UART mode. Otherwise the USB host may never idle after disconnecting
devices, and that causes the next enumeration to be flakey.

Cc: Jacopo Mondi <jacopo@jmondi.org>
Cc: Marcel Partap <mpartap@gmx.net>
Cc: Merlijn Wajer <merlijn@wizzup.org>
Cc: Michael Scott <hashcode0f@gmail.com>
Cc: NeKit <nekit1000@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Sebastian Reichel <sre@kernel.org>
Fixes: 6d6ce40f63af ("phy: cpcap-usb: Add CPCAP PMIC USB support")
Signed-off-by: Tony Lindgren <tony@atomide.com>
---

Kishon, looks like the v1 patch sent in August got lost somewhere.
Here's a resend update against your fixes branch.


 drivers/phy/motorola/phy-cpcap-usb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Pavel Machek Dec. 26, 2019, 10:45 a.m. UTC | #1
On Sun 2019-12-22 10:00:19, Tony Lindgren wrote:
> We must let the USB host idle things properly before we switch to debug
> UART mode. Otherwise the USB host may never idle after disconnecting
> devices, and that causes the next enumeration to be flakey.
> 
> Cc: Jacopo Mondi <jacopo@jmondi.org>
> Cc: Marcel Partap <mpartap@gmx.net>
> Cc: Merlijn Wajer <merlijn@wizzup.org>
> Cc: Michael Scott <hashcode0f@gmail.com>
> Cc: NeKit <nekit1000@gmail.com>

Acked-by: Pavel Machek <pavel@ucw.cz>

> Cc: Sebastian Reichel <sre@kernel.org>
> Fixes: 6d6ce40f63af ("phy: cpcap-usb: Add CPCAP PMIC USB support")
> Signed-off-by: Tony Lindgren <tony@atomide.com>

But it does not apply on top of 5.5-rc3 AFAICT.

Best regards,
									Pavel

Patch
diff mbox series

diff --git a/drivers/phy/motorola/phy-cpcap-usb.c b/drivers/phy/motorola/phy-cpcap-usb.c
--- a/drivers/phy/motorola/phy-cpcap-usb.c
+++ b/drivers/phy/motorola/phy-cpcap-usb.c
@@ -283,13 +283,13 @@  static void cpcap_usb_detect(struct work_struct *work)
 		return;
 	}
 
+	cpcap_usb_try_musb_mailbox(ddata, MUSB_VBUS_OFF);
+
 	/* Default to debug UART mode */
 	error = cpcap_usb_set_uart_mode(ddata);
 	if (error)
 		goto out_err;
 
-	cpcap_usb_try_musb_mailbox(ddata, MUSB_VBUS_OFF);
-
 	dev_dbg(ddata->dev, "set UART mode\n");
 
 	return;