| Message ID | 20191224010020.15969-2-rjones@gateworks.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: dts: imx: Add GW59xx Gateworks specials | expand |
On Mon, Dec 23, 2019 at 05:00:16PM -0800, Robert Jones wrote: > Add the compatible enum entries for Gateworks Ventana boards. > > Signed-off-by: Robert Jones <rjones@gateworks.com> > --- > Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > index f79683a..a02e980 100644 > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > @@ -126,6 +126,7 @@ properties: > - toradex,apalis_imx6q-ixora # Apalis iMX6 Module on Ixora > - toradex,apalis_imx6q-ixora-v1.1 # Apalis iMX6 Module on Ixora V1.1 > - variscite,dt6customboard > + - gw,ventana # Gateworks i.MX6DL or i.MX6Q Ventana Keep entries sorted. > - const: fsl,imx6q > > - description: i.MX6QP based Boards > @@ -152,6 +153,7 @@ properties: > - ysoft,imx6dl-yapp4-draco # i.MX6 DualLite Y Soft IOTA Draco board > - ysoft,imx6dl-yapp4-hydra # i.MX6 DualLite Y Soft IOTA Hydra board > - ysoft,imx6dl-yapp4-ursa # i.MX6 Solo Y Soft IOTA Ursa board > + - gw,ventana # Gateworks i.MX6DL or i.MX6Q Ventana > - const: fsl,imx6dl > > - description: i.MX6SL based Boards > -- > 2.9.2 >
Hi Rob, On Thu, Dec 26, 2019 at 8:26 PM Rob Herring <robh@kernel.org> wrote: > > On Mon, Dec 23, 2019 at 05:00:16PM -0800, Robert Jones wrote: > > Add the compatible enum entries for Gateworks Ventana boards. > > > > Signed-off-by: Robert Jones <rjones@gateworks.com> > > --- > > Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > > index f79683a..a02e980 100644 > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > @@ -126,6 +126,7 @@ properties: > > - toradex,apalis_imx6q-ixora # Apalis iMX6 Module on Ixora > > - toradex,apalis_imx6q-ixora-v1.1 # Apalis iMX6 Module on Ixora V1.1 > > - variscite,dt6customboard > > + - gw,ventana # Gateworks i.MX6DL or i.MX6Q Ventana > > Keep entries sorted. Just for clarification: shouldn't the entries inside fsl.yaml match the dtb file names? In case of the i.MX6Q based gateworks board, this should be: gw,imx6q-gw51xx gw,imx6q-gw52xx gw,imx6q-gw53xx gw,imx6q-gw5400-a gw,imx6q-gw54xx gw,imx6q-gw551x gw,imx6q-gw552x gw,imx6q-gw553x gw,imx6q-gw560x gw,imx6q-gw5903 gw,imx6q-gw5904 Please advise.
On Thu, Dec 26, 2019 at 5:34 PM Fabio Estevam <festevam@gmail.com> wrote: > > Hi Rob, > > On Thu, Dec 26, 2019 at 8:26 PM Rob Herring <robh@kernel.org> wrote: > > > > On Mon, Dec 23, 2019 at 05:00:16PM -0800, Robert Jones wrote: > > > Add the compatible enum entries for Gateworks Ventana boards. > > > > > > Signed-off-by: Robert Jones <rjones@gateworks.com> > > > --- > > > Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > > > index f79683a..a02e980 100644 > > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > > @@ -126,6 +126,7 @@ properties: > > > - toradex,apalis_imx6q-ixora # Apalis iMX6 Module on Ixora > > > - toradex,apalis_imx6q-ixora-v1.1 # Apalis iMX6 Module on Ixora V1.1 > > > - variscite,dt6customboard > > > + - gw,ventana # Gateworks i.MX6DL or i.MX6Q Ventana > > > > Keep entries sorted. > > Just for clarification: shouldn't the entries inside fsl.yaml match > the dtb file names? No. They should match top-level compatibles. However, I'd expect a 1:1 relationship of dtbs to top-level compatible entries. > In case of the i.MX6Q based gateworks board, this should be: > > gw,imx6q-gw51xx > gw,imx6q-gw52xx > gw,imx6q-gw53xx > gw,imx6q-gw5400-a > gw,imx6q-gw54xx > gw,imx6q-gw551x > gw,imx6q-gw552x > gw,imx6q-gw553x > gw,imx6q-gw560x > gw,imx6q-gw5903 > gw,imx6q-gw5904 > > Please advise. Yes, if this is 11 different boards, then yes, I'd expect 11 permutations for the schema. Rob
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml index f79683a..a02e980 100644 --- a/Documentation/devicetree/bindings/arm/fsl.yaml +++ b/Documentation/devicetree/bindings/arm/fsl.yaml @@ -126,6 +126,7 @@ properties: - toradex,apalis_imx6q-ixora # Apalis iMX6 Module on Ixora - toradex,apalis_imx6q-ixora-v1.1 # Apalis iMX6 Module on Ixora V1.1 - variscite,dt6customboard + - gw,ventana # Gateworks i.MX6DL or i.MX6Q Ventana - const: fsl,imx6q - description: i.MX6QP based Boards @@ -152,6 +153,7 @@ properties: - ysoft,imx6dl-yapp4-draco # i.MX6 DualLite Y Soft IOTA Draco board - ysoft,imx6dl-yapp4-hydra # i.MX6 DualLite Y Soft IOTA Hydra board - ysoft,imx6dl-yapp4-ursa # i.MX6 Solo Y Soft IOTA Ursa board + - gw,ventana # Gateworks i.MX6DL or i.MX6Q Ventana - const: fsl,imx6dl - description: i.MX6SL based Boards
Add the compatible enum entries for Gateworks Ventana boards. Signed-off-by: Robert Jones <rjones@gateworks.com> --- Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++ 1 file changed, 2 insertions(+)