From patchwork Fri Dec 27 16:32:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: George Dunlap X-Patchwork-Id: 11311285 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5FFF06C1 for ; Fri, 27 Dec 2019 16:34:03 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C4E3208C4 for ; Fri, 27 Dec 2019 16:34:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="QpjYN044" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C4E3208C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iksXs-0001fp-2B; Fri, 27 Dec 2019 16:33:00 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iksXr-0001fD-2x for xen-devel@lists.xenproject.org; Fri, 27 Dec 2019 16:32:59 +0000 X-Inumbo-ID: 7dcd4904-28c6-11ea-9c5f-12813bfff9fa Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7dcd4904-28c6-11ea-9c5f-12813bfff9fa; Fri, 27 Dec 2019 16:32:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1577464356; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=zRCo77vsL05BNptKc1EvuDzCOM4b+dw/e38bcwxbjAI=; b=QpjYN044Ol4Ttoz9GQYBsinFwqUprUp7fhQBocw/ARzq7exdTBFaAHec iJerbNbnPedsAzBnSHoZhRmdrDzI7CyPtc948A0XmvBDGLXpm/saejjGL 76Fo5WmWtHVZvEmy/4hlkGsiBHQp9jlsXtpHwihVZPHGnq07FT5vjLk4v k=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=george.dunlap@citrix.com; spf=Pass smtp.mailfrom=George.Dunlap@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of george.dunlap@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="George.Dunlap@citrix.com"; x-sender="george.dunlap@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa6.hc3370-68.iphmx.com: domain of George.Dunlap@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="George.Dunlap@citrix.com"; x-sender="George.Dunlap@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="George.Dunlap@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: ccg/gV9gATPlXFZbeXyS8kjxGBRHwg8XxtUXYaw2vzDqIscRUUn32Z2mqfRh8a0wgLhAuTEnCH zUN7eRhxHXajS96KfD3kZHVnBh4wK1EocK3XQo9OjdEGQHqJZQmrzptJl/3TEc9X19CW3DoMH6 nw+q59xLa9RR5MK19mSbOCj6Y/iBtRe00gTVAfMUFFgwj1FOEfZeEyTc1zS1sCwtGJOxXOtduG MlI5m4opL+YMSdtcrPPZwu0AQjw7Lsf5Kpp7s4dmQvVCVNHR973h/9MBkzH61Whm+RZxAJ4hPn 3Rc= X-SBRS: 2.7 X-MesageID: 10626145 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.69,363,1571716800"; d="scan'208";a="10626145" From: George Dunlap To: Date: Fri, 27 Dec 2019 16:32:24 +0000 Message-ID: <20191227163224.4113837-9-george.dunlap@citrix.com> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191227163224.4113837-1-george.dunlap@citrix.com> References: <20191227163224.4113837-1-george.dunlap@citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [PATCH 9/9] DO NOT APPLY: Sketch constructors, DomainCreateNew X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Nick Rosbrook , George Dunlap Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" This is a sketch of functionality suitable for creating a basic domain, with a disk and a vif. DomainConfig, DeviceDisk, and DeviceNic types are all created using constructor functions, which initialize them with libxl's defaults. DomainCreateNew takes the config and calls without any updates. Obviously some of these will need to be changed it we switch to passing references to .toC() rather than passing back by value. The main purpose of this is to allow testing of creating a hard-coded domain. Signed-off-by: George Dunlap --- CC: Nick Rosbrook --- tools/golang/xenlight/xenlight.go | 66 +++++++++++++++++++++++++++++++ 1 file changed, 66 insertions(+) diff --git a/tools/golang/xenlight/xenlight.go b/tools/golang/xenlight/xenlight.go index f70a4c6d96..91da79bc68 100644 --- a/tools/golang/xenlight/xenlight.go +++ b/tools/golang/xenlight/xenlight.go @@ -1079,3 +1079,69 @@ func (Ctx *Context) PrimaryConsoleGetTty(domid uint32) (path string, err error) path = C.GoString(cpath) return } + +func NewDomainConfig(t DomainType) (*DomainConfig, error) { + var cconfig C.libxl_domain_config + + C.libxl_domain_config_init(&cconfig) + C.libxl_domain_build_info_init_type(&cconfig.b_info, C.libxl_domain_type(t)) + + gconfig := &DomainConfig{} + err := gconfig.fromC(&cconfig) + if err != nil { + return nil, err + } + + return gconfig, nil +} + +func NewDeviceDisk() (*DeviceDisk, error) { + var ctype C.libxl_device_disk + + C.libxl_device_disk_init(&ctype) + + gtype := &DeviceDisk{} + err := gtype.fromC(&ctype) + + if err != nil { + return nil, err + } + + return gtype, nil +} + +func NewDeviceNic() (*DeviceNic, error) { + var ctype C.libxl_device_nic + + C.libxl_device_nic_init(&ctype) + + gtype := &DeviceNic{} + err := gtype.fromC(&ctype) + + if err != nil { + return nil, err + } + + return gtype, nil +} + +// int libxl_domain_create_new(libxl_ctx *ctx, libxl_domain_config *d_config, +// uint32_t *domid, +// const libxl_asyncop_how *ao_how, +// const libxl_asyncprogress_how *aop_console_how) +func (Ctx *Context) DomainCreateNew(config *DomainConfig) (Domid, error) { + var cdomid C.uint32_t + cconfig, err := config.toC() + if err != nil { + return Domid(0), fmt.Errorf("Converting domain config to C: %v", err) + } + defer C.libxl_domain_config_dispose(&cconfig) + + fmt.Errorf("Calling libxl_domain_create_new") + ret := C.libxl_domain_create_new(Ctx.ctx, &cconfig, &cdomid, nil, nil) + if ret != 0 { + return Domid(0), Error(ret) + } + + return Domid(cdomid), nil +}