cpuidle: arm: Enable compile testing for some of drivers
diff mbox series

Message ID 20191229180912.17100-2-krzk@kernel.org
State Not Applicable
Headers show
Series
  • cpuidle: arm: Enable compile testing for some of drivers
Related show

Commit Message

Krzysztof Kozlowski Dec. 29, 2019, 6:09 p.m. UTC
Some of cpuidle drivers for ARMv7 can be compile tested on this
architecture because they do not depend on mach-specific bits.  Enable
compile testing for big.LITTLE, Kirkwood, Zynq, AT91, Exynos and mvebu
cpuidle drivers.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/cpuidle/Kconfig.arm | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Rafael J. Wysocki Jan. 13, 2020, 11:51 a.m. UTC | #1
On Sunday, December 29, 2019 7:09:12 PM CET Krzysztof Kozlowski wrote:
> Some of cpuidle drivers for ARMv7 can be compile tested on this
> architecture because they do not depend on mach-specific bits.  Enable
> compile testing for big.LITTLE, Kirkwood, Zynq, AT91, Exynos and mvebu
> cpuidle drivers.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  drivers/cpuidle/Kconfig.arm | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/cpuidle/Kconfig.arm b/drivers/cpuidle/Kconfig.arm
> index a224d33dda7f..62272ecfa771 100644
> --- a/drivers/cpuidle/Kconfig.arm
> +++ b/drivers/cpuidle/Kconfig.arm
> @@ -25,7 +25,7 @@ config ARM_PSCI_CPUIDLE
>  
>  config ARM_BIG_LITTLE_CPUIDLE
>  	bool "Support for ARM big.LITTLE processors"
> -	depends on ARCH_VEXPRESS_TC2_PM || ARCH_EXYNOS
> +	depends on ARCH_VEXPRESS_TC2_PM || ARCH_EXYNOS || COMPILE_TEST
>  	depends on MCPM && !ARM64
>  	select ARM_CPU_SUSPEND
>  	select CPU_IDLE_MULTIPLE_DRIVERS
> @@ -51,13 +51,13 @@ config ARM_HIGHBANK_CPUIDLE
>  
>  config ARM_KIRKWOOD_CPUIDLE
>  	bool "CPU Idle Driver for Marvell Kirkwood SoCs"
> -	depends on MACH_KIRKWOOD && !ARM64
> +	depends on (MACH_KIRKWOOD || COMPILE_TEST) && !ARM64
>  	help
>  	  This adds the CPU Idle driver for Marvell Kirkwood SoCs.
>  
>  config ARM_ZYNQ_CPUIDLE
>  	bool "CPU Idle Driver for Xilinx Zynq processors"
> -	depends on ARCH_ZYNQ && !ARM64
> +	depends on (ARCH_ZYNQ || COMPILE_TEST) && !ARM64
>  	help
>  	  Select this to enable cpuidle on Xilinx Zynq processors.
>  
> @@ -70,19 +70,19 @@ config ARM_U8500_CPUIDLE
>  config ARM_AT91_CPUIDLE
>  	bool "Cpu Idle Driver for the AT91 processors"
>  	default y
> -	depends on ARCH_AT91 && !ARM64
> +	depends on (ARCH_AT91 || COMPILE_TEST) && !ARM64
>  	help
>  	  Select this to enable cpuidle for AT91 processors.
>  
>  config ARM_EXYNOS_CPUIDLE
>  	bool "Cpu Idle Driver for the Exynos processors"
> -	depends on ARCH_EXYNOS && !ARM64
> +	depends on (ARCH_EXYNOS || COMPILE_TEST) && !ARM64
>  	select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP
>  	help
>  	  Select this to enable cpuidle for Exynos processors.
>  
>  config ARM_MVEBU_V7_CPUIDLE
>  	bool "CPU Idle Driver for mvebu v7 family processors"
> -	depends on ARCH_MVEBU && !ARM64
> +	depends on (ARCH_MVEBU || COMPILE_TEST) && !ARM64
>  	help
>  	  Select this to enable cpuidle on Armada 370, 38x and XP processors.
> 

Daniel, any concerns regarding this one?
Daniel Lezcano Jan. 13, 2020, 11:58 a.m. UTC | #2
On 13/01/2020 12:51, Rafael J. Wysocki wrote:
> On Sunday, December 29, 2019 7:09:12 PM CET Krzysztof Kozlowski wrote:
>> Some of cpuidle drivers for ARMv7 can be compile tested on this
>> architecture because they do not depend on mach-specific bits.  Enable
>> compile testing for big.LITTLE, Kirkwood, Zynq, AT91, Exynos and mvebu
>> cpuidle drivers.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>> ---
>>  drivers/cpuidle/Kconfig.arm | 12 ++++++------
>>  1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/cpuidle/Kconfig.arm b/drivers/cpuidle/Kconfig.arm
>> index a224d33dda7f..62272ecfa771 100644
>> --- a/drivers/cpuidle/Kconfig.arm
>> +++ b/drivers/cpuidle/Kconfig.arm
>> @@ -25,7 +25,7 @@ config ARM_PSCI_CPUIDLE
>>  
>>  config ARM_BIG_LITTLE_CPUIDLE
>>  	bool "Support for ARM big.LITTLE processors"
>> -	depends on ARCH_VEXPRESS_TC2_PM || ARCH_EXYNOS
>> +	depends on ARCH_VEXPRESS_TC2_PM || ARCH_EXYNOS || COMPILE_TEST
>>  	depends on MCPM && !ARM64
>>  	select ARM_CPU_SUSPEND
>>  	select CPU_IDLE_MULTIPLE_DRIVERS
>> @@ -51,13 +51,13 @@ config ARM_HIGHBANK_CPUIDLE
>>  
>>  config ARM_KIRKWOOD_CPUIDLE
>>  	bool "CPU Idle Driver for Marvell Kirkwood SoCs"
>> -	depends on MACH_KIRKWOOD && !ARM64
>> +	depends on (MACH_KIRKWOOD || COMPILE_TEST) && !ARM64
>>  	help
>>  	  This adds the CPU Idle driver for Marvell Kirkwood SoCs.
>>  
>>  config ARM_ZYNQ_CPUIDLE
>>  	bool "CPU Idle Driver for Xilinx Zynq processors"
>> -	depends on ARCH_ZYNQ && !ARM64
>> +	depends on (ARCH_ZYNQ || COMPILE_TEST) && !ARM64
>>  	help
>>  	  Select this to enable cpuidle on Xilinx Zynq processors.
>>  
>> @@ -70,19 +70,19 @@ config ARM_U8500_CPUIDLE
>>  config ARM_AT91_CPUIDLE
>>  	bool "Cpu Idle Driver for the AT91 processors"
>>  	default y
>> -	depends on ARCH_AT91 && !ARM64
>> +	depends on (ARCH_AT91 || COMPILE_TEST) && !ARM64
>>  	help
>>  	  Select this to enable cpuidle for AT91 processors.
>>  
>>  config ARM_EXYNOS_CPUIDLE
>>  	bool "Cpu Idle Driver for the Exynos processors"
>> -	depends on ARCH_EXYNOS && !ARM64
>> +	depends on (ARCH_EXYNOS || COMPILE_TEST) && !ARM64
>>  	select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP
>>  	help
>>  	  Select this to enable cpuidle for Exynos processors.
>>  
>>  config ARM_MVEBU_V7_CPUIDLE
>>  	bool "CPU Idle Driver for mvebu v7 family processors"
>> -	depends on ARCH_MVEBU && !ARM64
>> +	depends on (ARCH_MVEBU || COMPILE_TEST) && !ARM64
>>  	help
>>  	  Select this to enable cpuidle on Armada 370, 38x and XP processors.
>>
> 
> Daniel, any concerns regarding this one?

Yes, I have a doubt about this patch. I'll double check before commenting.
Daniel Lezcano Jan. 13, 2020, 12:24 p.m. UTC | #3
On 13/01/2020 12:58, Daniel Lezcano wrote:
> On 13/01/2020 12:51, Rafael J. Wysocki wrote:
>> On Sunday, December 29, 2019 7:09:12 PM CET Krzysztof Kozlowski wrote:
>>> Some of cpuidle drivers for ARMv7 can be compile tested on this
>>> architecture because they do not depend on mach-specific bits.  Enable
>>> compile testing for big.LITTLE, Kirkwood, Zynq, AT91, Exynos and mvebu
>>> cpuidle drivers.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>>> ---

[ ... ]

>> Daniel, any concerns regarding this one?
> 
> Yes, I have a doubt about this patch. I'll double check before commenting.

Actually it is fine.

Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Rafael J. Wysocki Jan. 14, 2020, 10:51 p.m. UTC | #4
On Monday, January 13, 2020 1:24:00 PM CET Daniel Lezcano wrote:
> On 13/01/2020 12:58, Daniel Lezcano wrote:
> > On 13/01/2020 12:51, Rafael J. Wysocki wrote:
> >> On Sunday, December 29, 2019 7:09:12 PM CET Krzysztof Kozlowski wrote:
> >>> Some of cpuidle drivers for ARMv7 can be compile tested on this
> >>> architecture because they do not depend on mach-specific bits.  Enable
> >>> compile testing for big.LITTLE, Kirkwood, Zynq, AT91, Exynos and mvebu
> >>> cpuidle drivers.
> >>>
> >>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> >>> ---
> 
> [ ... ]
> 
> >> Daniel, any concerns regarding this one?
> > 
> > Yes, I have a doubt about this patch. I'll double check before commenting.
> 
> Actually it is fine.
> 
> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>

OK, patch applied.

Thanks!

Patch
diff mbox series

diff --git a/drivers/cpuidle/Kconfig.arm b/drivers/cpuidle/Kconfig.arm
index a224d33dda7f..62272ecfa771 100644
--- a/drivers/cpuidle/Kconfig.arm
+++ b/drivers/cpuidle/Kconfig.arm
@@ -25,7 +25,7 @@  config ARM_PSCI_CPUIDLE
 
 config ARM_BIG_LITTLE_CPUIDLE
 	bool "Support for ARM big.LITTLE processors"
-	depends on ARCH_VEXPRESS_TC2_PM || ARCH_EXYNOS
+	depends on ARCH_VEXPRESS_TC2_PM || ARCH_EXYNOS || COMPILE_TEST
 	depends on MCPM && !ARM64
 	select ARM_CPU_SUSPEND
 	select CPU_IDLE_MULTIPLE_DRIVERS
@@ -51,13 +51,13 @@  config ARM_HIGHBANK_CPUIDLE
 
 config ARM_KIRKWOOD_CPUIDLE
 	bool "CPU Idle Driver for Marvell Kirkwood SoCs"
-	depends on MACH_KIRKWOOD && !ARM64
+	depends on (MACH_KIRKWOOD || COMPILE_TEST) && !ARM64
 	help
 	  This adds the CPU Idle driver for Marvell Kirkwood SoCs.
 
 config ARM_ZYNQ_CPUIDLE
 	bool "CPU Idle Driver for Xilinx Zynq processors"
-	depends on ARCH_ZYNQ && !ARM64
+	depends on (ARCH_ZYNQ || COMPILE_TEST) && !ARM64
 	help
 	  Select this to enable cpuidle on Xilinx Zynq processors.
 
@@ -70,19 +70,19 @@  config ARM_U8500_CPUIDLE
 config ARM_AT91_CPUIDLE
 	bool "Cpu Idle Driver for the AT91 processors"
 	default y
-	depends on ARCH_AT91 && !ARM64
+	depends on (ARCH_AT91 || COMPILE_TEST) && !ARM64
 	help
 	  Select this to enable cpuidle for AT91 processors.
 
 config ARM_EXYNOS_CPUIDLE
 	bool "Cpu Idle Driver for the Exynos processors"
-	depends on ARCH_EXYNOS && !ARM64
+	depends on (ARCH_EXYNOS || COMPILE_TEST) && !ARM64
 	select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP
 	help
 	  Select this to enable cpuidle for Exynos processors.
 
 config ARM_MVEBU_V7_CPUIDLE
 	bool "CPU Idle Driver for mvebu v7 family processors"
-	depends on ARCH_MVEBU && !ARM64
+	depends on (ARCH_MVEBU || COMPILE_TEST) && !ARM64
 	help
 	  Select this to enable cpuidle on Armada 370, 38x and XP processors.