[3/6] xfs: remove unnecessary inode-transaction roll
diff mbox series

Message ID 157784064395.1358958.15190927920240007676.stgit@magnolia
State New
Headers show
  • xfs: online repair of inode data
Related show

Commit Message

Darrick J. Wong Jan. 1, 2020, 1:04 a.m. UTC
From: Darrick J. Wong <darrick.wong@oracle.com>

Remove the transaction roll at the end of the loop in
xfs_itruncate_extents_flags.  xfs_defer_finish takes care of rolling the
transaction as needed and reattaching the inode, which means we already
start each loop with a clean transaction.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
 fs/xfs/xfs_inode.c |    4 ----
 1 file changed, 4 deletions(-)

diff mbox series

diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
index 12eeeea4df16..c6986517074e 100644
--- a/fs/xfs/xfs_inode.c
+++ b/fs/xfs/xfs_inode.c
@@ -1565,10 +1565,6 @@  xfs_itruncate_extents_flags(
 		error = xfs_defer_finish(&tp);
 		if (error)
 			goto out;
-		error = xfs_trans_roll_inode(&tp, ip);
-		if (error)
-			goto out;
 	if (whichfork == XFS_DATA_FORK) {