iwlwifi: fix possible potential NULL pointer dereference
diff mbox series

Message ID 20200102024959.5199-1-m1s5p6688@gmail.com
State New
Delegated to: Luca Coelho
Headers show
Series
  • iwlwifi: fix possible potential NULL pointer dereference
Related show

Commit Message

m1s5p6688@gmail.com Jan. 2, 2020, 2:49 a.m. UTC
From: Qing Xu <m1s5p6688@gmail.com>

iwl_req_fw_callback() check the wrong kmemdup return value, leading 
to a NULL pointer dereference. 
Fix it by replacing the wrong value with the correct.

Signed-off-by: Qing Xu <m1s5p6688@gmail.com>
---
 drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch
diff mbox series

diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
index 4096ccf58..68c9b7157 100644
--- a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
+++ b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
@@ -1455,7 +1455,7 @@  static void iwl_req_fw_callback(const struct firmware *ucode_raw, void *context)
 				kmemdup(pieces->dbg_conf_tlv[i],
 					pieces->dbg_conf_tlv_len[i],
 					GFP_KERNEL);
-			if (!pieces->dbg_conf_tlv_len[i])
+			if (!drv->fw.dbg.conf_tlv[i])
 				goto out_free_fw;
 		}
 	}