| Message ID | 09ac47eea963e84bd3eb630897c2b77f3868b90b.1577976221.git.amit.kucheria@linaro.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Daniel Lezcano |
| Headers | show |
| Series | thermal: tsens: Handle critical interrupts | expand |
On Thu 02 Jan 06:54 PST 2020, Amit Kucheria wrote: > We already dereference the sensor and save it into a variable. Use the > variable directly to make the code easier to read. > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > --- > drivers/thermal/qcom/tsens-common.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c > index c2df30a08b9e..1cbc5a6e5b4f 100644 > --- a/drivers/thermal/qcom/tsens-common.c > +++ b/drivers/thermal/qcom/tsens-common.c > @@ -368,7 +368,7 @@ irqreturn_t tsens_irq_thread(int irq, void *data) > tsens_set_interrupt(priv, hw_id, UPPER, disable); > if (d.up_thresh > temp) { > dev_dbg(priv->dev, "[%u] %s: re-arm upper\n", > - priv->sensor[i].hw_id, __func__); > + hw_id, __func__); > tsens_set_interrupt(priv, hw_id, UPPER, enable); > } else { > trigger = true; > @@ -379,7 +379,7 @@ irqreturn_t tsens_irq_thread(int irq, void *data) > tsens_set_interrupt(priv, hw_id, LOWER, disable); > if (d.low_thresh < temp) { > dev_dbg(priv->dev, "[%u] %s: re-arm low\n", > - priv->sensor[i].hw_id, __func__); > + hw_id, __func__); > tsens_set_interrupt(priv, hw_id, LOWER, enable); > } else { > trigger = true; > @@ -392,7 +392,7 @@ irqreturn_t tsens_irq_thread(int irq, void *data) > if (trigger) { > dev_dbg(priv->dev, "[%u] %s: TZ update trigger (%d mC)\n", > hw_id, __func__, temp); > - thermal_zone_device_update(priv->sensor[i].tzd, > + thermal_zone_device_update(s->tzd, > THERMAL_EVENT_UNSPECIFIED); > } else { > dev_dbg(priv->dev, "[%u] %s: no violation: %d\n", > @@ -435,7 +435,7 @@ int tsens_set_trips(void *_sensor, int low, int high) > spin_unlock_irqrestore(&priv->ul_lock, flags); > > dev_dbg(dev, "[%u] %s: (%d:%d)->(%d:%d)\n", > - s->hw_id, __func__, d.low_thresh, d.up_thresh, cl_low, cl_high); > + hw_id, __func__, d.low_thresh, d.up_thresh, cl_low, cl_high); > > return 0; > } > -- > 2.20.1 >
diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c index c2df30a08b9e..1cbc5a6e5b4f 100644 --- a/drivers/thermal/qcom/tsens-common.c +++ b/drivers/thermal/qcom/tsens-common.c @@ -368,7 +368,7 @@ irqreturn_t tsens_irq_thread(int irq, void *data) tsens_set_interrupt(priv, hw_id, UPPER, disable); if (d.up_thresh > temp) { dev_dbg(priv->dev, "[%u] %s: re-arm upper\n", - priv->sensor[i].hw_id, __func__); + hw_id, __func__); tsens_set_interrupt(priv, hw_id, UPPER, enable); } else { trigger = true; @@ -379,7 +379,7 @@ irqreturn_t tsens_irq_thread(int irq, void *data) tsens_set_interrupt(priv, hw_id, LOWER, disable); if (d.low_thresh < temp) { dev_dbg(priv->dev, "[%u] %s: re-arm low\n", - priv->sensor[i].hw_id, __func__); + hw_id, __func__); tsens_set_interrupt(priv, hw_id, LOWER, enable); } else { trigger = true; @@ -392,7 +392,7 @@ irqreturn_t tsens_irq_thread(int irq, void *data) if (trigger) { dev_dbg(priv->dev, "[%u] %s: TZ update trigger (%d mC)\n", hw_id, __func__, temp); - thermal_zone_device_update(priv->sensor[i].tzd, + thermal_zone_device_update(s->tzd, THERMAL_EVENT_UNSPECIFIED); } else { dev_dbg(priv->dev, "[%u] %s: no violation: %d\n", @@ -435,7 +435,7 @@ int tsens_set_trips(void *_sensor, int low, int high) spin_unlock_irqrestore(&priv->ul_lock, flags); dev_dbg(dev, "[%u] %s: (%d:%d)->(%d:%d)\n", - s->hw_id, __func__, d.low_thresh, d.up_thresh, cl_low, cl_high); + hw_id, __func__, d.low_thresh, d.up_thresh, cl_low, cl_high); return 0; }
We already dereference the sensor and save it into a variable. Use the variable directly to make the code easier to read. Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> --- drivers/thermal/qcom/tsens-common.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)