diff mbox series

video: fbdev: mmp: fix platform_get_irq.cocci warnings

Message ID alpine.DEB.2.21.2001042140310.6944@hadrien (mailing list archive)
State New, archived
Headers show
Series video: fbdev: mmp: fix platform_get_irq.cocci warnings | expand

Commit Message

Julia Lawall Jan. 4, 2020, 8:43 p.m. UTC
From: kbuild test robot <lkp@intel.com>

Remove dev_err() messages after platform_get_irq*() failures.
Line 450 is redundant because platform_get_irq() already prints
an error.

Generated by: scripts/coccinelle/api/platform_get_irq.cocci

Fixes: dd90e9ae55a1 ("video: fbdev: mmp: add COMPILE_TEST support")
Signed-off-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>

---

tree:   git://anongit.freedesktop.org/drm/drm-misc for-linux-next
head:   80805774fc354f9ae7755a8e649a01dedfd0dcf8
commit: dd90e9ae55a1e7efd3ac036afe9f7ae7bb64d39d [2/16] video: fbdev: mmp: add COMPILE_TEST support
:::::: branch date: 11 hours ago
:::::: commit date: 11 hours ago

 mmp_ctrl.c |    1 -
 1 file changed, 1 deletion(-)

Comments

Daniel Vetter Jan. 7, 2020, 4:14 p.m. UTC | #1
On Sat, Jan 04, 2020 at 09:43:31PM +0100, Julia Lawall wrote:
> From: kbuild test robot <lkp@intel.com>
> 
> Remove dev_err() messages after platform_get_irq*() failures.
> Line 450 is redundant because platform_get_irq() already prints
> an error.
> 
> Generated by: scripts/coccinelle/api/platform_get_irq.cocci
> 
> Fixes: dd90e9ae55a1 ("video: fbdev: mmp: add COMPILE_TEST support")
> Signed-off-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>

Applied to drm-misc-next, thanks for your patch.
-Daniel

> 
> ---
> 
> tree:   git://anongit.freedesktop.org/drm/drm-misc for-linux-next
> head:   80805774fc354f9ae7755a8e649a01dedfd0dcf8
> commit: dd90e9ae55a1e7efd3ac036afe9f7ae7bb64d39d [2/16] video: fbdev: mmp: add COMPILE_TEST support
> :::::: branch date: 11 hours ago
> :::::: commit date: 11 hours ago
> 
>  mmp_ctrl.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> --- a/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
> +++ b/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
> @@ -447,7 +447,6 @@ static int mmphw_probe(struct platform_d
> 
>  	irq = platform_get_irq(pdev, 0);
>  	if (irq < 0) {
> -		dev_err(&pdev->dev, "%s: no IRQ defined\n", __func__);
>  		ret = -ENOENT;
>  		goto failed;
>  	}
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff mbox series

Patch

--- a/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
+++ b/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
@@ -447,7 +447,6 @@  static int mmphw_probe(struct platform_d

 	irq = platform_get_irq(pdev, 0);
 	if (irq < 0) {
-		dev_err(&pdev->dev, "%s: no IRQ defined\n", __func__);
 		ret = -ENOENT;
 		goto failed;
 	}