arm: dts: am335x-boneblack-common: fix memory size
diff mbox series

Message ID 20200106130909.7697-1-matwey@sai.msu.ru
State New
Headers show
Series
  • arm: dts: am335x-boneblack-common: fix memory size
Related show

Commit Message

Matwey V. Kornilov Jan. 6, 2020, 1:09 p.m. UTC
BeagleBone Black series is equipped with 512MB RAM
whereas only 256MB is included from am335x-bone-common.dtsi

This leads to an issue with unusual setups when devicetree
is loaded by GRUB2 directly.

Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru>
---
 arch/arm/boot/dts/am335x-boneblack-common.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Robert Nelson Jan. 6, 2020, 8:43 p.m. UTC | #1
On Mon, Jan 6, 2020 at 7:10 AM Matwey V. Kornilov <matwey@sai.msu.ru> wrote:
>
> BeagleBone Black series is equipped with 512MB RAM
> whereas only 256MB is included from am335x-bone-common.dtsi

FYI: While all versions from the factory are 512MB, some 3rd parties
offered 1GB reballing upgrades..

and the SanCloud variant which uses this file, was built with 1GB:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/am335x-sancloud-bbe.dts

>
> This leads to an issue with unusual setups when devicetree
> is loaded by GRUB2 directly.

It's a miracle, since when did GRUB2 gain this ability?

>
> Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru>
> ---
>  arch/arm/boot/dts/am335x-boneblack-common.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/am335x-boneblack-common.dtsi b/arch/arm/boot/dts/am335x-boneblack-common.dtsi
> index 7ad079861efd..91f93bc89716 100644
> --- a/arch/arm/boot/dts/am335x-boneblack-common.dtsi
> +++ b/arch/arm/boot/dts/am335x-boneblack-common.dtsi
> @@ -131,6 +131,11 @@
>  };
>
>  / {
> +       memory@80000000 {
> +               device_type = "memory";
> +               reg = <0x80000000 0x20000000>; /* 512 MB */
> +       };
> +
>         clk_mcasp0_fixed: clk_mcasp0_fixed {
>                 #clock-cells = <0>;
>                 compatible = "fixed-clock";
> --
> 2.16.4
>
Matwey V. Kornilov Jan. 6, 2020, 8:47 p.m. UTC | #2
пн, 6 янв. 2020 г. в 23:44, Robert Nelson <robertcnelson@gmail.com>:
>
> On Mon, Jan 6, 2020 at 7:10 AM Matwey V. Kornilov <matwey@sai.msu.ru> wrote:
> >
> > BeagleBone Black series is equipped with 512MB RAM
> > whereas only 256MB is included from am335x-bone-common.dtsi
>
> FYI: While all versions from the factory are 512MB, some 3rd parties
> offered 1GB reballing upgrades..
>
> and the SanCloud variant which uses this file, was built with 1GB:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/am335x-sancloud-bbe.dts
>
> >
> > This leads to an issue with unusual setups when devicetree
> > is loaded by GRUB2 directly.
>
> It's a miracle, since when did GRUB2 gain this ability?
>

I am not sure about when. But Grub 2.02 has devicetree command, which
can be used as the following:

        echo "Loading device tree blob ..."
        devicetree (tftp)/dtb/am335x-boneblack.dtb

And you know, you can run Grub itself as EFI application on to of u-boot.

> >
> > Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru>
> > ---
> >  arch/arm/boot/dts/am335x-boneblack-common.dtsi | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/am335x-boneblack-common.dtsi b/arch/arm/boot/dts/am335x-boneblack-common.dtsi
> > index 7ad079861efd..91f93bc89716 100644
> > --- a/arch/arm/boot/dts/am335x-boneblack-common.dtsi
> > +++ b/arch/arm/boot/dts/am335x-boneblack-common.dtsi
> > @@ -131,6 +131,11 @@
> >  };
> >
> >  / {
> > +       memory@80000000 {
> > +               device_type = "memory";
> > +               reg = <0x80000000 0x20000000>; /* 512 MB */
> > +       };
> > +
> >         clk_mcasp0_fixed: clk_mcasp0_fixed {
> >                 #clock-cells = <0>;
> >                 compatible = "fixed-clock";
> > --
> > 2.16.4
> >
>
>
> --
> Robert Nelson
> https://rcn-ee.com/
Tony Lindgren Jan. 6, 2020, 9:05 p.m. UTC | #3
* Matwey V. Kornilov <matwey@sai.msu.ru> [200106 20:48]:
> пн, 6 янв. 2020 г. в 23:44, Robert Nelson <robertcnelson@gmail.com>:
> >
> > On Mon, Jan 6, 2020 at 7:10 AM Matwey V. Kornilov <matwey@sai.msu.ru> wrote:
> > >
> > > BeagleBone Black series is equipped with 512MB RAM
> > > whereas only 256MB is included from am335x-bone-common.dtsi
> >
> > FYI: While all versions from the factory are 512MB, some 3rd parties
> > offered 1GB reballing upgrades..

So what's the conclusion, is it safe to bump the default size to
512MB then?

The custom ones could use their own dts file if bootloader is not
setting the RAM.

Regards,

Tony
Robert Nelson Jan. 7, 2020, 6:32 p.m. UTC | #4
On Mon, Jan 6, 2020 at 3:05 PM Tony Lindgren <tony@atomide.com> wrote:
>
> * Matwey V. Kornilov <matwey@sai.msu.ru> [200106 20:48]:
> > пн, 6 янв. 2020 г. в 23:44, Robert Nelson <robertcnelson@gmail.com>:
> > >
> > > On Mon, Jan 6, 2020 at 7:10 AM Matwey V. Kornilov <matwey@sai.msu.ru> wrote:
> > > >
> > > > BeagleBone Black series is equipped with 512MB RAM
> > > > whereas only 256MB is included from am335x-bone-common.dtsi
> > >
> > > FYI: While all versions from the factory are 512MB, some 3rd parties
> > > offered 1GB reballing upgrades..
>
> So what's the conclusion, is it safe to bump the default size to
> 512MB then?
>
> The custom ones could use their own dts file if bootloader is not
> setting the RAM.

Yeah this is safe for factory devices. Classic u-boot will update
these for modified boards.

Regards,
Tony Lindgren Jan. 13, 2020, 5:50 p.m. UTC | #5
* Robert Nelson <robertcnelson@gmail.com> [200107 18:33]:
> On Mon, Jan 6, 2020 at 3:05 PM Tony Lindgren <tony@atomide.com> wrote:
> >
> > * Matwey V. Kornilov <matwey@sai.msu.ru> [200106 20:48]:
> > > пн, 6 янв. 2020 г. в 23:44, Robert Nelson <robertcnelson@gmail.com>:
> > > >
> > > > On Mon, Jan 6, 2020 at 7:10 AM Matwey V. Kornilov <matwey@sai.msu.ru> wrote:
> > > > >
> > > > > BeagleBone Black series is equipped with 512MB RAM
> > > > > whereas only 256MB is included from am335x-bone-common.dtsi
> > > >
> > > > FYI: While all versions from the factory are 512MB, some 3rd parties
> > > > offered 1GB reballing upgrades..
> >
> > So what's the conclusion, is it safe to bump the default size to
> > 512MB then?
> >
> > The custom ones could use their own dts file if bootloader is not
> > setting the RAM.
> 
> Yeah this is safe for factory devices. Classic u-boot will update
> these for modified boards.

OK applying into fixes thanks.

Tony

Patch
diff mbox series

diff --git a/arch/arm/boot/dts/am335x-boneblack-common.dtsi b/arch/arm/boot/dts/am335x-boneblack-common.dtsi
index 7ad079861efd..91f93bc89716 100644
--- a/arch/arm/boot/dts/am335x-boneblack-common.dtsi
+++ b/arch/arm/boot/dts/am335x-boneblack-common.dtsi
@@ -131,6 +131,11 @@ 
 };
 
 / {
+	memory@80000000 {
+		device_type = "memory";
+		reg = <0x80000000 0x20000000>; /* 512 MB */
+	};
+
 	clk_mcasp0_fixed: clk_mcasp0_fixed {
 		#clock-cells = <0>;
 		compatible = "fixed-clock";