[01/15] NFS: Revalidate the file size on a fatal write error
diff mbox series

Message ID 20200106202514.785483-2-trond.myklebust@hammerspace.com
State New
Headers show
  • Various writeback related fixes
Related show

Commit Message

Trond Myklebust Jan. 6, 2020, 8:25 p.m. UTC
If we suffer a fatal error upon writing a file, which causes us to
need to revalidate the entire mapping, then we should also revalidate
the file size.

Fixes: d2ceb7e57086 ("NFS: Don't use page_file_mapping after removing the page")
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
 fs/nfs/write.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff mbox series

diff --git a/fs/nfs/write.c b/fs/nfs/write.c
index 52cab65f91cf..f5170bc839aa 100644
--- a/fs/nfs/write.c
+++ b/fs/nfs/write.c
@@ -243,7 +243,15 @@  static void nfs_grow_file(struct page *page, unsigned int offset, unsigned int c
 /* A writeback failed: mark the page as bad, and invalidate the page cache */
 static void nfs_set_pageerror(struct address_space *mapping)
+	struct inode *inode = mapping->host;
 	nfs_zap_mapping(mapping->host, mapping);
+	/* Force file size revalidation */
+	spin_lock(&inode->i_lock);
+	NFS_I(inode)->cache_validity |= NFS_INO_REVAL_FORCED |
+	spin_unlock(&inode->i_lock);
 static void nfs_mapping_set_error(struct page *page, int error)