| Message ID | 20200107001117.2009-1-festevam@gmail.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 3b49b6cde5136972dfa417112a11583a6924204a |
| Headers | show |
| Series | ARM: dts: imx6ul-14x14-evk: Pass the "broken-cd" property | expand |
On Mon, Jan 06, 2020 at 09:11:17PM -0300, Fabio Estevam wrote: > imx6ul-14x14-evk does not have a GPIO dedicated for reading the card > detect pin on the eSDHC2 micro-SD port. > > Pass the "broken-cd" property to describe the absence of the card detect > GPIO so that polling must be used. > > According to Documentation/devicetree/bindings/mmc/mmc-controller.yaml: > > broken-cd: > $ref: /schemas/types.yaml#/definitions/flag > description: > There is no card detection available; polling must be used. > > Even though no error is oberved in the kernel, the lack of the > 'broken-cd' property caused the micro-SD to not be detected in U-Boot, > so let's improve the device tree description to make it more accurate. > > Signed-off-by: Fabio Estevam <festevam@gmail.com> Applied, thanks.
diff --git a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi index 212144511b66..265bf4108cb6 100644 --- a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi +++ b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi @@ -327,6 +327,7 @@ pinctrl-names = "default"; pinctrl-0 = <&pinctrl_usdhc2>; no-1-8-v; + broken-cd; keep-power-in-suspend; wakeup-source; status = "okay";
imx6ul-14x14-evk does not have a GPIO dedicated for reading the card detect pin on the eSDHC2 micro-SD port. Pass the "broken-cd" property to describe the absence of the card detect GPIO so that polling must be used. According to Documentation/devicetree/bindings/mmc/mmc-controller.yaml: broken-cd: $ref: /schemas/types.yaml#/definitions/flag description: There is no card detection available; polling must be used. Even though no error is oberved in the kernel, the lack of the 'broken-cd' property caused the micro-SD to not be detected in U-Boot, so let's improve the device tree description to make it more accurate. Signed-off-by: Fabio Estevam <festevam@gmail.com> --- arch/arm/boot/dts/imx6ul-14x14-evk.dtsi | 1 + 1 file changed, 1 insertion(+)