| Message ID | 20200107135929.3267-2-srinivas.kandagatla@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ASoC: codecs: Add WSA881x Smart Speaker amplifier support | expand |
On Tue, Jan 7, 2020 at 7:59 AM Srinivas Kandagatla <srinivas.kandagatla@linaro.org> wrote: > > This patch adds bindings for WSA8810/WSA8815 Class-D Smart Speaker > Amplifier. This Amplifier also has a simple thermal sensor for > over temperature and speaker protection. > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > Reviewed-by: Rob Herring <robh@kernel.org> > --- > .../bindings/sound/qcom,wsa881x.yaml | 68 +++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/qcom,wsa881x.yaml This schema now is applied to the soundwire-controller.yaml example and fails: Documentation/devicetree/bindings/soundwire/soundwire-controller.example.dt.yaml: speaker@0,1: '#sound-dai-cells' is a required property Documentation/devicetree/bindings/soundwire/soundwire-controller.example.dt.yaml: speaker@0,2: '#sound-dai-cells' is a required property Please fix. Rob
On 13/01/2020 17:47, Rob Herring wrote: > On Tue, Jan 7, 2020 at 7:59 AM Srinivas Kandagatla > <srinivas.kandagatla@linaro.org> wrote: >> >> This patch adds bindings for WSA8810/WSA8815 Class-D Smart Speaker >> Amplifier. This Amplifier also has a simple thermal sensor for >> over temperature and speaker protection. >> >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> >> Reviewed-by: Rob Herring <robh@kernel.org> >> --- >> .../bindings/sound/qcom,wsa881x.yaml | 68 +++++++++++++++++++ >> 1 file changed, 68 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/sound/qcom,wsa881x.yaml > > This schema now is applied to the soundwire-controller.yaml example and fails: > > Documentation/devicetree/bindings/soundwire/soundwire-controller.example.dt.yaml: > speaker@0,1: '#sound-dai-cells' is a required property > Documentation/devicetree/bindings/soundwire/soundwire-controller.example.dt.yaml: > speaker@0,2: '#sound-dai-cells' is a required property > > Please fix. Thanks Rob, I will send a patch to fix this. --srini > > Rob >
diff --git a/Documentation/devicetree/bindings/sound/qcom,wsa881x.yaml b/Documentation/devicetree/bindings/sound/qcom,wsa881x.yaml new file mode 100644 index 000000000000..ea44d03e58ca --- /dev/null +++ b/Documentation/devicetree/bindings/sound/qcom,wsa881x.yaml @@ -0,0 +1,68 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/qcom,wsa881x.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Bindings for Qualcomm WSA8810/WSA8815 Class-D Smart Speaker Amplifier + +maintainers: + - Srinivas Kandagatla <srinivas.kandagatla@linaro.org> + +description: | + WSA8810 is a class-D smart speaker amplifier and WSA8815 + is a high-output power class-D smart speaker amplifier. + Their primary operating mode uses a SoundWire digital audio + interface. This binding is for SoundWire interface. + +properties: + compatible: + const: sdw10217201000 + + reg: + maxItems: 1 + + powerdown-gpios: + description: GPIO spec for Powerdown/Shutdown line to use + maxItems: 1 + + '#thermal-sensor-cells': + const: 0 + + '#sound-dai-cells': + const: 0 + +required: + - compatible + - reg + - powerdown-gpios + - "#thermal-sensor-cells" + - "#sound-dai-cells" + +additionalProperties: false + +examples: + - | + soundwire@c2d0000 { + #address-cells = <2>; + #size-cells = <0>; + reg = <0x0c2d0000 0x2000>; + + speaker@0,1 { + compatible = "sdw10217201000"; + reg = <0 1>; + powerdown-gpios = <&wcdpinctrl 2 0>; + #thermal-sensor-cells = <0>; + #sound-dai-cells = <0>; + }; + + speaker@0,2 { + compatible = "sdw10217201000"; + reg = <0 2>; + powerdown-gpios = <&wcdpinctrl 2 0>; + #thermal-sensor-cells = <0>; + #sound-dai-cells = <0>; + }; + }; + +...