[3/3] generic/521: add close+open operations to the fsx run
diff mbox series

Message ID 20200107165542.70108-4-josef@toxicpanda.com
State New
Headers show
Series
  • Some fsx improvements
Related show

Commit Message

Josef Bacik Jan. 7, 2020, 4:55 p.m. UTC
I was fixing a issue with i_size setting in btrfs and generic/521 was
what I used to reproduce the problem.  However I needed the close+open
operation to trigger the issue.  This is a soak test, so add this
option to increase the coverage of this test.

Signed-off-by: Josef Bacik <josef@toxicpanda.com>
---
 tests/generic/521 | 1 +
 1 file changed, 1 insertion(+)

Comments

Eryu Guan Feb. 1, 2020, 8:06 a.m. UTC | #1
On Tue, Jan 07, 2020 at 11:55:42AM -0500, Josef Bacik wrote:
> I was fixing a issue with i_size setting in btrfs and generic/521 was
> what I used to reproduce the problem.  However I needed the close+open
> operation to trigger the issue.  This is a soak test, so add this
> option to increase the coverage of this test.
> 
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
> ---
>  tests/generic/521 | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/generic/521 b/tests/generic/521
> index e8bc36e4..f0fc575e 100755
> --- a/tests/generic/521
> +++ b/tests/generic/521
> @@ -52,6 +52,7 @@ fsx_args+=(-r $min_dio_sz)
>  fsx_args+=(-t $min_dio_sz)
>  fsx_args+=(-w $min_dio_sz)
>  fsx_args+=(-Z)
> +fsx_args+=(-c 10)

This looks fine to me, but my only concern is that this floods dmesg
because every drop cache records a dmesg info, and the useful part of
dmesg may be lost. How about "-c 10000"? As the default op number is 1
million, with "-c 10000" we only have 100 dmesg entries. But I'm not
sure if that's enough for you to reproduce the bug.

Thanks,
Eryu

>  
>  run_fsx "${fsx_args[@]}" | sed -e '/^fsx.*/d'
>  
> -- 
> 2.23.0
>

Patch
diff mbox series

diff --git a/tests/generic/521 b/tests/generic/521
index e8bc36e4..f0fc575e 100755
--- a/tests/generic/521
+++ b/tests/generic/521
@@ -52,6 +52,7 @@  fsx_args+=(-r $min_dio_sz)
 fsx_args+=(-t $min_dio_sz)
 fsx_args+=(-w $min_dio_sz)
 fsx_args+=(-Z)
+fsx_args+=(-c 10)
 
 run_fsx "${fsx_args[@]}" | sed -e '/^fsx.*/d'