btrfs/202: fix golden output
diff mbox series

Message ID 20200108174510.6261-1-jth@kernel.org
State New
Headers show
Series
  • btrfs/202: fix golden output
Related show

Commit Message

Johannes Thumshirn Jan. 8, 2020, 5:45 p.m. UTC
From: Johannes Thumshirn <johannes.thumshirn@wdc.com>

The golden output of btrfs/202 contains the sequence number 201 instead of
202, fix this.

Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
---
 tests/btrfs/202.out | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Qu Wenruo Jan. 9, 2020, 12:14 a.m. UTC | #1
On 2020/1/9 上午1:45, Johannes Thumshirn wrote:
> From: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> 
> The golden output of btrfs/202 contains the sequence number 201 instead of
> 202, fix this.
> 
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> ---
>  tests/btrfs/202.out | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/btrfs/202.out b/tests/btrfs/202.out
> index 938870cf..7f33d49f 100644
> --- a/tests/btrfs/202.out
> +++ b/tests/btrfs/202.out
> @@ -1,4 +1,4 @@
> -QA output created by 201
> +QA output created by 202

This really makes people laughing.

But this also makes me wonder, do we really need the test number in
golden output?

If the diff is from `check`, we have context showing which test case we're.
If the diff is from manually diffing golden and result, then we have the
test number in the path.

The test number in golden output looks duplicated to me.

Eryu, can we just remove it?

Thanks,
Qu

>  Create subvolume 'SCRATCH_MNT/a'
>  Create subvolume 'SCRATCH_MNT/a/b'
>  Create a snapshot of 'SCRATCH_MNT/a' in 'SCRATCH_MNT/c'
>

Patch
diff mbox series

diff --git a/tests/btrfs/202.out b/tests/btrfs/202.out
index 938870cf..7f33d49f 100644
--- a/tests/btrfs/202.out
+++ b/tests/btrfs/202.out
@@ -1,4 +1,4 @@ 
-QA output created by 201
+QA output created by 202
 Create subvolume 'SCRATCH_MNT/a'
 Create subvolume 'SCRATCH_MNT/a/b'
 Create a snapshot of 'SCRATCH_MNT/a' in 'SCRATCH_MNT/c'