diff mbox series

[4/9] drm/i915/sdvo: Fix SDVO colorimetry bit defines

Message ID 20200108181242.13650-4-ville.syrjala@linux.intel.com (mailing list archive)
State New, archived
Headers show
Series [1/9] drm/i915/sdvo: Reduce the size of the on stack buffers | expand

Commit Message

Ville Syrjälä Jan. 8, 2020, 6:12 p.m. UTC 
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Fix up the SDVO colorimetry bits to match the spec.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_sdvo_regs.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Imre Deak July 9, 2020, 9:57 a.m. UTC | #1 
On Wed, Jan 08, 2020 at 08:12:37PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Fix up the SDVO colorimetry bits to match the spec.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Imre Deak <imre.deak@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_sdvo_regs.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_sdvo_regs.h b/drivers/gpu/drm/i915/display/intel_sdvo_regs.h
> index 13b9a8e257bb..74dc6c042b6e 100644
> --- a/drivers/gpu/drm/i915/display/intel_sdvo_regs.h
> +++ b/drivers/gpu/drm/i915/display/intel_sdvo_regs.h
> @@ -705,10 +705,10 @@ struct intel_sdvo_enhancements_arg {
>  #define SDVO_CMD_GET_PIXEL_REPLI	0x8c
>  #define SDVO_CMD_GET_COLORIMETRY_CAP	0x8d
>  #define SDVO_CMD_SET_COLORIMETRY	0x8e
> -  #define SDVO_COLORIMETRY_RGB256   0x0
> -  #define SDVO_COLORIMETRY_RGB220   0x1
> -  #define SDVO_COLORIMETRY_YCrCb422 0x3
> -  #define SDVO_COLORIMETRY_YCrCb444 0x4
> +  #define SDVO_COLORIMETRY_RGB256	(1 << 0)
> +  #define SDVO_COLORIMETRY_RGB220	(1 << 1)
> +  #define SDVO_COLORIMETRY_YCrCb422	(1 << 2)
> +  #define SDVO_COLORIMETRY_YCrCb444	(1 << 3)
>  #define SDVO_CMD_GET_COLORIMETRY	0x8f
>  #define SDVO_CMD_GET_AUDIO_ENCRYPT_PREFER 0x90
>  #define SDVO_CMD_SET_AUDIO_STAT		0x91
> -- 
> 2.24.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_sdvo_regs.h b/drivers/gpu/drm/i915/display/intel_sdvo_regs.h
index 13b9a8e257bb..74dc6c042b6e 100644
--- a/drivers/gpu/drm/i915/display/intel_sdvo_regs.h
+++ b/drivers/gpu/drm/i915/display/intel_sdvo_regs.h
@@ -705,10 +705,10 @@  struct intel_sdvo_enhancements_arg {
 #define SDVO_CMD_GET_PIXEL_REPLI	0x8c
 #define SDVO_CMD_GET_COLORIMETRY_CAP	0x8d
 #define SDVO_CMD_SET_COLORIMETRY	0x8e
-  #define SDVO_COLORIMETRY_RGB256   0x0
-  #define SDVO_COLORIMETRY_RGB220   0x1
-  #define SDVO_COLORIMETRY_YCrCb422 0x3
-  #define SDVO_COLORIMETRY_YCrCb444 0x4
+  #define SDVO_COLORIMETRY_RGB256	(1 << 0)
+  #define SDVO_COLORIMETRY_RGB220	(1 << 1)
+  #define SDVO_COLORIMETRY_YCrCb422	(1 << 2)
+  #define SDVO_COLORIMETRY_YCrCb444	(1 << 3)
 #define SDVO_CMD_GET_COLORIMETRY	0x8f
 #define SDVO_CMD_GET_AUDIO_ENCRYPT_PREFER 0x90
 #define SDVO_CMD_SET_AUDIO_STAT		0x91