[12/14] drm/i915: Drop the shadow w/a batch buffer
diff mbox series

Message ID 20200109085839.873553-12-chris@chris-wilson.co.uk
State New
Headers show
Series
  • [01/14] drm/i915/gt: Push context state allocation earlier
Related show

Commit Message

Chris Wilson Jan. 9, 2020, 8:58 a.m. UTC
While this is technically the batch as executed by the HW (in part at
least), it is confusing, and only used for a minority of gen.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/i915_gpu_error.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Mika Kuoppala Jan. 9, 2020, 9:05 a.m. UTC | #1
Chris Wilson <chris@chris-wilson.co.uk> writes:

> While this is technically the batch as executed by the HW (in part at
> least), it is confusing, and only used for a minority of gen.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/i915_gpu_error.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
> index a35aad439281..796c9ce0c494 100644
> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
> @@ -1423,8 +1423,6 @@ intel_engine_coredump_add_request(struct intel_engine_coredump *ee,
>  	vma = request_record_user(rq, vma, gfp);
>  	vma = capture_vma(vma, rq->ring->vma, "ring", gfp);
>  	vma = capture_vma(vma, rq->context->state, "HW context", gfp);
> -	if (HAS_BROKEN_CS_TLB(rq->i915))
> -		vma = capture_vma(vma, ee->engine->gt->scratch, "WA batch", gfp);
>  
>  	ee->rq_head = rq->head;
>  	ee->rq_post = rq->postfix;
> -- 
> 2.25.0.rc1
Andi Shyti Jan. 10, 2020, 11:02 a.m. UTC | #2
Hi Chris,

On Thu, Jan 09, 2020 at 08:58:37AM +0000, Chris Wilson wrote:
> While this is technically the batch as executed by the HW (in part at
> least), it is confusing, and only used for a minority of gen.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Acked-by: Andi Shyti <andi.shyti@intel.com>

Andi

Patch
diff mbox series

diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
index a35aad439281..796c9ce0c494 100644
--- a/drivers/gpu/drm/i915/i915_gpu_error.c
+++ b/drivers/gpu/drm/i915/i915_gpu_error.c
@@ -1423,8 +1423,6 @@  intel_engine_coredump_add_request(struct intel_engine_coredump *ee,
 	vma = request_record_user(rq, vma, gfp);
 	vma = capture_vma(vma, rq->ring->vma, "ring", gfp);
 	vma = capture_vma(vma, rq->context->state, "HW context", gfp);
-	if (HAS_BROKEN_CS_TLB(rq->i915))
-		vma = capture_vma(vma, ee->engine->gt->scratch, "WA batch", gfp);
 
 	ee->rq_head = rq->head;
 	ee->rq_post = rq->postfix;