| Message ID | 1578634957-54826-2-git-send-email-hanjie.lin@amlogic.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: meson: Add support for USB on Amlogic A1 | expand |
Hi Hanjie, On Fri, Jan 10, 2020 at 6:43 AM Hanjie Lin <hanjie.lin@amlogic.com> wrote: > > Add the Amlogic A1 Family USB2 PHY Bindings > > It supports Host mode only. > > Signed-off-by: Hanjie Lin <hanjie.lin@amlogic.com> > Signed-off-by: Yue Wang <yue.wang@amlogic.com> > --- > .../bindings/phy/amlogic,meson-a1-usb2-phy.yaml | 62 ++++++++++++++++++++++ > 1 file changed, 62 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml there are only two differences to the existing amlogic,meson-g12a-usb2-phy.yaml binding: - different compatible string (the existing binding already has an enum, so that would be easy to extend) - new, mandatory power-domains property (Documentation/devicetree/bindings/sound/allwinner,sun4i-a10-codec.yaml has examples how to make properties mandatory based on the compatible string) have you considered merging this with the existing amlogic,meson-g12a-usb2-phy.yaml binding? this is not a "must have" in my opinion, I still want to hear your opinion on this topic! Martin
On 2020/1/12 4:54, Martin Blumenstingl wrote: > Hi Hanjie, > > On Fri, Jan 10, 2020 at 6:43 AM Hanjie Lin <hanjie.lin@amlogic.com> wrote: >> >> Add the Amlogic A1 Family USB2 PHY Bindings >> >> It supports Host mode only. >> >> Signed-off-by: Hanjie Lin <hanjie.lin@amlogic.com> >> Signed-off-by: Yue Wang <yue.wang@amlogic.com> >> --- >> .../bindings/phy/amlogic,meson-a1-usb2-phy.yaml | 62 ++++++++++++++++++++++ >> 1 file changed, 62 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml > there are only two differences to the existing > amlogic,meson-g12a-usb2-phy.yaml binding: > - different compatible string (the existing binding already has an > enum, so that would be easy to extend) > - new, mandatory power-domains property > (Documentation/devicetree/bindings/sound/allwinner,sun4i-a10-codec.yaml > has examples how to make properties mandatory based on the compatible > string) > > have you considered merging this with the existing > amlogic,meson-g12a-usb2-phy.yaml binding? > this is not a "must have" in my opinion, I still want to hear your > opinion on this topic! > > > Martin > > . > Hi Martin, Thanks for your advice. Of course, it should looks much better to have merging this into the existing amlogic,meson-g12a-usb2-phy.yaml. I will try to do it by following the examples. thanks, Hanjie
diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml new file mode 100644 index 00000000..8f8f5d3 --- /dev/null +++ b/Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml @@ -0,0 +1,62 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +# Copyright 2019 Amlogic, Inc +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/phy/amlogic,meson-a1-usb2-phy.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Amlogic A1 USB2 PHY + +maintainers: + - Yue Wang <yue.wang@amlogic.com> + +properties: + compatible: + const: amlogic,meson-a1-usb2-phy + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + clock-names: + items: + - const: xtal + + resets: + maxItems: 1 + + reset-names: + items: + - const: phy + + "#phy-cells": + const: 0 + + power-domains: + maxItems: 1 + +required: + - compatible + - reg + - clocks + - clock-names + - resets + - reset-names + - "#phy-cells" + - power-domains + +examples: + - | + usb2_phy1: phy@40000 { + status = "okay"; + compatible = "amlogic,a1-usb2-phy"; + clocks = <&clkc_periphs 2>; + clock-names = "xtal"; + reg = <0x0 0x40000 0x0 0x2000>; + resets = <&reset RESET_USBPHY>; + reset-names = "phy"; + #phy-cells = <0>; + power-domains = <&pwrc PWRC_USB_ID>; + };