Message ID | 89248aebf252aaabf5fce44ef4cffc7e3da38212.1578691030.git.lars.kurth@citrix.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | get-maintainer.pl: Dont fall over when L: contains a display name | expand |
I should have added more people to this change. The issue without this fix is that entries such as L: xen-devel <xen-devel@lists.xenproject.org> break get_maintainer.pl and thus add_maintainers.pl Lars On 10/01/2020, 21:19, "Lars Kurth" <lars.kurth@xenproject.org> wrote: From: Lars Kurth <lars.kurth@citrix.com> Prior to this change e-mail addresses of the form "display name <email>" would result into empty output. Also see https://lists.xenproject.org/archives/html/xen-devel/2020-01/msg00753.html Signed-off-by: Lars Kurth <lars.kurth@citrix.com> --- CC: jgross@suse.com --- scripts/get_maintainer.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index 2e661f47d8..48e07370e8 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -1073,7 +1073,7 @@ sub add_categories { my $ptype = $1; my $pvalue = $2; if ($ptype eq "L") { - my $list_address = $pvalue; + my ($list_name, $list_address) = parse_email($pvalue); my $list_additional = ""; my $list_role = get_list_role($i); -- 2.13.0
Hi Lars, On 15/01/2020 18:11, Lars Kurth wrote: > I should have added more people to this change. The issue without this fix is that entries such as > > L: xen-devel <xen-devel@lists.xenproject.org> > > break get_maintainer.pl and thus add_maintainers.pl > > Lars > > On 10/01/2020, 21:19, "Lars Kurth" <lars.kurth@xenproject.org> wrote: > > From: Lars Kurth <lars.kurth@citrix.com> > > Prior to this change e-mail addresses of the form "display name > <email>" would result into empty output. Also see > https://lists.xenproject.org/archives/html/xen-devel/2020-01/msg00753.html > > Signed-off-by: Lars Kurth <lars.kurth@citrix.com> Reviewed-by: Julien Grall <julien@xen.org> Cheers, > --- > CC: jgross@suse.com > --- > scripts/get_maintainer.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl > index 2e661f47d8..48e07370e8 100755 > --- a/scripts/get_maintainer.pl > +++ b/scripts/get_maintainer.pl > @@ -1073,7 +1073,7 @@ sub add_categories { > my $ptype = $1; > my $pvalue = $2; > if ($ptype eq "L") { > - my $list_address = $pvalue; > + my ($list_name, $list_address) = parse_email($pvalue); > my $list_additional = ""; > my $list_role = get_list_role($i); > > -- > 2.13.0 > > >
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index 2e661f47d8..48e07370e8 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -1073,7 +1073,7 @@ sub add_categories { my $ptype = $1; my $pvalue = $2; if ($ptype eq "L") { - my $list_address = $pvalue; + my ($list_name, $list_address) = parse_email($pvalue); my $list_additional = ""; my $list_role = get_list_role($i);