| Message ID | 20200113132042.25717-1-mikita.lipski@amd.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/amdgpu/display: Use u64 divide macro for round up division | expand |
On 2020-01-13 8:20 a.m., mikita.lipski@amd.com wrote: > From: Mikita Lipski <mikita.lipski@amd.com> > > [why] > Fix compilation warnings on i386 architecture: > undefined reference to `__udivdi3' > [how] > Switch DIV_ROUND_UP to DIV64_U64_ROUND_UP > > Reported-by: Randy Dunlap <rdunlap@infradead.org> > Signed-off-by: Mikita Lipski <mikita.lipski@amd.com> Reviewed-by: Harry Wentland <harry.wentland@amd.com> Harry > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c > index 52fb207393ef..96b391e4b3e7 100644 > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c > @@ -534,7 +534,7 @@ static int kbps_to_peak_pbn(int kbps) > > peak_kbps *= 1006; > peak_kbps = div_u64(peak_kbps, 1000); > - return (int) DIV_ROUND_UP(peak_kbps * 64, (54 * 8 * 1000)); > + return (int) DIV64_U64_ROUND_UP(peak_kbps * 64, (54 * 8 * 1000)); > } > > static void set_dsc_configs_from_fairness_vars(struct dsc_mst_fairness_params *params, >
On Mon, Jan 13, 2020 at 08:20:42AM -0500, mikita.lipski@amd.com wrote: > From: Mikita Lipski <mikita.lipski@amd.com> > > [why] > Fix compilation warnings on i386 architecture: > undefined reference to `__udivdi3' > [how] > Switch DIV_ROUND_UP to DIV64_U64_ROUND_UP > > Reported-by: Randy Dunlap <rdunlap@infradead.org> > Signed-off-by: Mikita Lipski <mikita.lipski@amd.com> > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c > index 52fb207393ef..96b391e4b3e7 100644 > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c > @@ -534,7 +534,7 @@ static int kbps_to_peak_pbn(int kbps) > > peak_kbps *= 1006; > peak_kbps = div_u64(peak_kbps, 1000); > - return (int) DIV_ROUND_UP(peak_kbps * 64, (54 * 8 * 1000)); > + return (int) DIV64_U64_ROUND_UP(peak_kbps * 64, (54 * 8 * 1000)); DIV_ROUND_UP_ULL() would seem to suffice for this divisor. > } > > static void set_dsc_configs_from_fairness_vars(struct dsc_mst_fairness_params *params, > -- > 2.17.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On 1/13/20 9:07 AM, Ville Syrjälä wrote: > On Mon, Jan 13, 2020 at 08:20:42AM -0500, mikita.lipski@amd.com wrote: >> From: Mikita Lipski <mikita.lipski@amd.com> >> >> [why] >> Fix compilation warnings on i386 architecture: >> undefined reference to `__udivdi3' >> [how] >> Switch DIV_ROUND_UP to DIV64_U64_ROUND_UP >> >> Reported-by: Randy Dunlap <rdunlap@infradead.org> >> Signed-off-by: Mikita Lipski <mikita.lipski@amd.com> >> --- >> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c >> index 52fb207393ef..96b391e4b3e7 100644 >> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c >> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c >> @@ -534,7 +534,7 @@ static int kbps_to_peak_pbn(int kbps) >> >> peak_kbps *= 1006; >> peak_kbps = div_u64(peak_kbps, 1000); >> - return (int) DIV_ROUND_UP(peak_kbps * 64, (54 * 8 * 1000)); >> + return (int) DIV64_U64_ROUND_UP(peak_kbps * 64, (54 * 8 * 1000)); that builds fine. > DIV_ROUND_UP_ULL() would seem to suffice for this divisor. and so does that one. Thanks. For either patch: Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested >> } >> >> static void set_dsc_configs_from_fairness_vars(struct dsc_mst_fairness_params *params, >> --
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c index 52fb207393ef..96b391e4b3e7 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c @@ -534,7 +534,7 @@ static int kbps_to_peak_pbn(int kbps) peak_kbps *= 1006; peak_kbps = div_u64(peak_kbps, 1000); - return (int) DIV_ROUND_UP(peak_kbps * 64, (54 * 8 * 1000)); + return (int) DIV64_U64_ROUND_UP(peak_kbps * 64, (54 * 8 * 1000)); } static void set_dsc_configs_from_fairness_vars(struct dsc_mst_fairness_params *params,