| Message ID | 20200113172038.99689-1-cengiz@kernel.wtf (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: davinci: remove self assignment in vpfe | expand |
Hi Cengiz, Thank you for the patch. On Mon, Jan 13, 2020 at 5:21 PM Cengiz Can <cengiz@kernel.wtf> wrote: > > There's a self assignment which has no effect. > > Removed self assignment. > > Signed-off-by: Cengiz Can <cengiz@kernel.wtf> > --- > drivers/media/platform/davinci/vpfe_capture.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/platform/davinci/vpfe_capture.c b/drivers/media/platform/davinci/vpfe_capture.c > index 916ed743d716..089648665cdf 100644 > --- a/drivers/media/platform/davinci/vpfe_capture.c > +++ b/drivers/media/platform/davinci/vpfe_capture.c > @@ -879,7 +879,6 @@ static int vpfe_enum_fmt_vid_cap(struct file *file, void *priv, > /* Fill in the information about format */ > pix_fmt = vpfe_lookup_pix_format(pix); > if (pix_fmt) { > - fmt->pixelformat = fmt->pixelformat; good catch, but the correct fix is to assign pix_fmt->pixelformat to fmt->pixelformat. Cheers, --Prabhakar Lad > return 0; > } > return -EINVAL; > -- > 2.24.1 >
diff --git a/drivers/media/platform/davinci/vpfe_capture.c b/drivers/media/platform/davinci/vpfe_capture.c index 916ed743d716..089648665cdf 100644 --- a/drivers/media/platform/davinci/vpfe_capture.c +++ b/drivers/media/platform/davinci/vpfe_capture.c @@ -879,7 +879,6 @@ static int vpfe_enum_fmt_vid_cap(struct file *file, void *priv, /* Fill in the information about format */ pix_fmt = vpfe_lookup_pix_format(pix); if (pix_fmt) { - fmt->pixelformat = fmt->pixelformat; return 0; } return -EINVAL;
There's a self assignment which has no effect. Removed self assignment. Signed-off-by: Cengiz Can <cengiz@kernel.wtf> --- drivers/media/platform/davinci/vpfe_capture.c | 1 - 1 file changed, 1 deletion(-) -- 2.24.1