power: avs: qcom-cpr: add a printout after the driver has been initialized
diff mbox series

Message ID 20200113200258.18031-1-nks@flawful.org
State Awaiting Upstream
Delegated to: Rafael Wysocki
Headers show
Series
  • power: avs: qcom-cpr: add a printout after the driver has been initialized
Related show

Commit Message

Niklas Cassel Jan. 13, 2020, 8:02 p.m. UTC
In order to easier inform the user that the driver has been initialized
successfully, add a printout after the driver has been initialized.

At the same time, remove a dev_dbg() that is now redundant.

Signed-off-by: Niklas Cassel <nks@flawful.org>
---
 drivers/power/avs/qcom-cpr.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Bjorn Andersson Jan. 24, 2020, 5:10 p.m. UTC | #1
On Mon 13 Jan 12:02 PST 2020, Niklas Cassel wrote:

> In order to easier inform the user that the driver has been initialized
> successfully, add a printout after the driver has been initialized.
> 
> At the same time, remove a dev_dbg() that is now redundant.
> 

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> Signed-off-by: Niklas Cassel <nks@flawful.org>
> ---
>  drivers/power/avs/qcom-cpr.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/power/avs/qcom-cpr.c b/drivers/power/avs/qcom-cpr.c
> index 9192fb747653..b158a684d05c 100644
> --- a/drivers/power/avs/qcom-cpr.c
> +++ b/drivers/power/avs/qcom-cpr.c
> @@ -1547,8 +1547,6 @@ static int cpr_pd_attach_dev(struct generic_pm_domain *domain,
>  		goto unlock;
>  	}
>  
> -	dev_dbg(drv->dev, "number of OPPs: %d\n", drv->num_corners);
> -
>  	drv->corners = devm_kcalloc(drv->dev, drv->num_corners,
>  				    sizeof(*drv->corners),
>  				    GFP_KERNEL);
> @@ -1586,6 +1584,9 @@ static int cpr_pd_attach_dev(struct generic_pm_domain *domain,
>  				   acc_desc->enable_mask,
>  				   acc_desc->enable_mask);
>  
> +	dev_info(drv->dev, "driver initialized with %u OPPs\n",
> +		 drv->num_corners);
> +
>  unlock:
>  	mutex_unlock(&drv->lock);
>  
> -- 
> 2.24.1
>

Patch
diff mbox series

diff --git a/drivers/power/avs/qcom-cpr.c b/drivers/power/avs/qcom-cpr.c
index 9192fb747653..b158a684d05c 100644
--- a/drivers/power/avs/qcom-cpr.c
+++ b/drivers/power/avs/qcom-cpr.c
@@ -1547,8 +1547,6 @@  static int cpr_pd_attach_dev(struct generic_pm_domain *domain,
 		goto unlock;
 	}
 
-	dev_dbg(drv->dev, "number of OPPs: %d\n", drv->num_corners);
-
 	drv->corners = devm_kcalloc(drv->dev, drv->num_corners,
 				    sizeof(*drv->corners),
 				    GFP_KERNEL);
@@ -1586,6 +1584,9 @@  static int cpr_pd_attach_dev(struct generic_pm_domain *domain,
 				   acc_desc->enable_mask,
 				   acc_desc->enable_mask);
 
+	dev_info(drv->dev, "driver initialized with %u OPPs\n",
+		 drv->num_corners);
+
 unlock:
 	mutex_unlock(&drv->lock);