diff mbox series

[2/4] xen/char: ehci: Directly include xen/timer.h rather rely on dependency

Message ID 20200113213342.8206-3-julien@xen.org (mailing list archive)
State New, archived
Headers show
Series xen/x86: Rework inclusion between struct pirq and | expand

Commit Message

Julien Grall Jan. 13, 2020, 9:33 p.m. UTC 
From: Julien Grall <jgrall@amazon.com>

The ehci char driver is using timers but relying on the header
xen/timer.h to be included via asm-x86/hvm/irq.h which is not even
directly included!

Future rework will reduce the number of places where asm-x86/hvm/irq.h
will be included. Include xen/timer.h directly to avoid any breakage.

Signed-off-by: Julien Grall <jgrall@amazon.com>
---
 xen/drivers/char/ehci-dbgp.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Jan Beulich Jan. 14, 2020, 9:33 a.m. UTC | #1 
On 13.01.2020 22:33, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
> 
> The ehci char driver is using timers but relying on the header
> xen/timer.h to be included via asm-x86/hvm/irq.h which is not even
> directly included!
> 
> Future rework will reduce the number of places where asm-x86/hvm/irq.h
> will be included. Include xen/timer.h directly to avoid any breakage.
> 
> Signed-off-by: Julien Grall <jgrall@amazon.com>

Acked-by: Jan Beulich <jbeulich@suse.com>
diff mbox series

Patch

diff --git a/xen/drivers/char/ehci-dbgp.c b/xen/drivers/char/ehci-dbgp.c
index b6e155d17b..8124e0aad8 100644
--- a/xen/drivers/char/ehci-dbgp.c
+++ b/xen/drivers/char/ehci-dbgp.c
@@ -10,6 +10,7 @@ 
 #include <xen/errno.h>
 #include <xen/pci.h>
 #include <xen/serial.h>
+#include <xen/timer.h>
 #include <asm/byteorder.h>
 #include <asm/io.h>
 #include <asm/fixmap.h>