Message ID | 1578992765-1418-1-git-send-email-krzk@kernel.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | [v2,1/4] i2c: pmcmsp: Use proper printk format for resource_size_t | expand |
> + "Unable to get memory/io address region %pap\n", > + &(res->start)); My first thought was "parens not needed"; not because I like being picky but because it doesn't look more readable to me. checkpatch agrees: CHECK: Unnecessary parentheses around res->start #30: FILE: drivers/i2c/busses/i2c-pmcmsp.c:278: + &(res->start));
On Wed, Jan 15, 2020 at 06:45:53PM +0100, Wolfram Sang wrote: > > > + "Unable to get memory/io address region %pap\n", > > + &(res->start)); > > My first thought was "parens not needed"; not because I like being picky > but because it doesn't look more readable to me. > > checkpatch agrees: > > CHECK: Unnecessary parentheses around res->start > #30: FILE: drivers/i2c/busses/i2c-pmcmsp.c:278: > + &(res->start)); Indeed... let me send v3. Best regards, Krzysztof
diff --git a/drivers/i2c/busses/i2c-pmcmsp.c b/drivers/i2c/busses/i2c-pmcmsp.c index 4fde74eb34a7..9a2acf09f1cf 100644 --- a/drivers/i2c/busses/i2c-pmcmsp.c +++ b/drivers/i2c/busses/i2c-pmcmsp.c @@ -274,8 +274,8 @@ static int pmcmsptwi_probe(struct platform_device *pldev) if (!request_mem_region(res->start, resource_size(res), pldev->name)) { dev_err(&pldev->dev, - "Unable to get memory/io address region 0x%08x\n", - res->start); + "Unable to get memory/io address region %pap\n", + &(res->start)); rc = -EBUSY; goto ret_err; } @@ -285,7 +285,7 @@ static int pmcmsptwi_probe(struct platform_device *pldev) resource_size(res)); if (!pmcmsptwi_data.iobase) { dev_err(&pldev->dev, - "Unable to ioremap address 0x%08x\n", res->start); + "Unable to ioremap address %pap\n", &(res->start)); rc = -EIO; goto ret_unreserve; }
resource_size_t should be printed with its own size-independent format to fix warnings when compiling on 64-bit platform (e.g. with COMPILE_TEST): drivers/i2c/busses/i2c-pmcmsp.c: In function ‘pmcmsptwi_probe’: drivers/i2c/busses/i2c-pmcmsp.c:276:25: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘resource_size_t {aka long long unsigned int}’ [-Wformat=] Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- Changes since v1: 1. Use %pap, not %pa[p]. --- drivers/i2c/busses/i2c-pmcmsp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)