[2/2] ALSA: HDA: patch_hdmi: remove warnings with empty body
diff mbox series

Message ID 20200113211405.28070-3-pierre-louis.bossart@linux.intel.com
State New
Headers show
Series
  • ALSA: HDA: remove warnings with make W=1
Related show

Commit Message

Pierre-Louis Bossart Jan. 13, 2020, 9:14 p.m. UTC
make W=1 reports the following warnings, fix as suggested

sound/pci/hda/patch_hdmi.c: In function ‘hdmi_non_intrinsic_event’:
sound/pci/hda/patch_hdmi.c:824:3: warning: suggest braces around empty
body in an ‘if’ statement [-Wempty-body]
  824 |   ;
      |   ^
sound/pci/hda/patch_hdmi.c:826:3: warning: suggest braces around empty
body in an ‘if’ statement [-Wempty-body]
  826 |   ;
      |   ^

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/pci/hda/patch_hdmi.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Takashi Iwai Jan. 14, 2020, 6:52 a.m. UTC | #1
On Mon, 13 Jan 2020 22:14:05 +0100,
Pierre-Louis Bossart wrote:
> 
> make W=1 reports the following warnings, fix as suggested
> 
> sound/pci/hda/patch_hdmi.c: In function ‘hdmi_non_intrinsic_event’:
> sound/pci/hda/patch_hdmi.c:824:3: warning: suggest braces around empty
> body in an ‘if’ statement [-Wempty-body]
>   824 |   ;
>       |   ^
> sound/pci/hda/patch_hdmi.c:826:3: warning: suggest braces around empty
> body in an ‘if’ statement [-Wempty-body]
>   826 |   ;
>       |   ^
> 
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

Applied, thanks.


Takashi

Patch
diff mbox series

diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index 3a18fa4f8c21..ce3c212ee467 100644
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -820,10 +820,12 @@  static void hdmi_non_intrinsic_event(struct hda_codec *codec, unsigned int res)
 		cp_ready);
 
 	/* TODO */
-	if (cp_state)
+	if (cp_state) {
 		;
-	if (cp_ready)
+	}
+	if (cp_ready) {
 		;
+	}
 }