[2/4] ASoC: madera: Correct DMIC only input hook ups
diff mbox series

Message ID 20200114161841.451-2-ckeepax@opensource.cirrus.com
State New
Headers show
Series
  • [1/4] ASoC: wm_adsp: Correct cache handling of new kernel control API
Related show

Commit Message

Charles Keepax Jan. 14, 2020, 4:18 p.m. UTC
Both the data and clock should be connected to both the left and right
inputs for DMIC only inputs, add the missing routes.

Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---
 sound/soc/codecs/cs47l85.c | 6 ++++++
 sound/soc/codecs/cs47l90.c | 4 ++++
 2 files changed, 10 insertions(+)

Comments

Charles Keepax Jan. 17, 2020, 11:02 a.m. UTC | #1
On Tue, Jan 14, 2020 at 04:18:39PM +0000, Charles Keepax wrote:
> diff --git a/sound/soc/codecs/cs47l90.c b/sound/soc/codecs/cs47l90.c
> index c3b6f4d41005b..35ff5a923e282 100644
> --- a/sound/soc/codecs/cs47l90.c
> +++ b/sound/soc/codecs/cs47l90.c
> @@ -1941,9 +1941,13 @@ static const struct snd_soc_dapm_route cs47l90_dapm_routes[] = {
>  	{ "IN3R", NULL, "DMICDAT3" },

IN3 should be updated here as well, sorry will respin.

Thanks,
Charles

>  
>  	{ "IN4L", NULL, "DMICCLK4" },
> +	{ "IN4L", NULL, "DMICDAT4" },
> +	{ "IN4R", NULL, "DMICCLK4" },
>  	{ "IN4R", NULL, "DMICDAT4" },
>  
>  	{ "IN5L", NULL, "DMICCLK5" },
> +	{ "IN5L", NULL, "DMICDAT5" },
> +	{ "IN5R", NULL, "DMICCLK5" },
>  	{ "IN5R", NULL, "DMICDAT5" },
>  
>  	MADERA_MIXER_ROUTES("OUT1L", "HPOUT1L"),
> -- 
> 2.11.0
>

Patch
diff mbox series

diff --git a/sound/soc/codecs/cs47l85.c b/sound/soc/codecs/cs47l85.c
index f85581a97bdc3..05445abcb470b 100644
--- a/sound/soc/codecs/cs47l85.c
+++ b/sound/soc/codecs/cs47l85.c
@@ -2008,12 +2008,18 @@  static const struct snd_soc_dapm_route cs47l85_dapm_routes[] = {
 	{ "IN3R", NULL, "IN3R Mode" },
 
 	{ "IN4L", NULL, "DMICCLK4" },
+	{ "IN4L", NULL, "DMICDAT4" },
+	{ "IN4R", NULL, "DMICCLK4" },
 	{ "IN4R", NULL, "DMICDAT4" },
 
 	{ "IN5L", NULL, "DMICCLK5" },
+	{ "IN5L", NULL, "DMICDAT5" },
+	{ "IN5R", NULL, "DMICCLK5" },
 	{ "IN5R", NULL, "DMICDAT5" },
 
 	{ "IN6L", NULL, "DMICCLK6" },
+	{ "IN6L", NULL, "DMICDAT6" },
+	{ "IN6R", NULL, "DMICCLK6" },
 	{ "IN6R", NULL, "DMICDAT6" },
 
 	MADERA_MIXER_ROUTES("OUT1L", "HPOUT1L"),
diff --git a/sound/soc/codecs/cs47l90.c b/sound/soc/codecs/cs47l90.c
index c3b6f4d41005b..35ff5a923e282 100644
--- a/sound/soc/codecs/cs47l90.c
+++ b/sound/soc/codecs/cs47l90.c
@@ -1941,9 +1941,13 @@  static const struct snd_soc_dapm_route cs47l90_dapm_routes[] = {
 	{ "IN3R", NULL, "DMICDAT3" },
 
 	{ "IN4L", NULL, "DMICCLK4" },
+	{ "IN4L", NULL, "DMICDAT4" },
+	{ "IN4R", NULL, "DMICCLK4" },
 	{ "IN4R", NULL, "DMICDAT4" },
 
 	{ "IN5L", NULL, "DMICCLK5" },
+	{ "IN5L", NULL, "DMICDAT5" },
+	{ "IN5R", NULL, "DMICCLK5" },
 	{ "IN5R", NULL, "DMICDAT5" },
 
 	MADERA_MIXER_ROUTES("OUT1L", "HPOUT1L"),