| Message ID | 20200115082447.19520-12-namjae.jeon@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | add the latest exfat driver | expand |
On Wednesday 15 January 2020 17:24:44 Namjae Jeon wrote: > This adds the Kconfig and Makefile for exfat. > > Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com> > Signed-off-by: Sungjong Seo <sj1557.seo@samsung.com> > --- > fs/exfat/Kconfig | 21 +++++++++++++++++++++ > fs/exfat/Makefile | 8 ++++++++ > 2 files changed, 29 insertions(+) > create mode 100644 fs/exfat/Kconfig > create mode 100644 fs/exfat/Makefile > > diff --git a/fs/exfat/Kconfig b/fs/exfat/Kconfig > new file mode 100644 > index 000000000000..9eeaa6d06adf > --- /dev/null > +++ b/fs/exfat/Kconfig > @@ -0,0 +1,21 @@ > +# SPDX-License-Identifier: GPL-2.0-or-later > + > +config EXFAT_FS > + tristate "exFAT filesystem support" > + select NLS > + help > + This allows you to mount devices formatted with the exFAT file system. > + exFAT is typically used on SD-Cards or USB sticks. > + > + To compile this as a module, choose M here: the module will be called > + exfat. > + > +config EXFAT_DEFAULT_IOCHARSET > + string "Default iocharset for exFAT" > + default "utf8" > + depends on EXFAT_FS > + help > + Set this to the default input/output character set you'd > + like exFAT to use. It should probably match the character set > + that most of your exFAT filesystems use, and can be overridden > + with the "iocharset" mount option for exFAT filesystems. Hello! This description is incorrect. iocharset option specify what character set is expected by VFS layer and not character set used by exFAT filesystem. exFAT filesystem always uses UTF-16 as this is the only allowed by exFAT specification. > diff --git a/fs/exfat/Makefile b/fs/exfat/Makefile > new file mode 100644 > index 000000000000..ed51926a4971 > --- /dev/null > +++ b/fs/exfat/Makefile > @@ -0,0 +1,8 @@ > +# SPDX-License-Identifier: GPL-2.0-or-later > +# > +# Makefile for the linux exFAT filesystem support. > +# > +obj-$(CONFIG_EXFAT_FS) += exfat.o > + > +exfat-y := inode.o namei.o dir.o super.o fatent.o cache.o nls.o misc.o \ > + file.o balloc.o
> > +config EXFAT_DEFAULT_IOCHARSET > > + string "Default iocharset for exFAT" > > + default "utf8" > > + depends on EXFAT_FS > > + help > > + Set this to the default input/output character set you'd > > + like exFAT to use. It should probably match the character set > > + that most of your exFAT filesystems use, and can be overridden > > + with the "iocharset" mount option for exFAT filesystems. > > Hello! This description is incorrect. iocharset option specify what > character set is expected by VFS layer and not character set used by exFAT > filesystem. exFAT filesystem always uses UTF-16 as this is the only > allowed by exFAT specification. Hi Pali, Could you please review updated description ? diff --git a/fs/exfat/Kconfig b/fs/exfat/Kconfig index 9eeaa6d06..f2b0cf2c1 100644 --- a/fs/exfat/Kconfig +++ b/fs/exfat/Kconfig @@ -15,7 +15,7 @@ config EXFAT_DEFAULT_IOCHARSET default "utf8" depends on EXFAT_FS help - Set this to the default input/output character set you'd - like exFAT to use. It should probably match the character set - that most of your exFAT filesystems use, and can be overridden - with the "iocharset" mount option for exFAT filesystems. + Set this to the default input/output character set to use for + converting between the encoding is used for user visible filename and + UTF-16 character that exfat filesystem use. and can be overridden with + the "iocharset" mount option for exFAT filesystems.
On Friday 17 January 2020 13:22:27 Namjae Jeon wrote: > > > +config EXFAT_DEFAULT_IOCHARSET > > > + string "Default iocharset for exFAT" > > > + default "utf8" > > > + depends on EXFAT_FS > > > + help > > > + Set this to the default input/output character set you'd > > > + like exFAT to use. It should probably match the character set > > > + that most of your exFAT filesystems use, and can be overridden > > > + with the "iocharset" mount option for exFAT filesystems. > > > > Hello! This description is incorrect. iocharset option specify what > > character set is expected by VFS layer and not character set used by exFAT > > filesystem. exFAT filesystem always uses UTF-16 as this is the only > > allowed by exFAT specification. > Hi Pali, > > Could you please review updated description ? > > diff --git a/fs/exfat/Kconfig b/fs/exfat/Kconfig > index 9eeaa6d06..f2b0cf2c1 100644 > --- a/fs/exfat/Kconfig > +++ b/fs/exfat/Kconfig > @@ -15,7 +15,7 @@ config EXFAT_DEFAULT_IOCHARSET > default "utf8" > depends on EXFAT_FS > help > - Set this to the default input/output character set you'd > - like exFAT to use. It should probably match the character set > - that most of your exFAT filesystems use, and can be overridden > - with the "iocharset" mount option for exFAT filesystems. > + Set this to the default input/output character set to use for > + converting between the encoding is used for user visible filename and > + UTF-16 character that exfat filesystem use. and can be overridden with > + the "iocharset" mount option for exFAT filesystems. Hello! This is much better. Fine for me.
>> Hi Pali, >> >> Could you please review updated description ? >> >> diff --git a/fs/exfat/Kconfig b/fs/exfat/Kconfig >> index 9eeaa6d06..f2b0cf2c1 100644 >> --- a/fs/exfat/Kconfig >> +++ b/fs/exfat/Kconfig >> @@ -15,7 +15,7 @@ config EXFAT_DEFAULT_IOCHARSET >> default "utf8" >> depends on EXFAT_FS >> help >> - Set this to the default input/output character set you'd >> - like exFAT to use. It should probably match the character set >> - that most of your exFAT filesystems use, and can be overridden >> - with the "iocharset" mount option for exFAT filesystems. >> + Set this to the default input/output character set to use for >> + converting between the encoding is used for user visible >> filename and >> + UTF-16 character that exfat filesystem use. and can be >> overridden with >> + the "iocharset" mount option for exFAT filesystems. > > Hello! This is much better. Fine for me. Thanks for your review! > > -- > Pali Rohár > pali.rohar@gmail.com >
diff --git a/fs/exfat/Kconfig b/fs/exfat/Kconfig new file mode 100644 index 000000000000..9eeaa6d06adf --- /dev/null +++ b/fs/exfat/Kconfig @@ -0,0 +1,21 @@ +# SPDX-License-Identifier: GPL-2.0-or-later + +config EXFAT_FS + tristate "exFAT filesystem support" + select NLS + help + This allows you to mount devices formatted with the exFAT file system. + exFAT is typically used on SD-Cards or USB sticks. + + To compile this as a module, choose M here: the module will be called + exfat. + +config EXFAT_DEFAULT_IOCHARSET + string "Default iocharset for exFAT" + default "utf8" + depends on EXFAT_FS + help + Set this to the default input/output character set you'd + like exFAT to use. It should probably match the character set + that most of your exFAT filesystems use, and can be overridden + with the "iocharset" mount option for exFAT filesystems. diff --git a/fs/exfat/Makefile b/fs/exfat/Makefile new file mode 100644 index 000000000000..ed51926a4971 --- /dev/null +++ b/fs/exfat/Makefile @@ -0,0 +1,8 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# +# Makefile for the linux exFAT filesystem support. +# +obj-$(CONFIG_EXFAT_FS) += exfat.o + +exfat-y := inode.o namei.o dir.o super.o fatent.o cache.o nls.o misc.o \ + file.o balloc.o