diff mbox series

ARM: dts: stm32: Add missing ETHCK clock to ethernet node

Message ID 20200115094608.154386-1-marex@denx.de (mailing list archive)
State Mainlined
Commit 238086efd1499a890eb0ba2e7cd68236f141fbca
Headers show
Series ARM: dts: stm32: Add missing ETHCK clock to ethernet node | expand

Commit Message

Marek Vasut Jan. 15, 2020, 9:46 a.m. UTC
Add missing 'eth-ck' clock to the ethernet node. These clock are used to
generate external clock signal for the PHY in case 'st,eth_ref_clk_sel'
is specified.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Christophe ROULLIER <christophe.roullier@st.com>
Cc: Patrice Chotard <patrice.chotard@st.com>
Cc: Patrick Delaunay <patrick.delaunay@st.com>
---
 arch/arm/boot/dts/stm32mp151.dtsi | 2 ++
 1 file changed, 2 insertions(+)

Comments

Patrick Delaunay Jan. 15, 2020, 4:45 p.m. UTC | #1
Hi Marek;

Add the Linux Maintainers for STM32M linux patch:

M:	Maxime Coquelin <mcoquelin.stm32@gmail.com>
M:	Alexandre Torgue <alexandre.torgue@st.com>
L:	linux-stm32@st-md-mailman.stormreply.com (moderated for non-subscribers)
L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)


Hi Alexandre,

Can you review this patch.

Regards

Patrick

> From: Marek Vasut <marex@denx.de>
> Sent: mercredi 15 janvier 2020 10:46
> 
> Add missing 'eth-ck' clock to the ethernet node. These clock are used to generate
> external clock signal for the PHY in case 'st,eth_ref_clk_sel'
> is specified.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Christophe ROULLIER <christophe.roullier@st.com>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Cc: Patrick Delaunay <patrick.delaunay@st.com>
> ---
>  arch/arm/boot/dts/stm32mp151.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/stm32mp151.dtsi
> b/arch/arm/boot/dts/stm32mp151.dtsi
> index fb41d0778b00..e0ecc5ee7d83 100644
> --- a/arch/arm/boot/dts/stm32mp151.dtsi
> +++ b/arch/arm/boot/dts/stm32mp151.dtsi
> @@ -1369,10 +1369,12 @@ ethernet0: ethernet@5800a000 {
>  			clock-names = "stmmaceth",
>  				      "mac-clk-tx",
>  				      "mac-clk-rx",
> +				      "eth-ck",
>  				      "ethstp";
>  			clocks = <&rcc ETHMAC>,
>  				 <&rcc ETHTX>,
>  				 <&rcc ETHRX>,
> +				 <&rcc ETHCK_K>,
>  				 <&rcc ETHSTP>;
>  			st,syscon = <&syscfg 0x4>;
>  			snps,mixed-burst;
> --
> 2.24.1
Marek Vasut Jan. 17, 2020, 12:50 p.m. UTC | #2
On 1/15/20 5:45 PM, Patrick DELAUNAY wrote:
> Hi Marek;

Hi,

> Add the Linux Maintainers for STM32M linux patch:

Added, if there is a need for V2.
[...]
> 
> Hi Alexandre,
> 
> Can you review this patch.
> 
> Regards
> 
> Patrick
> 
>> From: Marek Vasut <marex@denx.de>
>> Sent: mercredi 15 janvier 2020 10:46
>>
>> Add missing 'eth-ck' clock to the ethernet node. These clock are used to generate
>> external clock signal for the PHY in case 'st,eth_ref_clk_sel'
>> is specified.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Christophe ROULLIER <christophe.roullier@st.com>
>> Cc: Patrice Chotard <patrice.chotard@st.com>
>> Cc: Patrick Delaunay <patrick.delaunay@st.com>
>> ---
>>  arch/arm/boot/dts/stm32mp151.dtsi | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/stm32mp151.dtsi
>> b/arch/arm/boot/dts/stm32mp151.dtsi
>> index fb41d0778b00..e0ecc5ee7d83 100644
>> --- a/arch/arm/boot/dts/stm32mp151.dtsi
>> +++ b/arch/arm/boot/dts/stm32mp151.dtsi
>> @@ -1369,10 +1369,12 @@ ethernet0: ethernet@5800a000 {
>>  			clock-names = "stmmaceth",
>>  				      "mac-clk-tx",
>>  				      "mac-clk-rx",
>> +				      "eth-ck",
>>  				      "ethstp";
>>  			clocks = <&rcc ETHMAC>,
>>  				 <&rcc ETHTX>,
>>  				 <&rcc ETHRX>,
>> +				 <&rcc ETHCK_K>,
>>  				 <&rcc ETHSTP>;
>>  			st,syscon = <&syscfg 0x4>;
>>  			snps,mixed-burst;
>> --
>> 2.24.1
>
Alexandre TORGUE Jan. 17, 2020, 4:59 p.m. UTC | #3
Hi Marek

On 1/17/20 1:50 PM, Marek Vasut wrote:
> On 1/15/20 5:45 PM, Patrick DELAUNAY wrote:
>> Hi Marek;
> 
> Hi,
> 
>> Add the Linux Maintainers for STM32M linux patch:
> 
> Added, if there is a need for V2.
> [...]
>>
>> Hi Alexandre,
>>
>> Can you review this patch.
>>
>> Regards
>>
>> Patrick
>>
>>> From: Marek Vasut <marex@denx.de>
>>> Sent: mercredi 15 janvier 2020 10:46
>>>
>>> Add missing 'eth-ck' clock to the ethernet node. These clock are used to generate
>>> external clock signal for the PHY in case 'st,eth_ref_clk_sel'
>>> is specified.
>>>

Just indicate in commit title that this commit is done for stm32mp15 
family. Otherwise it looks good.

Thanks
Alex

>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>> Cc: Christophe ROULLIER <christophe.roullier@st.com>
>>> Cc: Patrice Chotard <patrice.chotard@st.com>
>>> Cc: Patrick Delaunay <patrick.delaunay@st.com>
>>> ---
>>>   arch/arm/boot/dts/stm32mp151.dtsi | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/stm32mp151.dtsi
>>> b/arch/arm/boot/dts/stm32mp151.dtsi
>>> index fb41d0778b00..e0ecc5ee7d83 100644
>>> --- a/arch/arm/boot/dts/stm32mp151.dtsi
>>> +++ b/arch/arm/boot/dts/stm32mp151.dtsi
>>> @@ -1369,10 +1369,12 @@ ethernet0: ethernet@5800a000 {
>>>   			clock-names = "stmmaceth",
>>>   				      "mac-clk-tx",
>>>   				      "mac-clk-rx",
>>> +				      "eth-ck",
>>>   				      "ethstp";
>>>   			clocks = <&rcc ETHMAC>,
>>>   				 <&rcc ETHTX>,
>>>   				 <&rcc ETHRX>,
>>> +				 <&rcc ETHCK_K>,
>>>   				 <&rcc ETHSTP>;
>>>   			st,syscon = <&syscfg 0x4>;
>>>   			snps,mixed-burst;
>>> --
>>> 2.24.1
>>
> 
>
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/stm32mp151.dtsi b/arch/arm/boot/dts/stm32mp151.dtsi
index fb41d0778b00..e0ecc5ee7d83 100644
--- a/arch/arm/boot/dts/stm32mp151.dtsi
+++ b/arch/arm/boot/dts/stm32mp151.dtsi
@@ -1369,10 +1369,12 @@  ethernet0: ethernet@5800a000 {
 			clock-names = "stmmaceth",
 				      "mac-clk-tx",
 				      "mac-clk-rx",
+				      "eth-ck",
 				      "ethstp";
 			clocks = <&rcc ETHMAC>,
 				 <&rcc ETHTX>,
 				 <&rcc ETHRX>,
+				 <&rcc ETHCK_K>,
 				 <&rcc ETHSTP>;
 			st,syscon = <&syscfg 0x4>;
 			snps,mixed-burst;