[for,4.19-stable,08/25] mm, memory_hotplug: update a comment in unregister_memory()
diff mbox series

Message ID 20200115153339.36409-9-david@redhat.com
State New
Headers show
Series
  • mm/memory_hotplug: backport of pending stable fixes
Related show

Commit Message

David Hildenbrand Jan. 15, 2020, 3:33 p.m. UTC
commit 16df1456aa858a86f398dbc7d27649eb6662b0cc upstream.

The remove_memory_block() function was renamed to in commit
cc292b0b4302 ("drivers/base/memory.c: rename remove_memory_block() to
remove_memory_section()").

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
 drivers/base/memory.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Greg Kroah-Hartman Jan. 15, 2020, 3:38 p.m. UTC | #1
On Wed, Jan 15, 2020 at 04:33:22PM +0100, David Hildenbrand wrote:
> commit 16df1456aa858a86f398dbc7d27649eb6662b0cc upstream.
> 
> The remove_memory_block() function was renamed to in commit
> cc292b0b4302 ("drivers/base/memory.c: rename remove_memory_block() to
> remove_memory_section()").
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
>  drivers/base/memory.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I just picked a random patch out of this series as an example to show
that you lost the authorship information on these.  This was originally
created by Dan, so that needs to be here with a "From:" line.

All of these need to be fixed up that way, I can't take them as-is,
sorry.

thanks,

greg k-h
David Hildenbrand Jan. 15, 2020, 3:41 p.m. UTC | #2
On 15.01.20 16:38, Greg Kroah-Hartman wrote:
> On Wed, Jan 15, 2020 at 04:33:22PM +0100, David Hildenbrand wrote:
>> commit 16df1456aa858a86f398dbc7d27649eb6662b0cc upstream.
>>
>> The remove_memory_block() function was renamed to in commit
>> cc292b0b4302 ("drivers/base/memory.c: rename remove_memory_block() to
>> remove_memory_section()").
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Signed-off-by: David Hildenbrand <david@redhat.com>
>> ---
>>  drivers/base/memory.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> I just picked a random patch out of this series as an example to show
> that you lost the authorship information on these.  This was originally
> created by Dan, so that needs to be here with a "From:" line.
> 
> All of these need to be fixed up that way, I can't take them as-is,
> sorry.

Makes sense, I wasn't sure if to keep it or not (IOW, I changed it on
purpose :) ). I was expecting to have to resend either way :)

Patch
diff mbox series

diff --git a/drivers/base/memory.c b/drivers/base/memory.c
index b384f01ad29d..119b076eb5e2 100644
--- a/drivers/base/memory.c
+++ b/drivers/base/memory.c
@@ -743,7 +743,7 @@  unregister_memory(struct memory_block *memory)
 {
 	BUG_ON(memory->dev.bus != &memory_subsys);
 
-	/* drop the ref. we got in remove_memory_block() */
+	/* drop the ref. we got in remove_memory_section() */
 	put_device(&memory->dev);
 	device_unregister(&memory->dev);
 }