| Message ID | 20200116144322.57308-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] mmc: sdhci-milbeaut: Remove redundant platform_get_irq error message | expand |
On 16/01/20 4:43 pm, YueHaibing wrote: > platform_get_irq() will call dev_err() itself on failure, > so there is no need for the driver to also do this. > This is detected by coccinelle. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Acked-by: Adrian Hunter <adrian.hunter@intel.com> > --- > drivers/mmc/host/sdhci-milbeaut.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-milbeaut.c b/drivers/mmc/host/sdhci-milbeaut.c > index e6245b7..92f30a1 100644 > --- a/drivers/mmc/host/sdhci-milbeaut.c > +++ b/drivers/mmc/host/sdhci-milbeaut.c > @@ -246,10 +246,8 @@ static int sdhci_milbeaut_probe(struct platform_device *pdev) > struct f_sdhost_priv *priv; > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > - dev_err(dev, "%s: no irq specified\n", __func__); > + if (irq < 0) > return irq; > - } > > host = sdhci_alloc_host(dev, sizeof(struct f_sdhost_priv)); > if (IS_ERR(host)) >
On Thu, 16 Jan 2020 at 15:43, YueHaibing <yuehaibing@huawei.com> wrote: > > platform_get_irq() will call dev_err() itself on failure, > so there is no need for the driver to also do this. > This is detected by coccinelle. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci-milbeaut.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-milbeaut.c b/drivers/mmc/host/sdhci-milbeaut.c > index e6245b7..92f30a1 100644 > --- a/drivers/mmc/host/sdhci-milbeaut.c > +++ b/drivers/mmc/host/sdhci-milbeaut.c > @@ -246,10 +246,8 @@ static int sdhci_milbeaut_probe(struct platform_device *pdev) > struct f_sdhost_priv *priv; > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > - dev_err(dev, "%s: no irq specified\n", __func__); > + if (irq < 0) > return irq; > - } > > host = sdhci_alloc_host(dev, sizeof(struct f_sdhost_priv)); > if (IS_ERR(host)) > -- > 2.7.4 > >
diff --git a/drivers/mmc/host/sdhci-milbeaut.c b/drivers/mmc/host/sdhci-milbeaut.c index e6245b7..92f30a1 100644 --- a/drivers/mmc/host/sdhci-milbeaut.c +++ b/drivers/mmc/host/sdhci-milbeaut.c @@ -246,10 +246,8 @@ static int sdhci_milbeaut_probe(struct platform_device *pdev) struct f_sdhost_priv *priv; irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(dev, "%s: no irq specified\n", __func__); + if (irq < 0) return irq; - } host = sdhci_alloc_host(dev, sizeof(struct f_sdhost_priv)); if (IS_ERR(host))
platform_get_irq() will call dev_err() itself on failure, so there is no need for the driver to also do this. This is detected by coccinelle. Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/mmc/host/sdhci-milbeaut.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)