[4.19.y-cip,10/12] arm64: dts: renesas: r8a774c0: cat874: Add definition for 12V regulator
diff mbox series

Message ID 1579187482-4626-11-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com
State New
Headers show
Series
  • Renesas RZ/G2E backport IPA support along with minor fixes
Related show

Commit Message

Prabhakar Mahadev Lad Jan. 16, 2020, 3:11 p.m. UTC
From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

commit 7fc009cbd7d11d6b27ba5443dbfa80a0513829e4 upstream.

Power rail "D12.0V" comes straight from the power barrel connector,
and it's used in both main board and sub board.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Pavel Machek Jan. 16, 2020, 3:29 p.m. UTC | #1
Hi!

> From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> 
> commit 7fc009cbd7d11d6b27ba5443dbfa80a0513829e4 upstream.
> 
> Power rail "D12.0V" comes straight from the power barrel connector,
> and it's used in both main board and sub board.

Given that line is always on, always constant, and not referenced
anywhere, does it need to be described in the dts?

Will it be used in future?

Best regards,
								Pavel

> @@ -65,6 +65,15 @@
>  		reg = <0x0 0x48000000 0x0 0x78000000>;
>  	};
>  
> +	reg_12p0v: regulator-12p0v {
> +		compatible = "regulator-fixed";
> +		regulator-name = "D12.0V";
> +		regulator-min-microvolt = <12000000>;
> +		regulator-max-microvolt = <12000000>;
> +		regulator-boot-on;
> +		regulator-always-on;
> +	};
> +
>  	sound: sound {
>  		compatible = "simple-audio-card";
>  
> -- 
> 2.7.4
>
Prabhakar Mahadev Lad Jan. 16, 2020, 7:37 p.m. UTC | #2
Hi Pavel,

Thank you for the review.

> -----Original Message-----
> From: Pavel Machek <pavel@denx.de>
> Sent: 16 January 2020 15:30
> To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Cc: cip-dev@lists.cip-project.org; Nobuhiro Iwamatsu
> <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek <pavel@denx.de>;
> Chris Paterson <Chris.Paterson2@renesas.com>
> Subject: Re: [PATCH 4.19.y-cip 10/12] arm64: dts: renesas: r8a774c0: cat874:
> Add definition for 12V regulator
>
> Hi!
>
> > From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> >
> > commit 7fc009cbd7d11d6b27ba5443dbfa80a0513829e4 upstream.
> >
> > Power rail "D12.0V" comes straight from the power barrel connector,
> > and it's used in both main board and sub board.
>
> Given that line is always on, always constant, and not referenced anywhere,
> does it need to be described in the dts?
>
> Will it be used in future?
>
Yes the regulator will be used in future. (we plan to add support for lvds panel, the regulator will be used by the backlight)

Cheers,
--Prabhakar

> Best regards,
> Pavel
>
> > @@ -65,6 +65,15 @@
> >  reg = <0x0 0x48000000 0x0 0x78000000>;
> >  };
> >
> > +reg_12p0v: regulator-12p0v {
> > +compatible = "regulator-fixed";
> > +regulator-name = "D12.0V";
> > +regulator-min-microvolt = <12000000>;
> > +regulator-max-microvolt = <12000000>;
> > +regulator-boot-on;
> > +regulator-always-on;
> > +};
> > +
> >  sound: sound {
> >  compatible = "simple-audio-card";
> >
> > --
> > 2.7.4
> >
>
> --
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647

Patch
diff mbox series

diff --git a/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts b/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
index fdca695..83b39fd 100644
--- a/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
+++ b/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
@@ -65,6 +65,15 @@ 
 		reg = <0x0 0x48000000 0x0 0x78000000>;
 	};
 
+	reg_12p0v: regulator-12p0v {
+		compatible = "regulator-fixed";
+		regulator-name = "D12.0V";
+		regulator-min-microvolt = <12000000>;
+		regulator-max-microvolt = <12000000>;
+		regulator-boot-on;
+		regulator-always-on;
+	};
+
 	sound: sound {
 		compatible = "simple-audio-card";