dt-bindings: brcm,avs-ro-thermal: Fix binding check issues
diff mbox series

Message ID 1579200077-17496-1-git-send-email-stefan.wahren@i2se.com
State Mainlined
Commit c168baec00a04e06cd3a6b644946190f5bbb472a
Headers show
Series
  • dt-bindings: brcm,avs-ro-thermal: Fix binding check issues
Related show

Commit Message

Stefan Wahren Jan. 16, 2020, 6:41 p.m. UTC
Drop the reg property since this only necessary for the parent and
add the missing thermal-sensor-cells property description.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Fixes: 3d4849897691 ("dt-bindings: Add Broadcom AVS RO thermal")
---
 .../devicetree/bindings/thermal/brcm,avs-ro-thermal.yaml         | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

Comments

Rob Herring Jan. 16, 2020, 6:58 p.m. UTC | #1
On Thu, Jan 16, 2020 at 12:42 PM Stefan Wahren <stefan.wahren@i2se.com> wrote:
>
> Drop the reg property since this only necessary for the parent and
> add the missing thermal-sensor-cells property description.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> Fixes: 3d4849897691 ("dt-bindings: Add Broadcom AVS RO thermal")
> ---
>  .../devicetree/bindings/thermal/brcm,avs-ro-thermal.yaml         | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)

Thanks for the quick fix.

Reviewed-by: Rob Herring <robh@kernel.org>
Daniel Lezcano Jan. 16, 2020, 7:09 p.m. UTC | #2
On 16/01/2020 19:41, Stefan Wahren wrote:
> Drop the reg property since this only necessary for the parent and
> add the missing thermal-sensor-cells property description.
> 
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> Fixes: 3d4849897691 ("dt-bindings: Add Broadcom AVS RO thermal")
> ---

Applied, thanks

>  .../devicetree/bindings/thermal/brcm,avs-ro-thermal.yaml         | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/brcm,avs-ro-thermal.yaml b/Documentation/devicetree/bindings/thermal/brcm,avs-ro-thermal.yaml
> index 98e7b57..d9fdf48 100644
> --- a/Documentation/devicetree/bindings/thermal/brcm,avs-ro-thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/brcm,avs-ro-thermal.yaml
> @@ -23,12 +23,15 @@ properties:
>    compatible:
>      const: brcm,bcm2711-thermal
>  
> -  reg:
> -    maxItems: 1
> +  # See ./thermal.txt for details
> +  "#thermal-sensor-cells":
> +    const: 0
>  
>  required:
>    - compatible
> -  - reg
> +  - '#thermal-sensor-cells'
> +
> +additionalProperties: false
>  
>  examples:
>    - |
>

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/thermal/brcm,avs-ro-thermal.yaml b/Documentation/devicetree/bindings/thermal/brcm,avs-ro-thermal.yaml
index 98e7b57..d9fdf48 100644
--- a/Documentation/devicetree/bindings/thermal/brcm,avs-ro-thermal.yaml
+++ b/Documentation/devicetree/bindings/thermal/brcm,avs-ro-thermal.yaml
@@ -23,12 +23,15 @@  properties:
   compatible:
     const: brcm,bcm2711-thermal
 
-  reg:
-    maxItems: 1
+  # See ./thermal.txt for details
+  "#thermal-sensor-cells":
+    const: 0
 
 required:
   - compatible
-  - reg
+  - '#thermal-sensor-cells'
+
+additionalProperties: false
 
 examples:
   - |