| Message ID | 1579217994-22219-3-git-send-email-vnkgutta@codeaurora.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | Add device tree and clock drivers for SM8250 SoC | expand |
On 16-01-20, 15:39, Venkata Narendra Kumar Gutta wrote: > From: Taniya Das <tdas@codeaurora.org> > > Add support for RPMH clocks on SM8250. Reviewed-by: Vinod Koul <vkoul@kernel.org>
Quoting Venkata Narendra Kumar Gutta (2020-01-16 15:39:49) > @@ -490,6 +512,7 @@ static int clk_rpmh_probe(struct platform_device *pdev) > { .compatible = "qcom,sdm845-rpmh-clk", .data = &clk_rpmh_sdm845}, > { .compatible = "qcom,sm8150-rpmh-clk", .data = &clk_rpmh_sm8150}, > { .compatible = "qcom,sc7180-rpmh-clk", .data = &clk_rpmh_sc7180}, > + { .compatible = "qcom,sm8250-rpmh-clk", .data = &clk_rpmh_sm8250}, We should sort this on compatible. > { } > }; > MODULE_DEVICE_TABLE(of, clk_rpmh_match_table);
On Wed 22 Jan 22:46 PST 2020, Stephen Boyd wrote: > Quoting Venkata Narendra Kumar Gutta (2020-01-16 15:39:49) > > @@ -490,6 +512,7 @@ static int clk_rpmh_probe(struct platform_device *pdev) > > { .compatible = "qcom,sdm845-rpmh-clk", .data = &clk_rpmh_sdm845}, > > { .compatible = "qcom,sm8150-rpmh-clk", .data = &clk_rpmh_sm8150}, > > { .compatible = "qcom,sc7180-rpmh-clk", .data = &clk_rpmh_sc7180}, > > + { .compatible = "qcom,sm8250-rpmh-clk", .data = &clk_rpmh_sm8250}, > > We should sort this on compatible. > Yes we should, in case this was a request I sent out a patch for this: https://lore.kernel.org/linux-arm-msm/20200124175934.3937473-1-bjorn.andersson@linaro.org/ Regards, Bjorn > > { } > > }; > > MODULE_DEVICE_TABLE(of, clk_rpmh_match_table);
On Thu 16 Jan 15:39 PST 2020, Venkata Narendra Kumar Gutta wrote: > From: Taniya Das <tdas@codeaurora.org> > > Add support for RPMH clocks on SM8250. > > Signed-off-by: Taniya Das <tdas@codeaurora.org> > Signed-off-by: Venkata Narendra Kumar Gutta <vnkgutta@codeaurora.org> > --- > drivers/clk/qcom/clk-rpmh.c | 25 ++++++++++++++++++++++++- > 1 file changed, 24 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c > index 593bfa4..0e45adf 100644 > --- a/drivers/clk/qcom/clk-rpmh.c > +++ b/drivers/clk/qcom/clk-rpmh.c > @@ -1,6 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0 > /* > - * Copyright (c) 2018-2019, The Linux Foundation. All rights reserved. > + * Copyright (c) 2018-2020, The Linux Foundation. All rights reserved. > */ > > #include <linux/clk-provider.h> > @@ -404,6 +404,28 @@ static unsigned long clk_rpmh_bcm_recalc_rate(struct clk_hw *hw, > .num_clks = ARRAY_SIZE(sc7180_rpmh_clocks), > }; > > +DEFINE_CLK_RPMH_VRM(sm8250, ln_bb_clk1, ln_bb_clk1_ao, "lnbclka1", 2); > + > +static struct clk_hw *sm8250_rpmh_clocks[] = { > + [RPMH_CXO_CLK] = &sdm845_bi_tcxo.hw, > + [RPMH_CXO_CLK_A] = &sdm845_bi_tcxo_ao.hw, > + [RPMH_LN_BB_CLK1] = &sm8250_ln_bb_clk1.hw, > + [RPMH_LN_BB_CLK1_A] = &sm8250_ln_bb_clk1_ao.hw, > + [RPMH_LN_BB_CLK2] = &sdm845_ln_bb_clk2.hw, > + [RPMH_LN_BB_CLK2_A] = &sdm845_ln_bb_clk2_ao.hw, > + [RPMH_LN_BB_CLK3] = &sdm845_ln_bb_clk3.hw, > + [RPMH_LN_BB_CLK3_A] = &sdm845_ln_bb_clk3_ao.hw, > + [RPMH_RF_CLK1] = &sdm845_rf_clk1.hw, > + [RPMH_RF_CLK1_A] = &sdm845_rf_clk1_ao.hw, > + [RPMH_RF_CLK3] = &sdm845_rf_clk3.hw, > + [RPMH_RF_CLK3_A] = &sdm845_rf_clk3_ao.hw, > +}; > + > +static const struct clk_rpmh_desc clk_rpmh_sm8250 = { > + .clks = sm8250_rpmh_clocks, > + .num_clks = ARRAY_SIZE(sm8250_rpmh_clocks), > +}; > + > static struct clk_hw *of_clk_rpmh_hw_get(struct of_phandle_args *clkspec, > void *data) > { > @@ -490,6 +512,7 @@ static int clk_rpmh_probe(struct platform_device *pdev) > { .compatible = "qcom,sdm845-rpmh-clk", .data = &clk_rpmh_sdm845}, > { .compatible = "qcom,sm8150-rpmh-clk", .data = &clk_rpmh_sm8150}, > { .compatible = "qcom,sc7180-rpmh-clk", .data = &clk_rpmh_sc7180}, > + { .compatible = "qcom,sm8250-rpmh-clk", .data = &clk_rpmh_sm8250}, Double space before .data Apart from that Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn > { } > }; > MODULE_DEVICE_TABLE(of, clk_rpmh_match_table); > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project
diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c index 593bfa4..0e45adf 100644 --- a/drivers/clk/qcom/clk-rpmh.c +++ b/drivers/clk/qcom/clk-rpmh.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 /* - * Copyright (c) 2018-2019, The Linux Foundation. All rights reserved. + * Copyright (c) 2018-2020, The Linux Foundation. All rights reserved. */ #include <linux/clk-provider.h> @@ -404,6 +404,28 @@ static unsigned long clk_rpmh_bcm_recalc_rate(struct clk_hw *hw, .num_clks = ARRAY_SIZE(sc7180_rpmh_clocks), }; +DEFINE_CLK_RPMH_VRM(sm8250, ln_bb_clk1, ln_bb_clk1_ao, "lnbclka1", 2); + +static struct clk_hw *sm8250_rpmh_clocks[] = { + [RPMH_CXO_CLK] = &sdm845_bi_tcxo.hw, + [RPMH_CXO_CLK_A] = &sdm845_bi_tcxo_ao.hw, + [RPMH_LN_BB_CLK1] = &sm8250_ln_bb_clk1.hw, + [RPMH_LN_BB_CLK1_A] = &sm8250_ln_bb_clk1_ao.hw, + [RPMH_LN_BB_CLK2] = &sdm845_ln_bb_clk2.hw, + [RPMH_LN_BB_CLK2_A] = &sdm845_ln_bb_clk2_ao.hw, + [RPMH_LN_BB_CLK3] = &sdm845_ln_bb_clk3.hw, + [RPMH_LN_BB_CLK3_A] = &sdm845_ln_bb_clk3_ao.hw, + [RPMH_RF_CLK1] = &sdm845_rf_clk1.hw, + [RPMH_RF_CLK1_A] = &sdm845_rf_clk1_ao.hw, + [RPMH_RF_CLK3] = &sdm845_rf_clk3.hw, + [RPMH_RF_CLK3_A] = &sdm845_rf_clk3_ao.hw, +}; + +static const struct clk_rpmh_desc clk_rpmh_sm8250 = { + .clks = sm8250_rpmh_clocks, + .num_clks = ARRAY_SIZE(sm8250_rpmh_clocks), +}; + static struct clk_hw *of_clk_rpmh_hw_get(struct of_phandle_args *clkspec, void *data) { @@ -490,6 +512,7 @@ static int clk_rpmh_probe(struct platform_device *pdev) { .compatible = "qcom,sdm845-rpmh-clk", .data = &clk_rpmh_sdm845}, { .compatible = "qcom,sm8150-rpmh-clk", .data = &clk_rpmh_sm8150}, { .compatible = "qcom,sc7180-rpmh-clk", .data = &clk_rpmh_sc7180}, + { .compatible = "qcom,sm8250-rpmh-clk", .data = &clk_rpmh_sm8250}, { } }; MODULE_DEVICE_TABLE(of, clk_rpmh_match_table);