| Message ID | 20200117015011.50412-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [-next] xfs: remove unused variable 'done' | expand |
On Fri, Jan 17, 2020 at 09:50:11AM +0800, YueHaibing wrote: > fs/xfs/xfs_inode.c: In function 'xfs_itruncate_extents_flags': > fs/xfs/xfs_inode.c:1523:8: warning: unused variable 'done' [-Wunused-variable] > > commit 4bbb04abb4ee ("xfs: truncate should remove > all blocks, not just to the end of the page cache") > left behind this, so remove it. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Looks ok, Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> --D > --- > fs/xfs/xfs_inode.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c > index 1309f25..1979a00 100644 > --- a/fs/xfs/xfs_inode.c > +++ b/fs/xfs/xfs_inode.c > @@ -1520,7 +1520,6 @@ xfs_itruncate_extents_flags( > xfs_fileoff_t first_unmap_block; > xfs_filblks_t unmap_len; > int error = 0; > - int done = 0; > > ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL)); > ASSERT(!atomic_read(&VFS_I(ip)->i_count) || > -- > 2.7.4 > >
diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c index 1309f25..1979a00 100644 --- a/fs/xfs/xfs_inode.c +++ b/fs/xfs/xfs_inode.c @@ -1520,7 +1520,6 @@ xfs_itruncate_extents_flags( xfs_fileoff_t first_unmap_block; xfs_filblks_t unmap_len; int error = 0; - int done = 0; ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL)); ASSERT(!atomic_read(&VFS_I(ip)->i_count) ||
fs/xfs/xfs_inode.c: In function 'xfs_itruncate_extents_flags': fs/xfs/xfs_inode.c:1523:8: warning: unused variable 'done' [-Wunused-variable] commit 4bbb04abb4ee ("xfs: truncate should remove all blocks, not just to the end of the page cache") left behind this, so remove it. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- fs/xfs/xfs_inode.c | 1 - 1 file changed, 1 deletion(-)