[-next] ASoC: rt715: fix return value check in rt715_sdw_probe()
diff mbox series

Message ID 20200117024149.75515-1-weiyongjun1@huawei.com
State Accepted
Commit f9f5bbf5783cd63369d3e6c8cf27e2bd7c5ac2c3
Headers show
  • [-next] ASoC: rt715: fix return value check in rt715_sdw_probe()
Related show

Commit Message

Wei Yongjun Jan. 17, 2020, 2:41 a.m. UTC
In case of error, the function devm_regmap_init() returns ERR_PTR() and
never returns NULL. The NULL test in the return value check should be
replaced with IS_ERR().

Fixes: d1ede0641b05 ("ASoC: rt715: add RT715 codec driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
 sound/soc/codecs/rt715-sdw.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff mbox series

diff --git a/sound/soc/codecs/rt715-sdw.c b/sound/soc/codecs/rt715-sdw.c
index 18868e4ae6e8..6d892c44c522 100644
--- a/sound/soc/codecs/rt715-sdw.c
+++ b/sound/soc/codecs/rt715-sdw.c
@@ -535,8 +535,8 @@  static int rt715_sdw_probe(struct sdw_slave *slave,
 	regmap = devm_regmap_init(&slave->dev, NULL, &slave->dev,
-	if (!regmap)
-		return -EINVAL;
+	if (IS_ERR(regmap))
+		return PTR_ERR(regmap);
 	rt715_init(&slave->dev, sdw_regmap, regmap, slave);