From patchwork Fri Jan 17 15:57:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: George Dunlap X-Patchwork-Id: 11339511 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 55DF613A0 for ; Fri, 17 Jan 2020 15:59:12 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 31D9B2064C for ; Fri, 17 Jan 2020 15:59:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="baalfIp+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 31D9B2064C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1isU0r-0002jn-Id; Fri, 17 Jan 2020 15:58:21 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1isU0q-0002j3-Ad for xen-devel@lists.xenproject.org; Fri, 17 Jan 2020 15:58:20 +0000 X-Inumbo-ID: 20c0987e-3942-11ea-b833-bc764e2007e4 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 20c0987e-3942-11ea-b833-bc764e2007e4; Fri, 17 Jan 2020 15:57:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1579276676; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=AM8Xf7hx61ynSqs8IBtGz549ZAkR2Wzi3DTSNGi918Q=; b=baalfIp+TaF1I5wZ2Pj88nw5AiPDMPsw9R+l9CVSdwwH+Lje06ZuegKK 2hoAQ37IMgiS6HW4zkgVcNHGUkqt59XDNVb6Y1DSfyezGNrT0ZriZmkeM ikYJF/6vakSHozbGa67i0/qyTB2WJpqnlWHpz37vIqFG/vD1W+TMWyWY5 c=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=george.dunlap@citrix.com; spf=Pass smtp.mailfrom=George.Dunlap@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa4.hc3370-68.iphmx.com: no sender authenticity information available from domain of george.dunlap@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="George.Dunlap@citrix.com"; x-sender="george.dunlap@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa4.hc3370-68.iphmx.com: domain of George.Dunlap@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="George.Dunlap@citrix.com"; x-sender="George.Dunlap@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa4.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="George.Dunlap@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: phDJsRD1+0pRTgV+tA2Wf07jXibt+z2i1gIbzgkboJ11U5Tzcljcv8DW41uwcNIwlAhADCL1sc U/VnphM3S3uxkHx5mOyEFPlvv2nP79uQnFCLaJHjQZeIF8BrkD4uFZgW6KnPBTtcFBn7xxn4wU INbIuxcI4KZj6ysGPpAXILDnASiLZp4OZqEj0sNpn00/lLXDykyk4TrbTQJ0sDMzU0+K3EHQ+a tw2SB9REVWkxqcc2guZrhQV9CPt4HxNUDagh68Qa++P4xTR6vgdyYEpiL5KwGDYkepoaqzJVZn Z5Q= X-SBRS: 2.7 X-MesageID: 11674368 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.70,330,1574139600"; d="scan'208";a="11674368" From: George Dunlap To: Date: Fri, 17 Jan 2020 15:57:34 +0000 Message-ID: <20200117155734.1067550-8-george.dunlap@citrix.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200117155734.1067550-1-george.dunlap@citrix.com> References: <20200117155734.1067550-1-george.dunlap@citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [PATCH v3 8/8] RFC: Sketch constructors, DomainCreateNew X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Nick Rosbrook , George Dunlap Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" This is a sketch of functionality suitable for creating a basic domain, with a disk and a vif. DomainConfig, DeviceDisk, and DeviceNic types are all created using constructor functions, which initialize them with libxl's defaults. DomainCreateNew takes the config and calls without any updates. Obviously some of these will need to be changed it we switch to passing references to .toC() rather than passing back by value. The main purpose of this is to allow testing of creating a hard-coded domain. Creating a domain would look like this: // type = "pv" dconf, err := xl.NewDomainConfig(xl.DomainTypePv) if err != nil { fmt.Printf("NewDomainConfig: %v\n", err) return } dconf.CInfo.Type = xl.DomainTypePv // name = "c6-01" dconf.CInfo.Name = "c6-01" // vcpus=4 dconf.BInfo.MaxVcpus = 4 // memory = "2048" dconf.BInfo.MaxMemkb = 2048 * 1024 dconf.BInfo.TargetMemkb = 2048 * 1024 // on_crash = 'destroy' dconf.OnCrash = xl.ActionOnShutdownDestroy // bootloader = "pygrub" dconf.BInfo.Bootloader = "pygrub" // disk = [ 'vdev=hda,format=raw,target=/images/c6-01.raw'] { disk, err := xl.NewDeviceDisk() if err != nil { fmt.Printf("NewDeviceDisk: %v\n", err) return } disk.Vdev = "hda" //disk.DiskBackend = xl.DiskBackendPhy disk.Format = xl.DiskFormatRaw disk.Readwrite = 1 disk.PdevPath = "/images/c6-01.raw" dconf.Disks = append(dconf.Disks, *disk) } // vif = [ 'mac=5a:5b:d6:f1:d6:b4' ] { vif, err := xl.NewDeviceNic() if err != nil { fmt.Printf("NewDeviceNic: %v\n", err) return } vif.Mac = xl.Mac{ 0x5a, 0x5b, 0xd6, 0x31, 0xd6, 0xb4 } dconf.Nics = append(dconf.Nics, *vif) } // serial='pty' # HVM only did, err := ctx.DomainCreateNew(dconf) if err != nil { fmt.Printf("Creating domain: %v\n", err) return } fmt.Printf("Domain %s(%d) created successfully", dconf.CInfo.Name, did) Signed-off-by: George Dunlap --- CC: Nick Rosbrook --- tools/golang/xenlight/xenlight.go | 66 +++++++++++++++++++++++++++++++ 1 file changed, 66 insertions(+) diff --git a/tools/golang/xenlight/xenlight.go b/tools/golang/xenlight/xenlight.go index c462e4bb42..5a21a2b9b8 100644 --- a/tools/golang/xenlight/xenlight.go +++ b/tools/golang/xenlight/xenlight.go @@ -1113,3 +1113,69 @@ func (Ctx *Context) PrimaryConsoleGetTty(domid uint32) (path string, err error) path = C.GoString(cpath) return } + +func NewDomainConfig(t DomainType) (*DomainConfig, error) { + var cconfig C.libxl_domain_config + + C.libxl_domain_config_init(&cconfig) + C.libxl_domain_build_info_init_type(&cconfig.b_info, C.libxl_domain_type(t)) + + gconfig := &DomainConfig{} + err := gconfig.fromC(&cconfig) + if err != nil { + return nil, err + } + + return gconfig, nil +} + +func NewDeviceDisk() (*DeviceDisk, error) { + var ctype C.libxl_device_disk + + C.libxl_device_disk_init(&ctype) + + gtype := &DeviceDisk{} + err := gtype.fromC(&ctype) + + if err != nil { + return nil, err + } + + return gtype, nil +} + +func NewDeviceNic() (*DeviceNic, error) { + var ctype C.libxl_device_nic + + C.libxl_device_nic_init(&ctype) + + gtype := &DeviceNic{} + err := gtype.fromC(&ctype) + + if err != nil { + return nil, err + } + + return gtype, nil +} + +// int libxl_domain_create_new(libxl_ctx *ctx, libxl_domain_config *d_config, +// uint32_t *domid, +// const libxl_asyncop_how *ao_how, +// const libxl_asyncprogress_how *aop_console_how) +func (Ctx *Context) DomainCreateNew(config *DomainConfig) (Domid, error) { + var cdomid C.uint32_t + var cconfig C.libxl_domain_config + err := config.toC(&cconfig) + if err != nil { + return Domid(0), fmt.Errorf("converting domain config to C: %v", err) + } + defer C.libxl_domain_config_dispose(&cconfig) + + ret := C.libxl_domain_create_new(Ctx.ctx, &cconfig, &cdomid, nil, nil) + if ret != 0 { + return Domid(0), Error(ret) + } + + return Domid(cdomid), nil +}