[v2] arm64: dts: allwinner: a64: Add gpio bank supply for A64-Olinuxino
diff mbox series

Message ID 20200118152459.17199-1-manu@FreeBSD.Org
State New
Headers show
Series
  • [v2] arm64: dts: allwinner: a64: Add gpio bank supply for A64-Olinuxino
Related show

Commit Message

Emmanuel Vadot Jan. 18, 2020, 3:24 p.m. UTC
From: Emmanuel Vadot <manu@freebsd.org>

Add the regulators for each bank on this boards.
For VCC-PL only add a comment on what regulator is used. We cannot add
the property without causing a circular dependency as the PL pins are
used to talk to the PMIC.

Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
---
v2:
 - Remove vcc-pl-supply in r_pio as it cause a circular dependency.

 .../boot/dts/allwinner/sun50i-a64-olinuxino.dts | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

Comments

Maxime Ripard Jan. 21, 2020, 9:10 a.m. UTC | #1
Hi,

On Sat, Jan 18, 2020 at 04:24:59PM +0100, Emmanuel Vadot wrote:
> From: Emmanuel Vadot <manu@freebsd.org>
>
> Add the regulators for each bank on this boards.
> For VCC-PL only add a comment on what regulator is used. We cannot add
> the property without causing a circular dependency as the PL pins are
> used to talk to the PMIC.
>
> Signed-off-by: Emmanuel Vadot <manu@freebsd.org>

It seems that you sent it twice?

I applied the second. It was not applying properly though, make sure
to base your patches on next.

Maxime

Patch
diff mbox series

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
index 01a9a52edae4..7e71b5b12f98 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
@@ -163,6 +163,17 @@  &ohci1 {
 	status = "okay";
 };
 
+&pio {
+	vcc-pa-supply = <&reg_dcdc1>;
+	vcc-pb-supply = <&reg_dcdc1>;
+	vcc-pc-supply = <&reg_dcdc1>;
+	vcc-pd-supply = <&reg_dcdc1>;
+	vcc-pe-supply = <&reg_aldo1>;
+	vcc-pf-supply = <&reg_dcdc1>;
+	vcc-pg-supply = <&reg_dldo4>;
+	vcc-ph-supply = <&reg_dcdc1>;
+};
+
 &r_rsb {
 	status = "okay";
 
@@ -175,6 +186,12 @@  axp803: pmic@3a3 {
 	};
 };
 
+/* VCC-PL is powered by aldo2 but we cannot add it as the RSB */
+/* interface used to talk to the PMIC in on the PL pins */
+/* &r_pio { */
+/*	vcc-pl-supply = <&reg_aldo2>; */
+/* }; */
+
 #include "axp803.dtsi"
 
 &ac_power_supply {