| Message ID | 20200121151518.27530-1-linmiaohe@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | KVM: VMX: remove duplicated segment cache clear | expand |
Miaohe Lin <linmiaohe@huawei.com> writes: > vmx_set_segment() clears segment cache unconditionally, so we should not > clear it again by calling vmx_segment_cache_clear(). > > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> > --- > arch/x86/kvm/vmx/vmx.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c > index b5a0c2e05825..b32236e6b513 100644 > --- a/arch/x86/kvm/vmx/vmx.c > +++ b/arch/x86/kvm/vmx/vmx.c > @@ -2688,8 +2688,6 @@ static void enter_pmode(struct kvm_vcpu *vcpu) > > vmx->rmode.vm86_active = 0; > > - vmx_segment_cache_clear(vmx); > - > vmx_set_segment(vcpu, &vmx->rmode.segs[VCPU_SREG_TR], VCPU_SREG_TR); > > flags = vmcs_readl(GUEST_RFLAGS); Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
On 21/01/20 16:15, Miaohe Lin wrote: > vmx_set_segment() clears segment cache unconditionally, so we should not > clear it again by calling vmx_segment_cache_clear(). > > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> > --- > arch/x86/kvm/vmx/vmx.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c > index b5a0c2e05825..b32236e6b513 100644 > --- a/arch/x86/kvm/vmx/vmx.c > +++ b/arch/x86/kvm/vmx/vmx.c > @@ -2688,8 +2688,6 @@ static void enter_pmode(struct kvm_vcpu *vcpu) > > vmx->rmode.vm86_active = 0; > > - vmx_segment_cache_clear(vmx); > - > vmx_set_segment(vcpu, &vmx->rmode.segs[VCPU_SREG_TR], VCPU_SREG_TR); > > flags = vmcs_readl(GUEST_RFLAGS); > Queued, thanks. Paolo
diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c index b5a0c2e05825..b32236e6b513 100644 --- a/arch/x86/kvm/vmx/vmx.c +++ b/arch/x86/kvm/vmx/vmx.c @@ -2688,8 +2688,6 @@ static void enter_pmode(struct kvm_vcpu *vcpu) vmx->rmode.vm86_active = 0; - vmx_segment_cache_clear(vmx); - vmx_set_segment(vcpu, &vmx->rmode.segs[VCPU_SREG_TR], VCPU_SREG_TR); flags = vmcs_readl(GUEST_RFLAGS);
vmx_set_segment() clears segment cache unconditionally, so we should not clear it again by calling vmx_segment_cache_clear(). Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> --- arch/x86/kvm/vmx/vmx.c | 2 -- 1 file changed, 2 deletions(-)