| Message ID | 20200121134705.GA28240@SandeshPC (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | staging: mt7621-pinctrl: Align to fix warnings of line over 80 characters | expand |
On Tue, Jan 21, 2020 at 02:47:05PM +0100, Sandesh Kenjana Ashok wrote: > Issue found by checkpatch. > > Signed-off-by: Sandesh Kenjana Ashok <sandeshkenjanaashok@gmail.com> > --- > drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c b/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c > index d0f06790d38f..df5da5fce630 100644 > --- a/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c > +++ b/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c > @@ -159,7 +159,8 @@ static int rt2880_pmx_group_enable(struct pinctrl_dev *pctrldev, > } > > static int rt2880_pmx_group_gpio_request_enable(struct pinctrl_dev *pctrldev, > - struct pinctrl_gpio_range *range, > + struct pinctrl_gpio_range > + *range, Ick, that looks worse now, right? checkpatch is a guideline, not a hard-and-fast rule here. > unsigned int pin) > { > struct rt2880_priv *p = pinctrl_dev_get_drvdata(pctrldev); > @@ -218,10 +219,10 @@ static int rt2880_pinmux_index(struct rt2880_priv *p) > p->func_count++; > > /* allocate our function and group mapping index buffers */ > - f = p->func = devm_kcalloc(p->dev, > - p->func_count, > - sizeof(struct rt2880_pmx_func), > - GFP_KERNEL); > + f = p->func; > + p->func = devm_kcalloc(p->dev, p->func_count, > + sizeof(struct rt2880_pmx_func), GFP_KERNEL); > + You broke the code here :( Please learn a bit more about how C works before attempting to work on kernel code. thanks, greg k-h
diff --git a/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c b/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c index d0f06790d38f..df5da5fce630 100644 --- a/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c +++ b/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c @@ -159,7 +159,8 @@ static int rt2880_pmx_group_enable(struct pinctrl_dev *pctrldev, } static int rt2880_pmx_group_gpio_request_enable(struct pinctrl_dev *pctrldev, - struct pinctrl_gpio_range *range, + struct pinctrl_gpio_range + *range, unsigned int pin) { struct rt2880_priv *p = pinctrl_dev_get_drvdata(pctrldev); @@ -218,10 +219,10 @@ static int rt2880_pinmux_index(struct rt2880_priv *p) p->func_count++; /* allocate our function and group mapping index buffers */ - f = p->func = devm_kcalloc(p->dev, - p->func_count, - sizeof(struct rt2880_pmx_func), - GFP_KERNEL); + f = p->func; + p->func = devm_kcalloc(p->dev, p->func_count, + sizeof(struct rt2880_pmx_func), GFP_KERNEL); + gpio_func.groups = devm_kcalloc(p->dev, p->group_count, sizeof(int), GFP_KERNEL); if (!f || !gpio_func.groups)
Issue found by checkpatch. Signed-off-by: Sandesh Kenjana Ashok <sandeshkenjanaashok@gmail.com> --- drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)