arm64: kbuild: remove compressed images on 'make ARCH=arm64 (dist)clean'
diff mbox series

Message ID 20200121134739.22879-1-erosca@de.adit-jv.com
State Mainlined
Commit d7bbd6c1b01cb5dd13c245d4586a83145c1d5f52
Headers show
Series
  • arm64: kbuild: remove compressed images on 'make ARCH=arm64 (dist)clean'
Related show

Commit Message

Eugeniu Rosca Jan. 21, 2020, 1:47 p.m. UTC
From: Dirk Behme <dirk.behme@de.bosch.com>

Since v4.3-rc1 commit 0723c05fb75e44 ("arm64: enable more compressed
Image formats"), it is possible to build Image.{bz2,lz4,lzma,lzo}
AArch64 images. However, the commit missed adding support for removing
those images on 'make ARCH=arm64 (dist)clean'.

Fix this by adding them to the target list.
Make sure to match the order of the recipes in the makefile.

Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
---
 arch/arm64/boot/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Masahiro Yamada Jan. 21, 2020, 3:23 p.m. UTC | #1
Hi.

On Tue, Jan 21, 2020 at 10:48 PM Eugeniu Rosca <erosca@de.adit-jv.com> wrote:
>
> From: Dirk Behme <dirk.behme@de.bosch.com>
>
> Since v4.3-rc1 commit 0723c05fb75e44 ("arm64: enable more compressed
> Image formats"), it is possible to build Image.{bz2,lz4,lzma,lzo}
> AArch64 images. However, the commit missed adding support for removing
> those images on 'make ARCH=arm64 (dist)clean'.
>
> Fix this by adding them to the target list.
> Make sure to match the order of the recipes in the makefile.
>
> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>

Please change Cc with my

Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>


Thanks.


> Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
> Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
> ---
>  arch/arm64/boot/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/Makefile b/arch/arm64/boot/Makefile
> index 1f012c506434..cd3414898d10 100644
> --- a/arch/arm64/boot/Makefile
> +++ b/arch/arm64/boot/Makefile
> @@ -16,7 +16,7 @@
>
>  OBJCOPYFLAGS_Image :=-O binary -R .note -R .note.gnu.build-id -R .comment -S
>
> -targets := Image Image.gz
> +targets := Image Image.bz2 Image.gz Image.lz4 Image.lzma Image.lzo
>
>  $(obj)/Image: vmlinux FORCE
>         $(call if_changed,objcopy)
> --
> 2.25.0
>
Eugeniu Rosca Jan. 21, 2020, 3:58 p.m. UTC | #2
Hello Yamada-san,

On Wed, Jan 22, 2020 at 12:23:45AM +0900, Masahiro Yamada wrote:
> Please change Cc with my
> 
> Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Updated in https://lore.kernel.org/linux-arm-kernel/20200121155439.1061-1-erosca@de.adit-jv.com/

Thank you for reviewing the patch.

Patch
diff mbox series

diff --git a/arch/arm64/boot/Makefile b/arch/arm64/boot/Makefile
index 1f012c506434..cd3414898d10 100644
--- a/arch/arm64/boot/Makefile
+++ b/arch/arm64/boot/Makefile
@@ -16,7 +16,7 @@ 
 
 OBJCOPYFLAGS_Image :=-O binary -R .note -R .note.gnu.build-id -R .comment -S
 
-targets := Image Image.gz
+targets := Image Image.bz2 Image.gz Image.lz4 Image.lzma Image.lzo
 
 $(obj)/Image: vmlinux FORCE
 	$(call if_changed,objcopy)